Rector changes and immplementations of required methods

src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseApiController.php

@@ -131,7 +131,7 @@ final class AccompanyingCourseApiController extends ApiController
     /**
      * @ParamConverter("person", options={"id": "person_id"})
      */
-    public function getAccompanyingPeriodsByPerson(Person $person)
+    public function getAccompanyingPeriodsByPerson(Person $person): \Symfony\Component\HttpFoundation\JsonResponse
     {
         $accompanyingPeriods = $person->getCurrentAccompanyingPeriods();
         $accompanyingPeriodsChecked = array_filter(
@@ -142,7 +142,7 @@ final class AccompanyingCourseApiController extends ApiController
         return $this->json(\array_values($accompanyingPeriodsChecked), Response::HTTP_OK, [], ['groups' => ['read']]);
     }
 
-    public function participationApi($id, Request $request, $_format)
+    public function participationApi($id, Request $request, $_format): \Symfony\Component\HttpFoundation\JsonResponse
     {
         /** @var AccompanyingPeriod $accompanyingPeriod */
         $accompanyingPeriod = $this->getEntity('participation', $id, $request);
@@ -275,7 +275,7 @@ final class AccompanyingCourseApiController extends ApiController
      * @ParamConverter("accompanyingCourse", options={"id": "id"})
      */
     #[Route(path: '/api/1.0/person/accompanying-course/{id}/confidential.json', name: 'chill_api_person_accompanying_period_confidential')]
-    public function toggleConfidentialApi(AccompanyingPeriod $accompanyingCourse, mixed $id, Request $request)
+    public function toggleConfidentialApi(AccompanyingPeriod $accompanyingCourse, mixed $id, Request $request): \Symfony\Component\HttpFoundation\JsonResponse
     {
         if ('POST' === $request->getMethod()) {
             $this->denyAccessUnlessGranted(AccompanyingPeriodVoter::TOGGLE_CONFIDENTIAL, $accompanyingCourse);
@@ -292,7 +292,7 @@ final class AccompanyingCourseApiController extends ApiController
      * @ParamConverter("accompanyingCourse", options={"id": "id"})
      */
     #[Route(path: '/api/1.0/person/accompanying-course/{id}/intensity.json', name: 'chill_api_person_accompanying_period_intensity')]
-    public function toggleIntensityApi(AccompanyingPeriod $accompanyingCourse, Request $request)
+    public function toggleIntensityApi(AccompanyingPeriod $accompanyingCourse, Request $request): \Symfony\Component\HttpFoundation\JsonResponse
     {
         if ('POST' === $request->getMethod()) {
             $this->denyAccessUnlessGranted(AccompanyingPeriodVoter::TOGGLE_INTENSITY, $accompanyingCourse);

src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseController.php

@@ -98,7 +98,7 @@ final class AccompanyingCourseController extends \Symfony\Bundle\FrameworkBundle
      * @ParamConverter("accompanyingCourse", options={"id": "accompanying_period_id"})
      */
     #[Route(path: '/{_locale}/parcours/{accompanying_period_id}/delete', name: 'chill_person_accompanying_course_delete')]
-    public function deleteAction(Request $request, AccompanyingPeriod $accompanyingCourse)
+    public function deleteAction(Request $request, AccompanyingPeriod $accompanyingCourse): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         $em = $this->managerRegistry->getManager();
 

src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseWorkController.php

@@ -84,7 +84,7 @@ final class AccompanyingCourseWorkController extends AbstractController
 
             if ($form->isSubmitted() && $form->isValid()) {
                 $this->chillLogger->notice('An accompanying period work has been removed', [
-                    'by_user' => $this->getUser()->getUsername(),
+                    'by_user' => $this->getUser()->getUserIdentifier(),
                     'work_id' => $work->getId(),
                     'accompanying_period_id' => $work->getAccompanyingPeriod()->getId(),
                 ]);

src/Bundle/ChillPersonBundle/Controller/AdminController.php

@@ -20,25 +20,25 @@ use Symfony\Component\Routing\Annotation\Route;
 class AdminController extends AbstractController
 {
     #[Route(path: '/{_locale}/admin/accompanying-course', name: 'chill_accompanying-course_admin_index')]
-    public function indexAccompanyingCourseAdminAction()
+    public function indexAccompanyingCourseAdminAction(): \Symfony\Component\HttpFoundation\Response
     {
         return $this->render('@ChillPerson/Admin/indexAccompanyingCourse.html.twig');
     }
 
     #[Route(path: '/{_locale}/admin/household', name: 'chill_household_admin_index')]
-    public function indexHouseholdAdminAction()
+    public function indexHouseholdAdminAction(): \Symfony\Component\HttpFoundation\Response
     {
         return $this->render('@ChillPerson/Admin/indexHousehold.html.twig');
     }
 
     #[Route(path: '/{_locale}/admin/person', name: 'chill_person_admin_index')]
-    public function indexPersonAdminAction()
+    public function indexPersonAdminAction(): \Symfony\Component\HttpFoundation\Response
     {
         return $this->render('@ChillPerson/Admin/indexPerson.html.twig');
     }
 
     #[Route(path: '/{_locale}/admin/social-work', name: 'chill_social-work_admin_index')]
-    public function indexSocialWorkAdminAction()
+    public function indexSocialWorkAdminAction(): \Symfony\Component\HttpFoundation\Response
     {
         return $this->render('@ChillPerson/Admin/indexSocialWork.html.twig');
     }
@@ -47,7 +47,7 @@ class AdminController extends AbstractController
      * @return \Symfony\Component\HttpFoundation\RedirectResponse
      */
     #[Route(path: '/{_locale}/admin/person_redirect_to_main', name: 'chill_person_admin_redirect_to_admin_index', options: [null])]
-    public function redirectToAdminIndexAction()
+    public function redirectToAdminIndexAction(): \Symfony\Component\HttpFoundation\RedirectResponse
     {
         return $this->redirectToRoute('chill_main_admin_central');
     }

src/Bundle/ChillPersonBundle/Controller/HouseholdApiController.php

@@ -103,7 +103,7 @@ class HouseholdApiController extends ApiController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/api/1.0/person/address/suggest/by-household/{household_id}.{_format}', name: 'chill_person_address_suggest_by_household', requirements: ['_format' => 'json'])]
-    public function suggestAddressByHousehold(Household $household, string $_format)
+    public function suggestAddressByHousehold(Household $household, string $_format): \Symfony\Component\HttpFoundation\JsonResponse
     {
         // TODO add acl
 
@@ -149,7 +149,7 @@ class HouseholdApiController extends ApiController
      *
      * @ParamConverter("person", options={"id": "person_id"})
      */
-    public function suggestHouseholdByAccompanyingPeriodParticipationApi(Person $person, string $_format)
+    public function suggestHouseholdByAccompanyingPeriodParticipationApi(Person $person, string $_format): \Symfony\Component\HttpFoundation\JsonResponse
     {
         // TODO add acl
 

src/Bundle/ChillPersonBundle/Controller/HouseholdController.php

@@ -38,7 +38,7 @@ class HouseholdController extends AbstractController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/{household_id}/accompanying-period', name: 'chill_person_household_accompanying_period', methods: ['GET', 'HEAD'])]
-    public function accompanyingPeriod(Request $request, Household $household)
+    public function accompanyingPeriod(Request $request, Household $household): \Symfony\Component\HttpFoundation\Response
     {
         $currentMembers = $household->getCurrentPersons();
         $accompanyingPeriods = [];
@@ -88,7 +88,7 @@ class HouseholdController extends AbstractController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/{household_id}/address/edit', name: 'chill_person_household_address_edit', methods: ['GET', 'HEAD', 'POST'])]
-    public function addressEdit(Request $request, Household $household)
+    public function addressEdit(Request $request, Household $household): \Symfony\Component\HttpFoundation\Response
     {
         // TODO ACL
 
@@ -110,7 +110,7 @@ class HouseholdController extends AbstractController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/{household_id}/addresses', name: 'chill_person_household_addresses', methods: ['GET', 'HEAD'])]
-    public function addresses(Request $request, Household $household)
+    public function addresses(Request $request, Household $household): \Symfony\Component\HttpFoundation\Response
     {
         // TODO ACL
 
@@ -136,7 +136,7 @@ class HouseholdController extends AbstractController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/{household_id}/address/move', name: 'chill_person_household_address_move', methods: ['GET', 'HEAD', 'POST'])]
-    public function addressMove(Request $request, Household $household)
+    public function addressMove(Request $request, Household $household): \Symfony\Component\HttpFoundation\Response
     {
         // TODO ACL
 
@@ -152,7 +152,7 @@ class HouseholdController extends AbstractController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/{household_id}/address/edit_valid_from', name: 'chill_person_household_address_valid_from_edit', methods: ['GET', 'HEAD', 'POST'])]
-    public function addressValidFromEdit(Request $request, Household $household)
+    public function addressValidFromEdit(Request $request, Household $household): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         $this->denyAccessUnlessGranted(HouseholdVoter::EDIT, $household);
 
@@ -204,7 +204,7 @@ class HouseholdController extends AbstractController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/{household_id}/members/metadata/edit', name: 'chill_person_household_members_metadata_edit', methods: ['GET', 'POST'])]
-    public function editHouseholdMetadata(Request $request, Household $household)
+    public function editHouseholdMetadata(Request $request, Household $household): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         // TODO ACL
         $form = $this->createMetadataForm($household);
@@ -237,7 +237,7 @@ class HouseholdController extends AbstractController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/{household_id}/relationship', name: 'chill_person_household_relationship', methods: ['GET', 'HEAD'])]
-    public function showRelationship(Request $request, Household $household)
+    public function showRelationship(Request $request, Household $household): \Symfony\Component\HttpFoundation\Response
     {
         $jsonString = $this->serializer->serialize(
             $household->getCurrentPersons(),
@@ -258,7 +258,7 @@ class HouseholdController extends AbstractController
      * @ParamConverter("household", options={"id": "household_id"})
      */
     #[Route(path: '/{household_id}/summary', name: 'chill_person_household_summary', methods: ['GET', 'HEAD'])]
-    public function summary(Request $request, Household $household)
+    public function summary(Request $request, Household $household): \Symfony\Component\HttpFoundation\Response
     {
         // TODO ACL
 

src/Bundle/ChillPersonBundle/Controller/HouseholdMemberController.php

@@ -93,7 +93,7 @@ class HouseholdMemberController extends ApiController
      *     to leave household without joining another
      */
     #[Route(path: '/{_locale}/person/household/members/editor', name: 'chill_person_household_members_editor')]
-    public function editor(Request $request)
+    public function editor(Request $request): \Symfony\Component\HttpFoundation\Response
     {
         $ids = $request->query->all('persons');
 

src/Bundle/ChillPersonBundle/Controller/PersonAddressController.php

@@ -32,7 +32,7 @@ class PersonAddressController extends AbstractController
     public function __construct(private readonly ValidatorInterface $validator, private readonly TranslatorInterface $translator, private readonly \Doctrine\Persistence\ManagerRegistry $managerRegistry) {}
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/address/create', name: 'chill_person_address_create', methods: ['POST'])]
-    public function createAction(mixed $person_id, Request $request)
+    public function createAction(mixed $person_id, Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         $person = $this->managerRegistry->getManager()
             ->getRepository(Person::class)
@@ -87,7 +87,7 @@ class PersonAddressController extends AbstractController
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/address/{address_id}/edit', name: 'chill_person_address_edit')]
-    public function editAction(mixed $person_id, mixed $address_id)
+    public function editAction(mixed $person_id, mixed $address_id): \Symfony\Component\HttpFoundation\Response
     {
         $person = $this->managerRegistry->getManager()
             ->getRepository(Person::class)
@@ -115,7 +115,7 @@ class PersonAddressController extends AbstractController
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/address/list', name: 'chill_person_address_list')]
-    public function listAction(mixed $person_id)
+    public function listAction(mixed $person_id): \Symfony\Component\HttpFoundation\Response
     {
         $person = $this->managerRegistry->getManager()
             ->getRepository(Person::class)
@@ -137,7 +137,7 @@ class PersonAddressController extends AbstractController
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/address/new', name: 'chill_person_address_new')]
-    public function newAction(mixed $person_id)
+    public function newAction(mixed $person_id): \Symfony\Component\HttpFoundation\Response
     {
         $person = $this->managerRegistry->getManager()
             ->getRepository(Person::class)
@@ -164,7 +164,7 @@ class PersonAddressController extends AbstractController
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/address/{address_id}/update', name: 'chill_person_address_update')]
-    public function updateAction(mixed $person_id, mixed $address_id, Request $request)
+    public function updateAction(mixed $person_id, mixed $address_id, Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         $person = $this->managerRegistry->getManager()
             ->getRepository(Person::class)

src/Bundle/ChillPersonBundle/Controller/PersonController.php

@@ -50,7 +50,7 @@ final class PersonController extends AbstractController
     ) {}
 
     #[Route(path: '/{_locale}/person/{person_id}/general/edit', name: 'chill_person_general_edit')]
-    public function editAction(int $person_id, Request $request)
+    public function editAction(int $person_id, Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         $person = $this->_getPerson($person_id);
 
@@ -241,7 +241,7 @@ final class PersonController extends AbstractController
     }
 
     #[Route(path: '/{_locale}/person/{person_id}/general', name: 'chill_person_view')]
-    public function viewAction(int $person_id)
+    public function viewAction(int $person_id): \Symfony\Component\HttpFoundation\Response
     {
         $person = $this->_getPerson($person_id);
 
@@ -273,7 +273,7 @@ final class PersonController extends AbstractController
      *
      * @return Person
      */
-    private function _getPerson(int $id)
+    private function _getPerson(int $id): ?\Chill\PersonBundle\Entity\Person
     {
         return $this->personRepository->find($id);
     }

src/Bundle/ChillPersonBundle/Controller/PersonDuplicateController.php

@@ -45,7 +45,7 @@ class PersonDuplicateController extends \Symfony\Bundle\FrameworkBundle\Controll
     ) {}
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person1_id}/duplicate/{person2_id}/confirm', name: 'chill_person_duplicate_confirm')]
-    public function confirmAction(mixed $person1_id, mixed $person2_id, Request $request)
+    public function confirmAction(mixed $person1_id, mixed $person2_id, Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         if ($person1_id === $person2_id) {
             throw new \InvalidArgumentException('Can not merge same person');
@@ -105,7 +105,7 @@ class PersonDuplicateController extends \Symfony\Bundle\FrameworkBundle\Controll
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/find-manually', name: 'chill_person_find_manually_duplicate')]
-    public function findManuallyDuplicateAction(mixed $person_id, Request $request)
+    public function findManuallyDuplicateAction(mixed $person_id, Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         $person = $this->_getPerson($person_id);
 
@@ -161,7 +161,7 @@ class PersonDuplicateController extends \Symfony\Bundle\FrameworkBundle\Controll
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person1_id}/duplicate/{person2_id}/not-duplicate', name: 'chill_person_duplicate_not_duplicate')]
-    public function notDuplicateAction(mixed $person1_id, mixed $person2_id)
+    public function notDuplicateAction(mixed $person1_id, mixed $person2_id): \Symfony\Component\HttpFoundation\RedirectResponse
     {
         $user = $this->security->getUser();
 
@@ -194,7 +194,7 @@ class PersonDuplicateController extends \Symfony\Bundle\FrameworkBundle\Controll
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person1_id}/duplicate/{person2_id}/remove-not-duplicate', name: 'chill_person_remove_duplicate_not_duplicate')]
-    public function removeNotDuplicateAction(mixed $person1_id, mixed $person2_id)
+    public function removeNotDuplicateAction(mixed $person1_id, mixed $person2_id): \Symfony\Component\HttpFoundation\RedirectResponse
     {
         [$person1, $person2] = $this->_getPersonsByPriority($person1_id, $person2_id);
 
@@ -216,7 +216,7 @@ class PersonDuplicateController extends \Symfony\Bundle\FrameworkBundle\Controll
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/duplicate/view', name: 'chill_person_duplicate_view')]
-    public function viewAction(mixed $person_id, PersonNotDuplicateRepository $personNotDuplicateRepository)
+    public function viewAction(mixed $person_id, PersonNotDuplicateRepository $personNotDuplicateRepository): \Symfony\Component\HttpFoundation\Response
     {
         $person = $this->_getPerson($person_id);
 

src/Bundle/ChillPersonBundle/Controller/PersonResourceController.php

@@ -109,7 +109,7 @@ final class PersonResourceController extends AbstractController
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/resources/list', name: 'chill_person_resource_list')]
-    public function listAction(Request $request, mixed $person_id)
+    public function listAction(Request $request, mixed $person_id): \Symfony\Component\HttpFoundation\Response
     {
         $personOwner = $this->personRepository->find($person_id);
         $this->denyAccessUnlessGranted(PersonVoter::SEE, $personOwner);
@@ -127,7 +127,7 @@ final class PersonResourceController extends AbstractController
     }
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/resources/new', name: 'chill_person_resource_new')]
-    public function newAction(Request $request, mixed $person_id)
+    public function newAction(Request $request, mixed $person_id): \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     {
         $personOwner = $this->personRepository->find($person_id);
         $personResource = new PersonResource();

src/Bundle/ChillPersonBundle/Controller/RelationshipApiController.php

@@ -25,7 +25,7 @@ class RelationshipApiController extends ApiController
     /**
      * @ParamConverter("person", options={"id": "person_id"})
      */
-    public function getRelationshipsByPerson(Person $person)
+    public function getRelationshipsByPerson(Person $person): \Symfony\Component\HttpFoundation\JsonResponse
     {
         $this->denyAccessUnlessGranted(PersonVoter::SEE, $person);
 

src/Bundle/ChillPersonBundle/Controller/SocialWorkSocialActionApiController.php

@@ -28,7 +28,7 @@ final class SocialWorkSocialActionApiController extends ApiController
         private readonly ClockInterface $clock,
     ) {}
 
-    public function listBySocialIssueApi($id, Request $request)
+    public function listBySocialIssueApi($id, Request $request): \Symfony\Component\HttpFoundation\JsonResponse
     {
         $socialIssue = $this->socialIssueRepository
             ->find($id);

src/Bundle/ChillPersonBundle/Controller/TimelinePersonController.php

@@ -25,7 +25,7 @@ class TimelinePersonController extends AbstractController
     public function __construct(protected EventDispatcherInterface $eventDispatcher, protected TimelineBuilder $timelineBuilder, protected PaginatorFactory $paginatorFactory, private readonly \Doctrine\Persistence\ManagerRegistry $managerRegistry) {}
 
     #[\Symfony\Component\Routing\Annotation\Route(path: '/{_locale}/person/{person_id}/timeline', name: 'chill_person_timeline')]
-    public function personAction(Request $request, mixed $person_id)
+    public function personAction(Request $request, mixed $person_id): \Symfony\Component\HttpFoundation\Response
     {
         $person = $this->managerRegistry
             ->getRepository(Person::class)