Rector changes and immplementations of required methods

src/Bundle/ChillActivityBundle/Tests/Controller/ActivityControllerTest.php

@@ -75,7 +75,7 @@ final class ActivityControllerTest extends WebTestCase
     /**
      * @dataProvider getSecuredPagesUnauthenticated
      */
-    public function testAccessIsDeniedForUnauthenticated(mixed $url)
+    public function testAccessIsDeniedForUnauthenticated(mixed $url): void
     {
         $client = $this->createClient();
 
@@ -94,14 +94,14 @@ final class ActivityControllerTest extends WebTestCase
      * @param type $client
      * @param type $url
      */
-    public function testAccessIsDeniedForUnauthorized($client, $url)
+    public function testAccessIsDeniedForUnauthorized($client, $url): void
     {
         $client->request('GET', $url);
 
         $this->assertEquals(403, $client->getResponse()->getStatusCode());
     }
 
-    public function testCompleteScenario()
+    public function testCompleteScenario(): void
     {
         // Create a new client to browse the application
         $client = $this->getAuthenticatedClient();
@@ -199,7 +199,7 @@ final class ActivityControllerTest extends WebTestCase
      *
      * @return \Chill\MainBundle\Entity\User a fake user within a group without activity
      */
-    private function createFakeUser()
+    private function createFakeUser(): \Chill\MainBundle\Entity\User
     {
         $container = self::$kernel->getContainer();
         $em = $container->get('doctrine.orm.entity_manager');
@@ -259,7 +259,7 @@ final class ActivityControllerTest extends WebTestCase
     /**
      * @return \Symfony\Component\BrowserKit\AbstractBrowser
      */
-    private function getAuthenticatedClient(mixed $username = 'center a_social')
+    private function getAuthenticatedClient(mixed $username = 'center a_social'): \Symfony\Bundle\FrameworkBundle\KernelBrowser
     {
         return self::createClient([], [
             'PHP_AUTH_USER' => $username,

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ACPAggregators/ByActivityTypeAggregatorTest.php

@@ -41,7 +41,7 @@ class ByActivityTypeAggregatorTest extends AbstractAggregatorTest
         $this->translatableStringHelper = self::getContainer()->get(TranslatableStringHelperInterface::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ACPAggregators\ByActivityTypeAggregator
     {
         return new ByActivityTypeAggregator(
             $this->rollingDateConverter,

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ACPAggregators/BySocialActionAggregatorTest.php

@@ -32,7 +32,7 @@ final class BySocialActionAggregatorTest extends AbstractAggregatorTest
         $this->aggregator = self::getContainer()->get('chill.activity.export.bysocialaction_aggregator');
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ACPAggregators\BySocialActionAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ACPAggregators/BySocialIssueAggregatorTest.php

@@ -32,7 +32,7 @@ final class BySocialIssueAggregatorTest extends AbstractAggregatorTest
         $this->aggregator = self::getContainer()->get('chill.activity.export.bysocialissue_aggregator');
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ACPAggregators\BySocialIssueAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ActivityPresenceAggregatorTest.php

@@ -35,7 +35,7 @@ class ActivityPresenceAggregatorTest extends AbstractAggregatorTest
         $this->activityPresenceRepository = self::getContainer()->get(ActivityPresenceRepositoryInterface::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ActivityPresenceAggregator
     {
         return new ActivityPresenceAggregator($this->activityPresenceRepository, $this->translatableStringHelper);
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ActivityReasonAggregatorTest.php

@@ -44,7 +44,7 @@ final class ActivityReasonAggregatorTest extends AbstractAggregatorTest
                     ->push($request->reveal());*/
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ActivityReasonAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ActivityTypeAggregatorTest.php

@@ -45,7 +45,7 @@ final class ActivityTypeAggregatorTest extends AbstractAggregatorTest
             ->push($request->reveal());
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ActivityTypeAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ActivityUserAggregatorTest.php

@@ -45,7 +45,7 @@ final class ActivityUserAggregatorTest extends AbstractAggregatorTest
             ->push($request->reveal());
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ActivityUserAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ByThirdpartyAggregatorTest.php

@@ -32,7 +32,7 @@ final class ByThirdpartyAggregatorTest extends AbstractAggregatorTest
         $this->aggregator = self::getContainer()->get(ByThirdpartyAggregator::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ByThirdpartyAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/ByUserAggregatorTest.php

@@ -32,7 +32,7 @@ final class ByUserAggregatorTest extends AbstractAggregatorTest
         $this->aggregator = self::getContainer()->get(ByCreatorAggregator::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\ByCreatorAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/CreatorJobAggregatorTest.php

@@ -32,7 +32,7 @@ final class CreatorJobAggregatorTest extends AbstractAggregatorTest
         $this->aggregator = self::getContainer()->get(CreatorJobAggregator::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\CreatorJobAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/CreatorScopeAggregatorTest.php

@@ -32,7 +32,7 @@ final class CreatorScopeAggregatorTest extends AbstractAggregatorTest
         $this->aggregator = self::getContainer()->get(CreatorScopeAggregator::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\CreatorScopeAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/DateAggregatorTest.php

@@ -32,7 +32,7 @@ final class DateAggregatorTest extends AbstractAggregatorTest
         $this->aggregator = self::getContainer()->get(DateAggregator::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\DateAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/LocationTypeAggregatorTest.php

@@ -32,7 +32,7 @@ final class LocationTypeAggregatorTest extends AbstractAggregatorTest
         $this->aggregator = self::getContainer()->get(LocationTypeAggregator::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\LocationTypeAggregator
     {
         return $this->aggregator;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/PersonAggregators/PersonAggregatorTest.php

@@ -32,7 +32,7 @@ class PersonAggregatorTest extends AbstractAggregatorTest
         $this->labelPersonHelper = self::getContainer()->get(LabelPersonHelper::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\PersonAggregators\PersonAggregator
     {
         return new PersonAggregator($this->labelPersonHelper);
     }

src/Bundle/ChillActivityBundle/Tests/Export/Aggregator/PersonsAggregatorTest.php

@@ -33,7 +33,7 @@ class PersonsAggregatorTest extends AbstractAggregatorTest
         $this->labelPersonHelper = self::getContainer()->get(LabelPersonHelper::class);
     }
 
-    public function getAggregator()
+    public function getAggregator(): \Chill\ActivityBundle\Export\Aggregator\PersonsAggregator
     {
         return new PersonsAggregator($this->labelPersonHelper);
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ACPFilters/ActivityTypeFilterTest.php

@@ -36,7 +36,7 @@ final class ActivityTypeFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(\Chill\ActivityBundle\Export\Filter\ACPFilters\ActivityTypeFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\ACPFilters\ActivityTypeFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ACPFilters/ByCreatorFilterTest.php

@@ -33,7 +33,7 @@ final class ByCreatorFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(ByCreatorFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\ByCreatorFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ACPFilters/BySocialActionFilterTest.php

@@ -33,7 +33,7 @@ final class BySocialActionFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(\Chill\ActivityBundle\Export\Filter\ACPFilters\BySocialActionFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\ACPFilters\BySocialActionFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ACPFilters/BySocialIssueFilterTest.php

@@ -34,7 +34,7 @@ final class BySocialIssueFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(BySocialIssueFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\ACPFilters\BySocialIssueFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ActivityDateFilterTest.php

@@ -33,7 +33,7 @@ final class ActivityDateFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(ActivityDateFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\ActivityDateFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ActivityPresenceFilterTest.php

@@ -39,7 +39,7 @@ class ActivityPresenceFilterTest extends AbstractFilterTest
         $this->translatableStringHelper = self::getContainer()->get(TranslatableStringHelperInterface::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\ActivityPresenceFilter
     {
         return new ActivityPresenceFilter($this->translatableStringHelper, $this->translator);
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ActivityReasonFilterTest.php

@@ -44,7 +44,7 @@ final class ActivityReasonFilterTest extends AbstractFilterTest
             ->push($request->reveal());
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\PersonFilters\ActivityReasonFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ActivityTypeFilterTest.php

@@ -34,7 +34,7 @@ final class ActivityTypeFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get('chill.activity.export.type_filter');
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\ActivityTypeFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/ByCreatorFilterTest.php

@@ -33,7 +33,7 @@ final class ByCreatorFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(ByCreatorFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\ByCreatorFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/CreatorJobFilterTest.php

@@ -42,7 +42,7 @@ class CreatorJobFilterTest extends AbstractFilterTest
         $this->userJobRepository = self::getContainer()->get(UserJobRepositoryInterface::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\CreatorJobFilter
     {
         return new CreatorJobFilter(
             $this->translatableStringHelper,

src/Bundle/ChillActivityBundle/Tests/Export/Filter/CreatorScopeFilterTest.php

@@ -33,7 +33,7 @@ final class CreatorScopeFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(CreatorScopeFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\CreatorScopeFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/EmergencyFilterTest.php

@@ -32,7 +32,7 @@ final class EmergencyFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(EmergencyFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\EmergencyFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/LocationTypeFilterTest.php

@@ -33,7 +33,7 @@ final class LocationTypeFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(LocationTypeFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\LocationTypeFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/PersonFilters/ActivityReasonFilterTest.php

@@ -34,7 +34,7 @@ final class ActivityReasonFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get('chill.activity.export.reason_filter');
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\PersonFilters\ActivityReasonFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/PersonFilters/PersonHavingActivityBetweenDateFilterTest.php

@@ -33,7 +33,7 @@ final class PersonHavingActivityBetweenDateFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get('chill.activity.export.person_having_an_activity_between_date_filter');
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\PersonFilters\PersonHavingActivityBetweenDateFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/PersonHavingActivityBetweenDateFilterTest.php

@@ -43,7 +43,7 @@ final class PersonHavingActivityBetweenDateFilterTest extends AbstractFilterTest
             ->push($request->reveal());
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\PersonFilters\PersonHavingActivityBetweenDateFilter
     {
         return $this->filter;
     }
@@ -90,7 +90,7 @@ final class PersonHavingActivityBetweenDateFilterTest extends AbstractFilterTest
      *
      * @return \Chill\ActivityBundle\Entity\ActivityReason[]
      */
-    private function getActivityReasons()
+    private function getActivityReasons(): array
     {
         self::bootKernel();
 

src/Bundle/ChillActivityBundle/Tests/Export/Filter/PersonsFilterTest.php

@@ -34,7 +34,7 @@ class PersonsFilterTest extends AbstractFilterTest
         $this->personRender = self::getContainer()->get(PersonRenderInterface::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\PersonsFilter
     {
         return new PersonsFilter($this->personRender);
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/SentReceivedFilterTest.php

@@ -32,7 +32,7 @@ final class SentReceivedFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(SentReceivedFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\SentReceivedFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Export/Filter/UserFilterTest.php

@@ -33,7 +33,7 @@ final class UserFilterTest extends AbstractFilterTest
         $this->filter = self::getContainer()->get(UserFilter::class);
     }
 
-    public function getFilter()
+    public function getFilter(): \Chill\ActivityBundle\Export\Filter\UserFilter
     {
         return $this->filter;
     }

src/Bundle/ChillActivityBundle/Tests/Form/ActivityTypeTest.php

@@ -74,7 +74,7 @@ final class ActivityTypeTest extends KernelTestCase
             ->setToken($token->reveal());
     }
 
-    public function testForm()
+    public function testForm(): void
     {
         $form = $this->formBuilder
             ->add('activity', ActivityType::class, [
@@ -90,7 +90,7 @@ final class ActivityTypeTest extends KernelTestCase
         $this->assertInstanceOf(Activity::class, $form->getData()['activity']);
     }
 
-    public function testFormSubmitting()
+    public function testFormSubmitting(): void
     {
         $form = $this->formBuilder
             ->add('activity', ActivityType::class, [
@@ -136,7 +136,7 @@ final class ActivityTypeTest extends KernelTestCase
      * Test that the form correctly build even with a durationTime which is not in
      * the listed in the possible durationTime.
      */
-    public function testFormWithActivityHavingDifferentTime()
+    public function testFormWithActivityHavingDifferentTime(): void
     {
         $activity = new Activity();
         $activity->setDurationTime(\DateTime::createFromFormat('U', 60));

src/Bundle/ChillActivityBundle/Tests/Form/Type/TranslatableActivityReasonTest.php

@@ -50,7 +50,7 @@ final class TranslatableActivityReasonTest extends TypeTestCase
     /**
      * @return \Symfony\Bridge\Doctrine\Form\Type\EntityType
      */
-    protected function getEntityType()
+    protected function getEntityType(): \Symfony\Bridge\Doctrine\Form\Type\EntityType
     {
         $managerRegistry = (new \Prophecy\Prophet())->prophesize();
 
@@ -77,7 +77,7 @@ final class TranslatableActivityReasonTest extends TypeTestCase
     protected function getTranslatableStringHelper(
         $locale = 'en',
         $fallbackLocale = 'en',
-    ) {
+    ): \Chill\MainBundle\Templating\TranslatableStringHelper {
         $prophet = new \Prophecy\Prophet();
         $requestStack = $prophet->prophesize();
         $request = $prophet->prophesize();

src/Bundle/ChillActivityBundle/Tests/Form/Type/TranslatableActivityTypeTest.php

@@ -46,7 +46,7 @@ final class TranslatableActivityTypeTest extends KernelTestCase
             ->push($request);
     }
 
-    public function testForm()
+    public function testForm(): void
     {
         $type = $this->getRandomType();
         $form = $this->builder->add('type', TranslatableActivityType::class)

src/Bundle/ChillActivityBundle/Tests/Security/Authorization/ActivityVoterTest.php

@@ -110,7 +110,7 @@ final class ActivityVoterTest extends KernelTestCase
         ];
     }
 
-    public function testNullUser()
+    public function testNullUser(): void
     {
         $token = $this->prepareToken();
         $center = $this->prepareCenter(1, 'center');
@@ -139,7 +139,7 @@ final class ActivityVoterTest extends KernelTestCase
         Center $center,
         $attribute,
         $message,
-    ) {
+    ): void {
         $token = $this->prepareToken($user);
         $activity = $this->prepareActivity($scope, $this->preparePerson($center));