Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-12 21:34:25 +00:00
Code Issues Actions Projects Releases Wiki Activity

Correct 2 phpstan errors, condition is always true and wrong typing

Browse Source
This commit is contained in:
Julie Lenaerts 2024-02-12 14:50:26 +01:00
parent 82667a1c0f
commit 087032881b
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Bundle/ChillMainBundle/Templating/Entity/UserRender.php
View File

@ -65,7 +65,7 @@ class UserRender implements ChillEntityRenderInterface
} }
/** /**
* @param array{main_scope?: bool, user_job?: bool, absence?: bool, at_date?: DateTimeImmutable|DateTimeMutable|null} $options * @param array{main_scope?: bool, user_job?: bool, absence?: bool, at_date?: DateTimeImmutable|DateTime|null} $options
*/ */
public function renderString($entity, array $options): string public function renderString($entity, array $options): string
{ {

21
src/Bundle/ChillPersonBundle/Serializer/Normalizer/AccompanyingPeriodWorkNormalizer.php
View File

@ -57,20 +57,19 @@ class AccompanyingPeriodWorkNormalizer implements ContextAwareNormalizerInterfac
// add the referrers // add the referrers
$initial['referrers'] = []; $initial['referrers'] = [];
if ($object instanceof AccompanyingPeriodWork) { foreach ($object->getReferrersHistory() as $referrerHistory) {
foreach ($object->getReferrersHistory() as $referrerHistory) { if (null !== $referrerHistory->getEndDate()) {
if (null !== $referrerHistory->getEndDate()) { continue;
continue;
}
$initial['referrers'][] = $this->normalizer->normalize(
$referrerHistory->getUser(),
$format,
[...$context, UserNormalizer::AT_DATE => $referrerHistory->getStartDate()]
);
} }
$initial['referrers'][] = $this->normalizer->normalize(
$referrerHistory->getUser(),
$format,
[...$context, UserNormalizer::AT_DATE => $referrerHistory->getStartDate()]
);
} }
if ('json' === $format) { if ('json' === $format) {
// then, we add normalization for things which are not into the entity // then, we add normalization for things which are not into the entity
$initial['workflows_availables'] = $this->metadataExtractor->availableWorkflowFor( $initial['workflows_availables'] = $this->metadataExtractor->availableWorkflowFor(