From 1585a739747c8575103169c66ccf3ec3a2148238 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Tue, 22 Nov 2022 11:12:44 +0100
Subject: [PATCH 1/5] DX: [authorization helper] Create an authorization helper
 with current user already available

See https://gitlab.com/Chill-Projet/chill-bundles/-/issues/14
---
 .../AuthorizationHelperForCurrentUser.php     | 46 +++++++++++++++++++
 ...orizationHelperForCurrentUserInterface.php | 28 +++++++++++
 2 files changed, 74 insertions(+)
 create mode 100644 src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelperForCurrentUser.php
 create mode 100644 src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelperForCurrentUserInterface.php

diff --git a/src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelperForCurrentUser.php b/src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelperForCurrentUser.php
new file mode 100644
index 000000000..da9c285bd
--- /dev/null
+++ b/src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelperForCurrentUser.php
@@ -0,0 +1,46 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\MainBundle\Security\Authorization;
+
+use Chill\MainBundle\Entity\User;
+use Symfony\Component\Security\Core\Security;
+
+class AuthorizationHelperForCurrentUser implements AuthorizationHelperForCurrentUserInterface
+{
+    private AuthorizationHelperInterface $authorizationHelper;
+
+    private Security $security;
+
+    public function __construct(AuthorizationHelperInterface $authorizationHelper, Security $security)
+    {
+        $this->authorizationHelper = $authorizationHelper;
+        $this->security = $security;
+    }
+
+    public function getReachableCenters(string $role, ?Scope $scope = null): array
+    {
+        if (!$this->security->getUser() instanceof User) {
+            return [];
+        }
+
+        return $this->authorizationHelper->getReachableCenters($this->security->getUser(), $role, $scope);
+    }
+
+    public function getReachableScopes(string $role, $center): array
+    {
+        if (!$this->security->getUser() instanceof User) {
+            return [];
+        }
+
+        return $this->authorizationHelper->getReachableScopes($this->security->getUser(), $role, $center);
+    }
+}
diff --git a/src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelperForCurrentUserInterface.php b/src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelperForCurrentUserInterface.php
new file mode 100644
index 000000000..cd3459aa9
--- /dev/null
+++ b/src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelperForCurrentUserInterface.php
@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\MainBundle\Security\Authorization;
+
+interface AuthorizationHelperForCurrentUserInterface
+{
+    /**
+     * Get reachable Centers for the given user, role,
+     * and optionnaly Scope.
+     *
+     * @return Center[]
+     */
+    public function getReachableCenters(string $role, ?Scope $scope = null): array;
+
+    /**
+     * @param array|Center|Center[] $center
+     */
+    public function getReachableScopes(string $role, $center): array;
+}

From b06a76784a947f15ff7ed6754a93aea2bf30583d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Tue, 22 Nov 2022 11:18:33 +0100
Subject: [PATCH 2/5] Feature: [person][creation] api for listing availables
 centers for person creation

---
 .../config/services/security.yaml             |  5 +++
 .../Controller/PersonApiController.php        | 32 +++++++++++++---
 .../AuthorizedCenterOnPersonCreation.php      | 38 +++++++++++++++++++
 ...horizedCenterOnPersonCreationInterface.php | 22 +++++++++++
 .../ChillPersonBundle/chill.api.specs.yaml    | 12 +++++-
 .../config/services/controller.yaml           |  5 +--
 .../config/services/security.yaml             |  6 +++
 7 files changed, 111 insertions(+), 9 deletions(-)
 create mode 100644 src/Bundle/ChillPersonBundle/Security/AuthorizedCenterOnPersonCreation.php
 create mode 100644 src/Bundle/ChillPersonBundle/Security/AuthorizedCenterOnPersonCreationInterface.php

diff --git a/src/Bundle/ChillMainBundle/config/services/security.yaml b/src/Bundle/ChillMainBundle/config/services/security.yaml
index 824144470..c0d9f98b9 100644
--- a/src/Bundle/ChillMainBundle/config/services/security.yaml
+++ b/src/Bundle/ChillMainBundle/config/services/security.yaml
@@ -3,6 +3,11 @@ services:
         autowire: true
         autoconfigure: true
 
+    Chill\MainBundle\Security\:
+        autoconfigure: true
+        autowire: true
+        resource: '../../Security'
+
     Chill\MainBundle\Security\Resolver\CenterResolverDispatcher:
         arguments:
             - !tagged_iterator chill_main.center_resolver
diff --git a/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php b/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
index 745a64240..bf0d998ff 100644
--- a/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
@@ -13,12 +13,13 @@ namespace Chill\PersonBundle\Controller;
 
 use Chill\MainBundle\CRUD\Controller\ApiController;
 use Chill\MainBundle\Entity\Address;
-use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
 use Chill\PersonBundle\Config\ConfigPersonAltNamesHelper;
 use Chill\PersonBundle\Entity\AccompanyingPeriodParticipation;
 use Chill\PersonBundle\Entity\Person;
 use Chill\PersonBundle\Security\Authorization\PersonVoter;
+use Chill\PersonBundle\Security\AuthorizedCenterOnPersonCreationInterface;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
+use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
@@ -26,16 +27,37 @@ use function in_array;
 
 class PersonApiController extends ApiController
 {
-    private AuthorizationHelper $authorizationHelper;
+    private AuthorizedCenterOnPersonCreationInterface $authorizedCenterOnPersonCreation;
 
     private ConfigPersonAltNamesHelper $configPersonAltNameHelper;
 
+    private bool $showCenters;
+
     public function __construct(
-        AuthorizationHelper $authorizationHelper,
-        ConfigPersonAltNamesHelper $configPersonAltNameHelper
+        AuthorizedCenterOnPersonCreationInterface $authorizedCenterOnPersonCreation,
+        ConfigPersonAltNamesHelper $configPersonAltNameHelper,
+        ParameterBagInterface $parameterBag
     ) {
-        $this->authorizationHelper = $authorizationHelper;
+        $this->authorizedCenterOnPersonCreation = $authorizedCenterOnPersonCreation;
         $this->configPersonAltNameHelper = $configPersonAltNameHelper;
+        $this->showCenters = $parameterBag->get('chill_main')['acl']['form_show_centers'];
+    }
+
+    /**
+     * @Route("/api/1.0/person/creation/authorized-centers",
+     *     name="chill_person_person_creation_authorized_centers"
+     * )
+     */
+    public function authorizedCentersForCreation(): Response
+    {
+        $centers = $this->authorizedCenterOnPersonCreation->getCenters();
+
+        return $this->json(
+            ['showCenters' => $this->showCenters, 'centers' => $centers],
+            Response::HTTP_OK,
+            [],
+            ['gropus' => ['read']]
+        );
     }
 
     /**
diff --git a/src/Bundle/ChillPersonBundle/Security/AuthorizedCenterOnPersonCreation.php b/src/Bundle/ChillPersonBundle/Security/AuthorizedCenterOnPersonCreation.php
new file mode 100644
index 000000000..6f8800d65
--- /dev/null
+++ b/src/Bundle/ChillPersonBundle/Security/AuthorizedCenterOnPersonCreation.php
@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\PersonBundle\Security;
+
+use Chill\MainBundle\Security\Authorization\AuthorizationHelperForCurrentUserInterface;
+use Chill\PersonBundle\Security\Authorization\PersonVoter;
+use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
+
+class AuthorizedCenterOnPersonCreation implements AuthorizedCenterOnPersonCreationInterface
+{
+    private AuthorizationHelperForCurrentUserInterface $authorizationHelperForCurrentUser;
+
+    private bool $showCenters;
+
+    public function __construct(AuthorizationHelperForCurrentUserInterface $authorizationHelperForCurrentUser, ParameterBagInterface $parameterBag)
+    {
+        $this->authorizationHelperForCurrentUser = $authorizationHelperForCurrentUser;
+        $this->showCenter = $parameterBag->get('chill_main')['acl']['form_show_centers'];
+    }
+
+    public function getCenters(): array
+    {
+        if (!$this->showCenter) {
+            return [];
+        }
+
+        return $this->authorizationHelperForCurrentUser->getReachableCenters(PersonVoter::CREATE);
+    }
+}
diff --git a/src/Bundle/ChillPersonBundle/Security/AuthorizedCenterOnPersonCreationInterface.php b/src/Bundle/ChillPersonBundle/Security/AuthorizedCenterOnPersonCreationInterface.php
new file mode 100644
index 000000000..d0748b8c2
--- /dev/null
+++ b/src/Bundle/ChillPersonBundle/Security/AuthorizedCenterOnPersonCreationInterface.php
@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\PersonBundle\Security;
+
+use Chill\MainBundle\Entity\Center;
+
+interface AuthorizedCenterOnPersonCreationInterface
+{
+    /**
+     * @return array|Center[]
+     */
+    public function getCenters(): array;
+}
diff --git a/src/Bundle/ChillPersonBundle/chill.api.specs.yaml b/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
index 76041fe84..72a4b78e3 100644
--- a/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
+++ b/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
@@ -1937,4 +1937,14 @@ paths:
       summary: Return a list of possible altNames that are defined in the config
       responses:
         200:
-          description: "OK"
\ No newline at end of file
+          description: "OK"
+
+  /1.0/person/creation/authorized-centers:
+    get:
+      tags:
+        - person
+        - permissions
+      summary: Return a list of possible centers for person creation
+      responses:
+        200:
+          description: "OK"
diff --git a/src/Bundle/ChillPersonBundle/config/services/controller.yaml b/src/Bundle/ChillPersonBundle/config/services/controller.yaml
index 67c724093..4ef0cb15f 100644
--- a/src/Bundle/ChillPersonBundle/config/services/controller.yaml
+++ b/src/Bundle/ChillPersonBundle/config/services/controller.yaml
@@ -47,9 +47,8 @@ services:
         tags: ['controller.service_arguments']
 
     Chill\PersonBundle\Controller\PersonApiController:
-        arguments:
-            $authorizationHelper: '@Chill\MainBundle\Security\Authorization\AuthorizationHelper'
-            $configPersonAltNameHelper: '@Chill\PersonBundle\Config\ConfigPersonAltNamesHelper'
+        autoconfigure: true
+        autowire: true
         tags: ['controller.service_arguments']
 
     Chill\PersonBundle\Controller\AccompanyingCourseWorkApiController:
diff --git a/src/Bundle/ChillPersonBundle/config/services/security.yaml b/src/Bundle/ChillPersonBundle/config/services/security.yaml
index af81b42e2..4cdc16e74 100644
--- a/src/Bundle/ChillPersonBundle/config/services/security.yaml
+++ b/src/Bundle/ChillPersonBundle/config/services/security.yaml
@@ -1,4 +1,10 @@
 services:
+
+    Chill\PersonBundle\Security\:
+        autoconfigure: true
+        autowire: true
+        resource: '../../Security'
+
     chill.person.security.authorization.person:
         autowire: true
         autoconfigure: true

From 1f58acd871412452dde912d455dc25d11e8ca1ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Tue, 22 Nov 2022 22:28:18 +0100
Subject: [PATCH 3/5] Feature: [person][creation] Add center field to
 OnTheFly/Person

---
 .../ChillPersonBundle/Entity/Person.php       |  8 ++-
 .../vuejs/HouseholdMembersEditor/index.js     |  8 +++
 .../Resources/public/vuejs/_api/OnTheFly.js   |  5 ++
 .../vuejs/_components/OnTheFly/Person.vue     | 54 ++++++++++++++++---
 .../Resources/public/vuejs/_js/i18n.js        |  4 ++
 5 files changed, 71 insertions(+), 8 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Entity/Person.php b/src/Bundle/ChillPersonBundle/Entity/Person.php
index a477f9adb..3843a960f 100644
--- a/src/Bundle/ChillPersonBundle/Entity/Person.php
+++ b/src/Bundle/ChillPersonBundle/Entity/Person.php
@@ -1567,7 +1567,7 @@ class Person implements HasCenterInterface, TrackCreationInterface, TrackUpdateI
      *
      * @return $this
      */
-    public function setCenter(Center $center): self
+    public function setCenter(?Center $center): self
     {
         $modification = new DateTimeImmutable('now');
 
@@ -1577,7 +1577,11 @@ class Person implements HasCenterInterface, TrackCreationInterface, TrackUpdateI
             }
         }
 
-        $this->centerHistory[] = $new = new PersonCenterHistory($this, $center, $modification);
+        if (null === $center) {
+            return $this;
+        }
+
+        $this->centerHistory[] =  new PersonCenterHistory($this, $center, $modification);
 
         return $this;
     }
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/HouseholdMembersEditor/index.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/HouseholdMembersEditor/index.js
index c9f5bb111..d2b271e17 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/HouseholdMembersEditor/index.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/HouseholdMembersEditor/index.js
@@ -2,6 +2,8 @@ import { createApp } from 'vue';
 import { _createI18n } from 'ChillMainAssets/vuejs/_js/i18n';
 import { appMessages } from './js/i18n';
 import { store } from './store';
+import VueToast from 'vue-toast-notification';
+import 'vue-toast-notification/dist/theme-sugar.css';
 
 import App from './App.vue';
 
@@ -12,5 +14,11 @@ const app = createApp({
 })
 .use(store)
 .use(i18n)
+.use(VueToast, {
+ position: "bottom-right",
+ type: "error",
+ duration: 5000,
+ dismissible: true
+})
 .component('app', App)
 .mount('#household_members_editor');
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js
index 338094122..c9c77991f 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js
@@ -1,3 +1,5 @@
+import {makeFetch} from 'ChillMainAssets/lib/api/apiMethods';
+
 /*
 * GET a person by id
 */
@@ -22,6 +24,8 @@ const getCivilities = () =>
       throw Error('Error with request resource response');
    });
 
+const getCentersForPersonCreation = () => makeFetch('GET', '/api/1.0/person/creation/authorized-centers', null);
+
 /*
 * POST a new person
 */
@@ -59,6 +63,7 @@ const patchPerson = (id, body) => {
 };
 
 export {
+    getCentersForPersonCreation,
    getPerson,
    getPersonAltNames,
    getCivilities,
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
index 4f8909233..8694da651 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
@@ -87,6 +87,18 @@
       <label>{{ $t('person.gender.title') }}</label>
    </div>
 
+  <div class="form-floating mb-3" v-if="showCenters && config.centers.length > 1">
+    <select
+         class="form-select form-select-lg"
+         id="center"
+         v-model="center"
+         >
+         <option selected disabled>{{ $t('person.center.placeholder') }}</option>
+         <option v-for="c in config.centers" :value="c" :key="c.id" >{{ c.name }}</option>
+    </select>
+    <label>{{ $t('person.center.title') }}</label>
+  </div>
+
    <div class="form-floating mb-3">
       <select
          class="form-select form-select-lg"
@@ -166,7 +178,7 @@
 </template>
 
 <script>
-import { getCivilities, getPerson, getPersonAltNames } from '../../_api/OnTheFly';
+import { getCentersForPersonCreation, getCivilities, getPerson, getPersonAltNames } from '../../_api/OnTheFly';
 import PersonRenderBox from '../Entity/PersonRenderBox.vue';
 import AddAddress from "ChillMainAssets/vuejs/Address/components/AddAddress.vue";
 
@@ -182,13 +194,18 @@ export default {
       return {
          person: {
             type: 'person',
+            lastName: '',
+            firstName: '',
             altNames: [],
-            addressId: null
+            addressId: null,
+            center: null,
          },
          config: {
             altNames: [],
-            civilities: []
+            civilities: [],
+            centers: [],
          },
+         showCenters: false, // NOTE: must remains false if the form is not in create mode
          showAddressFormValue: false,
          addAddress: {
             options: {
@@ -254,6 +271,19 @@ export default {
          set(value) { this.showAddressFormValue = value; },
          get() { return this.showAddressFormValue; }
       },
+      center: {
+         set(value) {
+           console.log('will set center', value);
+           this.person.center = {id: value.id, type: value.type};
+         },
+         get() {
+           const center = this.config.centers.find(c => this.person.center !== null && this.person.center.id === c.id);
+
+           console.log('center get', center);
+
+           return typeof center === 'undefined' ? null : center;
+         },
+      },
       genderClass() {
          switch (this.person.gender) {
             case 'woman':
@@ -295,23 +325,35 @@ export default {
                this.config.civilities = civilities.results;
             }
          });
-
       if (this.action !== 'create') {
          this.loadData();
+      } else {
+        getCentersForPersonCreation()
+            .then(params => {
+              this.config.centers = params.centers;
+              this.showCenters = params.showCenters;
+
+              if (this.showCenters && this.config.centers.length === 1) {
+                this.person.center = this.config.centers[0];
+              }
+            });
       }
    },
    methods: {
       checkErrors(e) {
          this.errors = [];
-         if (!this.person.lastName) {
+         if (this.person.lastName === "") {
             this.errors.push("Le nom ne doit pas être vide.");
          }
-         if (!this.person.firstName) {
+         if (this.person.firstName === "") {
             this.errors.push("Le prénom ne doit pas être vide.");
          }
          if (!this.person.gender) {
             this.errors.push("Le genre doit être renseigné");
          }
+         if (this.showCenters && this.person.center === null) {
+           this.errors.push("Le centre doit être renseigné");
+         }
       },
       loadData() {
          getPerson(this.id)
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_js/i18n.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_js/i18n.js
index d7ac10676..721ac8d0e 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_js/i18n.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_js/i18n.js
@@ -47,6 +47,10 @@ const personMessages = {
             create_address: "Ajouter une adresse",
             show_address_form: "Ajouter une adresse pour un usager non suivi et seul dans un ménage",
             warning: "Un nouveau ménage va être créé. L'usager sera membre de ce ménage."
+         },
+         center: {
+            placeholder: "Choisissez un centre",
+            title: "Centre",
          }
       },
       error_only_one_person: "Une seule personne peut être sélectionnée !"

From 64e65d08feefba7f265d975bb6d0126c440ac0a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Thu, 1 Dec 2022 17:58:59 +0100
Subject: [PATCH 4/5] Fix: [center denormalizer] do not throw an error if
 deserializing a null center

---
 .../Serializer/Normalizer/CenterNormalizer.php                | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/Bundle/ChillMainBundle/Serializer/Normalizer/CenterNormalizer.php b/src/Bundle/ChillMainBundle/Serializer/Normalizer/CenterNormalizer.php
index f65e7ebc8..e0b2a3e96 100644
--- a/src/Bundle/ChillMainBundle/Serializer/Normalizer/CenterNormalizer.php
+++ b/src/Bundle/ChillMainBundle/Serializer/Normalizer/CenterNormalizer.php
@@ -31,6 +31,10 @@ class CenterNormalizer implements DenormalizerInterface, NormalizerInterface
 
     public function denormalize($data, $type, $format = null, array $context = [])
     {
+        if (null === $data) {
+            return null;
+        }
+
         if (false === array_key_exists('type', $data)) {
             throw new InvalidArgumentException('missing "type" key in data');
         }

From fa237bf27b4811ab825d832fdb549ff420d528b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Thu, 1 Dec 2022 17:59:18 +0100
Subject: [PATCH 5/5] Fix: missing translation of validation of center

---
 src/Bundle/ChillPersonBundle/translations/validators.fr.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/Bundle/ChillPersonBundle/translations/validators.fr.yml b/src/Bundle/ChillPersonBundle/translations/validators.fr.yml
index c9c8d8648..496a84921 100644
--- a/src/Bundle/ChillPersonBundle/translations/validators.fr.yml
+++ b/src/Bundle/ChillPersonBundle/translations/validators.fr.yml
@@ -22,6 +22,8 @@ The lastname cannot be empty: Le nom de famille ne peut pas être vide
 The gender must be set: Le genre doit être renseigné
 You are not allowed to perform this action: Vous n'avez pas le droit de changer cette valeur.
 
+A center is required: Un centre est requis
+
 #export list
 You must select at least one element: Vous devez sélectionner au moins un élément