From f2eaf23c2a79c134c50e6817bd8facfcab43bae9 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Thu, 19 Sep 2024 14:37:05 +0200
Subject: [PATCH] Clean migration for activity bundle

---
 .../Entity/ActivityReason.php                 |  4 +--
 .../Entity/ActivityReasonCategory.php         |  8 ++---
 .../migrations/Version20240918142723.php      | 34 +++++++++++++++++++
 3 files changed, 39 insertions(+), 7 deletions(-)
 create mode 100644 src/Bundle/ChillActivityBundle/migrations/Version20240918142723.php

diff --git a/src/Bundle/ChillActivityBundle/Entity/ActivityReason.php b/src/Bundle/ChillActivityBundle/Entity/ActivityReason.php
index bf36ead6c..f6bdac24e 100644
--- a/src/Bundle/ChillActivityBundle/Entity/ActivityReason.php
+++ b/src/Bundle/ChillActivityBundle/Entity/ActivityReason.php
@@ -32,8 +32,8 @@ class ActivityReason
     #[ORM\GeneratedValue(strategy: 'AUTO')]
     private ?int $id = null;
 
-    #[ORM\Column(type: \Doctrine\DBAL\Types\Types::JSON)]
-    private array $name;
+    #[ORM\Column(type: \Doctrine\DBAL\Types\Types::JSON, options: ['default' => '{}', 'jsonb' => true])]
+    private array $name = [];
 
     /**
      * Get active.
diff --git a/src/Bundle/ChillActivityBundle/Entity/ActivityReasonCategory.php b/src/Bundle/ChillActivityBundle/Entity/ActivityReasonCategory.php
index b31bb8731..3555cd8fc 100644
--- a/src/Bundle/ChillActivityBundle/Entity/ActivityReasonCategory.php
+++ b/src/Bundle/ChillActivityBundle/Entity/ActivityReasonCategory.php
@@ -31,11 +31,9 @@ class ActivityReasonCategory implements \Stringable
     #[ORM\GeneratedValue(strategy: 'AUTO')]
     private ?int $id = null;
 
-    /**
-     * @var string
-     */
-    #[ORM\Column(type: \Doctrine\DBAL\Types\Types::JSON)]
-    private $name;
+
+    #[ORM\Column(type: \Doctrine\DBAL\Types\Types::JSON, options: ['default' => '{}', 'jsonb' => true])]
+    private array $name = [];
 
     /**
      * Array of ActivityReason.
diff --git a/src/Bundle/ChillActivityBundle/migrations/Version20240918142723.php b/src/Bundle/ChillActivityBundle/migrations/Version20240918142723.php
new file mode 100644
index 000000000..d453a9bbc
--- /dev/null
+++ b/src/Bundle/ChillActivityBundle/migrations/Version20240918142723.php
@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Chill\Migrations\Activity;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+final class Version20240918142723 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return 'Fix not null and default values for activityreason, activityreasoncategory, comments on activity';
+    }
+
+    public function up(Schema $schema): void
+    {
+        $this->addSql('ALTER TABLE activity ALTER privatecomment_comments SET NOT NULL');
+        $this->addSql('ALTER TABLE activityreason ALTER name SET DEFAULT \'{}\'');
+        $this->addSql('ALTER TABLE activityreason ALTER name SET NOT NULL');
+        $this->addSql('ALTER INDEX idx_654a2fcd12469de2 RENAME TO IDX_AF82522312469DE2');
+        $this->addSql('ALTER TABLE activityreasoncategory ALTER name SET DEFAULT \'{}\'');
+        $this->addSql('ALTER TABLE activityreasoncategory ALTER name SET NOT NULL');
+    }
+
+    public function down(Schema $schema): void
+    {
+        $this->addSql('ALTER TABLE activityreason ALTER name DROP DEFAULT');
+        $this->addSql('ALTER TABLE activityreason ALTER name DROP NOT NULL');
+        $this->addSql('ALTER TABLE activityreasoncategory ALTER name DROP DEFAULT');
+        $this->addSql('ALTER TABLE activityreasoncategory ALTER name DROP NOT NULL');
+    }
+}