From e6163b2bc3a8e1d7bb4581586ab74321c5b1b37a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20Fastr=C3=A9?= Date: Wed, 19 Apr 2023 13:05:21 +0200 Subject: [PATCH] DX: fix cs --- .../DocGenerator/ListActivitiesByAccompanyingPeriodContext.php | 1 - .../Controller/AddressToReferenceMatcherController.php | 1 - src/Bundle/ChillMainBundle/Form/Type/ScopePickerType.php | 3 ++- src/Bundle/ChillMainBundle/Form/WorkflowStepType.php | 2 +- .../ChillMainBundle/migrations/Version20230306145728.php | 1 - src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php | 1 + 6 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Bundle/ChillActivityBundle/Service/DocGenerator/ListActivitiesByAccompanyingPeriodContext.php b/src/Bundle/ChillActivityBundle/Service/DocGenerator/ListActivitiesByAccompanyingPeriodContext.php index 266fadfee..b2272dd7b 100644 --- a/src/Bundle/ChillActivityBundle/Service/DocGenerator/ListActivitiesByAccompanyingPeriodContext.php +++ b/src/Bundle/ChillActivityBundle/Service/DocGenerator/ListActivitiesByAccompanyingPeriodContext.php @@ -120,7 +120,6 @@ class ListActivitiesByAccompanyingPeriodContext implements public function contextGenerationDataDenormalize(DocGeneratorTemplate $template, $entity, array $data): array { - $denormalized = $this->accompanyingPeriodContext->contextGenerationDataDenormalize($template, $entity, $data); foreach (['myActivitiesOnly', 'myWorksOnly'] as $k) { diff --git a/src/Bundle/ChillMainBundle/Controller/AddressToReferenceMatcherController.php b/src/Bundle/ChillMainBundle/Controller/AddressToReferenceMatcherController.php index 5cdefceb5..aab63aea3 100644 --- a/src/Bundle/ChillMainBundle/Controller/AddressToReferenceMatcherController.php +++ b/src/Bundle/ChillMainBundle/Controller/AddressToReferenceMatcherController.php @@ -107,5 +107,4 @@ class AddressToReferenceMatcherController true ); } - } diff --git a/src/Bundle/ChillMainBundle/Form/Type/ScopePickerType.php b/src/Bundle/ChillMainBundle/Form/Type/ScopePickerType.php index 6f1a5837f..2529a0655 100644 --- a/src/Bundle/ChillMainBundle/Form/Type/ScopePickerType.php +++ b/src/Bundle/ChillMainBundle/Form/Type/ScopePickerType.php @@ -70,7 +70,8 @@ class ScopePickerType extends AbstractType static function (Scope $s) { return $s->isActive(); } - )); + ) + ); if (0 === count($items)) { throw new RuntimeException('no scopes are reachable. This form should not be shown to user'); diff --git a/src/Bundle/ChillMainBundle/Form/WorkflowStepType.php b/src/Bundle/ChillMainBundle/Form/WorkflowStepType.php index 16dc0a4a5..54d953016 100644 --- a/src/Bundle/ChillMainBundle/Form/WorkflowStepType.php +++ b/src/Bundle/ChillMainBundle/Form/WorkflowStepType.php @@ -247,7 +247,7 @@ class WorkflowStepType extends AbstractType function ($step, ExecutionContextInterface $context, $payload) { $form = $context->getObject(); - foreach($form->get('future_dest_users')->getData() as $u) { + foreach ($form->get('future_dest_users')->getData() as $u) { if (in_array($u, $form->get('future_cc_users')->getData(), true)) { $context ->buildViolation('workflow.The user in cc cannot be a dest user in the same workflow step') diff --git a/src/Bundle/ChillMainBundle/migrations/Version20230306145728.php b/src/Bundle/ChillMainBundle/migrations/Version20230306145728.php index 09a0ece6e..32e138f54 100644 --- a/src/Bundle/ChillMainBundle/migrations/Version20230306145728.php +++ b/src/Bundle/ChillMainBundle/migrations/Version20230306145728.php @@ -69,7 +69,6 @@ final class Version20230306145728 extends AbstractMigration $this->addSql('CREATE INDEX IDX_165051F63174800F ON chill_main_address (createdBy_id)'); $this->addSql('CREATE INDEX IDX_165051F665FF1AEC ON chill_main_address (updatedBy_id)'); $this->addSql('COMMENT ON COLUMN chill_main_address_reference.point IS \'(DC2Type:point)\''); - } public function down(Schema $schema): void diff --git a/src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php b/src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php index 0cdcd7173..2ba9488b6 100644 --- a/src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php +++ b/src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php @@ -685,6 +685,7 @@ final class SingleTaskController extends AbstractController /** * Creates a form to delete a Task entity by id. + * @param mixed $id */ private function createDeleteForm($id): FormInterface {