From e35f002f2b3efbb61f26f847c4b38d332624a4fd Mon Sep 17 00:00:00 2001 From: Julie Lenaerts Date: Fri, 1 Oct 2021 19:05:03 +0200 Subject: [PATCH] improvements based on draft review of MR 153 --- .../Controller/AsideActivityController.php | 3 + .../ChillAsideActivityExtension.php | 2 +- .../src/Form/AsideActivityCategoryType.php | 8 +- .../src/Menu/SectionMenuBuilder.php | 1 - .../Admin/layout_asideactivity.html.twig | 2 +- .../views/asideActivity/_index.html.twig | 0 .../views/asideActivity/_view.html.twig | 4 +- .../views/asideActivity/index.html.twig | 93 +++++++++++++++- .../views/asideActivity/list.html.twig | 101 ------------------ .../src/migrations/Version20210706124644.php | 5 +- .../src/migrations/Version20210804082249.php | 5 +- .../src/migrations/Version20210806140343.php | 5 +- .../src/migrations/Version20210806140710.php | 5 +- .../src/migrations/Version20210810084456.php | 5 +- .../src/migrations/Version20210922182907.php | 5 +- .../src/translations/messages.fr.yml | 13 --- .../translations/messages.fr.yml | 88 ++++++++------- 17 files changed, 154 insertions(+), 191 deletions(-) delete mode 100644 src/Bundle/ChillAsideActivityBundle/src/Resources/views/asideActivity/_index.html.twig delete mode 100644 src/Bundle/ChillAsideActivityBundle/src/Resources/views/asideActivity/list.html.twig diff --git a/src/Bundle/ChillAsideActivityBundle/src/Controller/AsideActivityController.php b/src/Bundle/ChillAsideActivityBundle/src/Controller/AsideActivityController.php index 8984b79f4..a0362ec12 100644 --- a/src/Bundle/ChillAsideActivityBundle/src/Controller/AsideActivityController.php +++ b/src/Bundle/ChillAsideActivityBundle/src/Controller/AsideActivityController.php @@ -57,6 +57,9 @@ final class AsideActivityController extends CRUDController $asideActivity->setDuration($duration); $categoryId = $request->query->get('type', 7); + if($categoryId === null){ + return $this->createNotFoundException('You must give a valid category id'); + } $category = $this->categoryRepository->find($categoryId); $asideActivity->setType($category); diff --git a/src/Bundle/ChillAsideActivityBundle/src/DependencyInjection/ChillAsideActivityExtension.php b/src/Bundle/ChillAsideActivityBundle/src/DependencyInjection/ChillAsideActivityExtension.php index fa1353c71..59e77c3e9 100644 --- a/src/Bundle/ChillAsideActivityBundle/src/DependencyInjection/ChillAsideActivityExtension.php +++ b/src/Bundle/ChillAsideActivityBundle/src/DependencyInjection/ChillAsideActivityExtension.php @@ -87,7 +87,7 @@ final class ChillAsideActivityExtension extends Extension implements PrependExte 'controller' => \Chill\AsideActivityBundle\Controller\AsideActivityController::class, 'actions' => [ 'index' => [ - 'template' => '@ChillAsideActivity/asideActivity/list.html.twig', + 'template' => '@ChillAsideActivity/asideActivity/index.html.twig', 'role' => 'ROLE_USER' ], 'new' => [ diff --git a/src/Bundle/ChillAsideActivityBundle/src/Form/AsideActivityCategoryType.php b/src/Bundle/ChillAsideActivityBundle/src/Form/AsideActivityCategoryType.php index c7357b603..39ddc826b 100644 --- a/src/Bundle/ChillAsideActivityBundle/src/Form/AsideActivityCategoryType.php +++ b/src/Bundle/ChillAsideActivityBundle/src/Form/AsideActivityCategoryType.php @@ -3,6 +3,7 @@ namespace Chill\AsideActivityBundle\Form; use Chill\AsideActivityBundle\Entity\AsideActivityCategory; +use Chill\AsideActivityBundle\Templating\Entity\CategoryRender; use Chill\MainBundle\Form\Type\TranslatableStringFormType; use Chill\MainBundle\Templating\TranslatableStringHelper; use Symfony\Bridge\Doctrine\Form\Type\EntityType; @@ -15,9 +16,10 @@ final class AsideActivityCategoryType extends AbstractType protected $translatableStringHelper; - public function __construct(TranslatableStringHelper $translatableStringHelper) + public function __construct(TranslatableStringHelper $translatableStringHelper, CategoryRender $categoryRender) { $this->translatableStringHelper = $translatableStringHelper; + $this->categoryRender = $categoryRender; } public function buildForm(FormBuilderInterface $builder, array $options) @@ -29,8 +31,10 @@ final class AsideActivityCategoryType extends AbstractType ->add('parent', EntityType::class, [ 'class' => AsideActivityCategory::class, 'required' => false, + 'label' => 'Type', 'choice_label' => function (AsideActivityCategory $category){ - return $this->translatableStringHelper->localize($category->getTitle()); + $options = []; + return $this->categoryRender->renderString($category, $options); } ]) ->add('isActive', ChoiceType::class, diff --git a/src/Bundle/ChillAsideActivityBundle/src/Menu/SectionMenuBuilder.php b/src/Bundle/ChillAsideActivityBundle/src/Menu/SectionMenuBuilder.php index 14e450b3e..7ae0be27a 100644 --- a/src/Bundle/ChillAsideActivityBundle/src/Menu/SectionMenuBuilder.php +++ b/src/Bundle/ChillAsideActivityBundle/src/Menu/SectionMenuBuilder.php @@ -40,7 +40,6 @@ class SectionMenuBuilder implements LocalMenuBuilderInterface 'routeParameters' => [ 'type' => 1, 'duration' => 900, - 'note' => 'Pas des remarques' ] ]) ->setExtras([ diff --git a/src/Bundle/ChillAsideActivityBundle/src/Resources/views/Admin/layout_asideactivity.html.twig b/src/Bundle/ChillAsideActivityBundle/src/Resources/views/Admin/layout_asideactivity.html.twig index f0242c085..08b01cdbd 100644 --- a/src/Bundle/ChillAsideActivityBundle/src/Resources/views/Admin/layout_asideactivity.html.twig +++ b/src/Bundle/ChillAsideActivityBundle/src/Resources/views/Admin/layout_asideactivity.html.twig @@ -9,6 +9,6 @@ {% block layout_wvm_content %} {% block admin_content %} -

{{ 'Aside activity configuration' |trans }}

+

{{ 'Aside activity configuration'|trans }}

{% endblock %} {% endblock %} diff --git a/src/Bundle/ChillAsideActivityBundle/src/Resources/views/asideActivity/_index.html.twig b/src/Bundle/ChillAsideActivityBundle/src/Resources/views/asideActivity/_index.html.twig deleted file mode 100644 index e69de29bb..000000000 diff --git a/src/Bundle/ChillAsideActivityBundle/src/Resources/views/asideActivity/_view.html.twig b/src/Bundle/ChillAsideActivityBundle/src/Resources/views/asideActivity/_view.html.twig index 4601adab1..209214f65 100644 --- a/src/Bundle/ChillAsideActivityBundle/src/Resources/views/asideActivity/_view.html.twig +++ b/src/Bundle/ChillAsideActivityBundle/src/Resources/views/asideActivity/_view.html.twig @@ -3,7 +3,7 @@
{{ 'Type'|trans }}
-
{{ entity.type.title | localize_translatable_string }}
+
{{ entity.type.title|localize_translatable_string }}
{{ 'Created by'|trans }}
{{ entity.createdBy }}
@@ -37,7 +37,7 @@