From e3559774fd22d167d8bfa670fe2ffe00ca661670 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Tue, 3 Oct 2023 21:25:22 +0200
Subject: [PATCH] Improve the signature definition

---
 .../ChillMainBundle/CRUD/Controller/CRUDController.php       | 5 +----
 .../ChillMainBundle/Test/Export/AbstractAggregatorTest.php   | 2 +-
 .../AccompanyingPeriodACLAwareRepositoryInterface.php        | 4 +++-
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/CRUD/Controller/CRUDController.php b/src/Bundle/ChillMainBundle/CRUD/Controller/CRUDController.php
index 1b9778bed..c23b2b536 100644
--- a/src/Bundle/ChillMainBundle/CRUD/Controller/CRUDController.php
+++ b/src/Bundle/ChillMainBundle/CRUD/Controller/CRUDController.php
@@ -863,11 +863,8 @@ class CRUDController extends AbstractController
      * * save-and-close: return to index of current crud ;
      * * save-and-new: return to new page of current crud ;
      * * save-and-view: return to view page of current crud ;
-     *
-     *
-     * @return \Symfony\Component\HttpFoundation\RedirectResponse
      */
-    protected function onBeforeRedirectAfterSubmission(string $action, mixed $entity, FormInterface $form, Request $request)
+    protected function onBeforeRedirectAfterSubmission(string $action, mixed $entity, FormInterface $form, Request $request): ?Response
     {
         $next = $request->request->get('submit', 'save-and-close');
 
diff --git a/src/Bundle/ChillMainBundle/Test/Export/AbstractAggregatorTest.php b/src/Bundle/ChillMainBundle/Test/Export/AbstractAggregatorTest.php
index 1bdb27b7f..70df849cc 100644
--- a/src/Bundle/ChillMainBundle/Test/Export/AbstractAggregatorTest.php
+++ b/src/Bundle/ChillMainBundle/Test/Export/AbstractAggregatorTest.php
@@ -167,7 +167,7 @@ abstract class AbstractAggregatorTest extends KernelTestCase
      *
      * This method is executed before the `setUp` method.
      *
-     * @return \Doctrine\DBAL\Query\QueryBuilder[]
+     * @return QueryBuilder[]
      */
     abstract public function getQueryBuilders();
 
diff --git a/src/Bundle/ChillPersonBundle/Repository/AccompanyingPeriodACLAwareRepositoryInterface.php b/src/Bundle/ChillPersonBundle/Repository/AccompanyingPeriodACLAwareRepositoryInterface.php
index 7b31887b9..3baaf1517 100644
--- a/src/Bundle/ChillPersonBundle/Repository/AccompanyingPeriodACLAwareRepositoryInterface.php
+++ b/src/Bundle/ChillPersonBundle/Repository/AccompanyingPeriodACLAwareRepositoryInterface.php
@@ -11,6 +11,7 @@ declare(strict_types=1);
 
 namespace Chill\PersonBundle\Repository;
 
+use Chill\MainBundle\Entity\Location;
 use Chill\MainBundle\Entity\PostalCode;
 use Chill\MainBundle\Entity\Scope;
 use Chill\MainBundle\Entity\User;
@@ -23,6 +24,7 @@ interface AccompanyingPeriodACLAwareRepositoryInterface
     /**
      * @param array|UserJob[] $jobs
      * @param array|Scope[] $services
+     * @param array|Location[] $administrativeLocations
      */
     public function countByUnDispatched(array $jobs, array $services, array $administrativeLocations): int;
 
@@ -45,7 +47,7 @@ interface AccompanyingPeriodACLAwareRepositoryInterface
     /**
      * @param array|UserJob[] $jobs if empty, does not take this argument into account
      * @param array|Scope[] $services if empty, does not take this argument into account
-     *
+     * @param array|Location[] $administrativeLocations
      * @return list<AccompanyingPeriod>
      */
     public function findByUnDispatched(array $jobs, array $services, array $administrativeAdministrativeLocations, ?array $orderBy = null, ?int $limit = null, ?int $offset = null): array;