From d8b6cef7b44c05797fe3bd97d2f2bac3bef9a5ae Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 24 Apr 2024 10:18:07 +0200
Subject: [PATCH] rector fixes

---
 .../src/ApiHelper/ApiWrapper.php              |  2 +-
 .../src/Controller/CSPersonController.php     | 19 +++++++------------
 .../src/Controller/CSReportController.php     |  2 +-
 .../ChillJobBundle/src/Entity/Immersion.php   |  2 +-
 4 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/src/Bundle/ChillFranceTravailApiBundle/src/ApiHelper/ApiWrapper.php b/src/Bundle/ChillFranceTravailApiBundle/src/ApiHelper/ApiWrapper.php
index 360f200cd..975170f72 100644
--- a/src/Bundle/ChillFranceTravailApiBundle/src/ApiHelper/ApiWrapper.php
+++ b/src/Bundle/ChillFranceTravailApiBundle/src/ApiHelper/ApiWrapper.php
@@ -32,7 +32,7 @@ class ApiWrapper
      */
     public const UNPERSONAL_BEARER = 'api_pemploi_bear_';
 
-    public function __construct(private $clientId, private $clientSecret, private ChillRedis $redis)
+    public function __construct(private $clientId, private $clientSecret, private readonly ChillRedis $redis)
     {
         $this->client = new Client([
             'base_uri' => 'https://entreprise.pole-emploi.fr/connexion/oauth2/access_token',
diff --git a/src/Bundle/ChillJobBundle/src/Controller/CSPersonController.php b/src/Bundle/ChillJobBundle/src/Controller/CSPersonController.php
index 0c4e44c0e..d72a87dcc 100644
--- a/src/Bundle/ChillJobBundle/src/Controller/CSPersonController.php
+++ b/src/Bundle/ChillJobBundle/src/Controller/CSPersonController.php
@@ -104,18 +104,13 @@ class CSPersonController extends OneToOneEntityPersonCRUDController
 
     protected function getTemplateFor($action, $entity, Request $request): string
     {
-        switch ($action) {
-            case 'ps_situation_edit':
-                return '@ChillJob/CSPerson/personal_situation_edit.html.twig';
-            case 'dispositifs_edit':
-                return '@ChillJob/CSPerson/dispositifs_edit.html.twig';
-            case 'ps_situation_view':
-                return '@ChillJob/CSPerson/personal_situation_view.html.twig';
-            case 'dispositifs_view':
-                return '@ChillJob/CSPerson/dispositifs_view.html.twig';
-            default:
-                return parent::getTemplateFor($action, $entity, $request);
-        }
+        return match ($action) {
+            'ps_situation_edit' => '@ChillJob/CSPerson/personal_situation_edit.html.twig',
+            'dispositifs_edit' => '@ChillJob/CSPerson/dispositifs_edit.html.twig',
+            'ps_situation_view' => '@ChillJob/CSPerson/personal_situation_view.html.twig',
+            'dispositifs_view' => '@ChillJob/CSPerson/dispositifs_view.html.twig',
+            default => parent::getTemplateFor($action, $entity, $request),
+        };
     }
 
     protected function createFormFor(string $action, $entity, ?string $formClass = null, array $formOptions = []): FormInterface
diff --git a/src/Bundle/ChillJobBundle/src/Controller/CSReportController.php b/src/Bundle/ChillJobBundle/src/Controller/CSReportController.php
index 3de5a68e0..e6a3c4517 100644
--- a/src/Bundle/ChillJobBundle/src/Controller/CSReportController.php
+++ b/src/Bundle/ChillJobBundle/src/Controller/CSReportController.php
@@ -24,7 +24,7 @@ use Chill\JobBundle\Security\Authorization\CSConnectesVoter;
 
 class CSReportController extends AbstractController
 {
-    public function __construct(private \Doctrine\Persistence\ManagerRegistry $managerRegistry) {}
+    public function __construct(private readonly \Doctrine\Persistence\ManagerRegistry $managerRegistry) {}
 
     #[Route(path: '{_locale}/person/job/{person}/report', name: 'chill_job_report_index')]
     public function index(Person $person): Response
diff --git a/src/Bundle/ChillJobBundle/src/Entity/Immersion.php b/src/Bundle/ChillJobBundle/src/Entity/Immersion.php
index 88591f732..5de874231 100644
--- a/src/Bundle/ChillJobBundle/src/Entity/Immersion.php
+++ b/src/Bundle/ChillJobBundle/src/Entity/Immersion.php
@@ -636,7 +636,7 @@ class Immersion implements \Stringable
      *
      * @return Immersion
      */
-    public function setNoteImmersion($note)
+    public function setNoteImmersion(?string $note)
     {
         $this->noteImmersion = $note;