From d7174cdb9560c3ee2ca8d4a137183241f4c4ddb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Fri, 25 Oct 2024 18:20:58 +0200
Subject: [PATCH] Reintroduce pending signatures section in person list view

Moved the pending signatures section within the person list view template to the correct location.

OP#771
https://champs-libres.openproject.com/work_packages/771
---
 .../views/Person/list_with_period.html.twig   | 56 +++++++++----------
 1 file changed, 27 insertions(+), 29 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Person/list_with_period.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Person/list_with_period.html.twig
index fa7a1b6ea..7c75bc712 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/Person/list_with_period.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/Person/list_with_period.html.twig
@@ -224,33 +224,6 @@
                 </ul>
             </div>
         </div>
-        {% if person.signaturesPending|length > 0 %}
-            <div class="item-row separator">
-                <div class="wrap-list periods-list">
-                    <div class="wl-row">
-                        <div class="wl-col title">
-                            <h3>{{ 'workflow.pending_signatures'|trans({nb_signatures: person.signaturesPending|length}) }}</h3>
-                        </div>
-                        <div class="wl-col list">
-                            {% for signature in person.signaturesPending %}
-                                {% set entityWorkflow = signature.step.entityWorkflow %}
-                                {{ entityWorkflow|chill_entity_render_string }}
-                                <ul class="record_actions small slim">
-                                    <li>
-                                        <a href="{{ chill_path_add_return_path('chill_main_workflow_signature_metadata', {signature_id: signature.id}) }}" class="btn btn-misc">
-                                            <i class="fa fa-pencil"></i>
-                                        </a>
-                                    </li>
-                                    <li>
-                                        <a href="{{ chill_path_add_return_path('chill_main_workflow_show', {id: entityWorkflow.id}) }}" class="btn btn-show"></a>
-                                    </li>
-                                </ul>
-                            {% endfor %}
-                        </div>
-                    </div>
-                </div>
-            </div>
-        {% endif %}
 {% endmacro %}
 
 <div class="list-with-period">
@@ -355,8 +328,33 @@
                             </div>
                         </div>
                     {% endif %}
-
-
+                    {% if person.signaturesPending|length > 0 %}
+                    <div class="item-row separator">
+                        <div class="wrap-list periods-list">
+                            <div class="wl-row">
+                                <div class="wl-col title">
+                                    <h3>{{ 'workflow.pending_signatures'|trans({nb_signatures: person.signaturesPending|length}) }}</h3>
+                                </div>
+                                <div class="wl-col list">
+                                    {% for signature in person.signaturesPending %}
+                                        {% set entityWorkflow = signature.step.entityWorkflow %}
+                                        {{ entityWorkflow|chill_entity_render_string }}
+                                        <ul class="record_actions small slim">
+                                            <li>
+                                                <a href="{{ chill_path_add_return_path('chill_main_workflow_signature_metadata', {signature_id: signature.id}) }}" class="btn btn-misc">
+                                                    <i class="fa fa-pencil"></i>
+                                                </a>
+                                            </li>
+                                            <li>
+                                                <a href="{{ chill_path_add_return_path('chill_main_workflow_show', {id: entityWorkflow.id}) }}" class="btn btn-show"></a>
+                                            </li>
+                                        </ul>
+                                    {% endfor %}
+                                </div>
+                            </div>
+                        </div>
+                    </div>
+                    {% endif %}
                 </div>
             {% endfor %}
         </div>