From d62ba56cfe92fde7577a86a7012eaf603d8eabad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20Fastr=C3=A9?= Date: Sat, 18 Feb 2023 08:20:13 +0100 Subject: [PATCH] fix some phpstan errors --- phpstan-baseline-level-4.neon | 10 ---------- .../AccompanyingCourseFilters/ReferrerFilter.php | 4 ---- .../Filter/AccompanyingCourseFilters/UserJobFilter.php | 4 ---- .../Export/Filter/SocialWorkFilters/ReferrerFilter.php | 7 ------- 4 files changed, 25 deletions(-) diff --git a/phpstan-baseline-level-4.neon b/phpstan-baseline-level-4.neon index 8010f3cbc..0f8f8adb2 100644 --- a/phpstan-baseline-level-4.neon +++ b/phpstan-baseline-level-4.neon @@ -3916,21 +3916,11 @@ parameters: count: 1 path: src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/AdministrativeLocationFilter.php - - - message: "#^Property Chill\\\\PersonBundle\\\\Export\\\\Filter\\\\AccompanyingCourseFilters\\\\ReferrerFilter\\:\\:\\$userRender is never read, only written\\.$#" - count: 1 - path: src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/ReferrerFilter.php - - message: "#^Property Chill\\\\PersonBundle\\\\Export\\\\Filter\\\\AccompanyingCourseFilters\\\\SocialActionFilter\\:\\:\\$translatableStringHelper is never read, only written\\.$#" count: 1 path: src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/SocialActionFilter.php - - - message: "#^Method Chill\\\\PersonBundle\\\\Export\\\\Filter\\\\AccompanyingCourseFilters\\\\UserJobFilter\\:\\:getUserJob\\(\\) is unused\\.$#" - count: 1 - path: src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/UserJobFilter.php - - message: "#^Method Chill\\\\PersonBundle\\\\Export\\\\Filter\\\\AccompanyingCourseFilters\\\\UserScopeFilter\\:\\:getUserMainScope\\(\\) is unused\\.$#" count: 1 diff --git a/src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/ReferrerFilter.php b/src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/ReferrerFilter.php index b37d90d84..bb31a6cde 100644 --- a/src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/ReferrerFilter.php +++ b/src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/ReferrerFilter.php @@ -31,13 +31,9 @@ class ReferrerFilter implements FilterInterface private RollingDateConverterInterface $rollingDateConverter; - private UserRender $userRender; - public function __construct( - UserRender $userRender, RollingDateConverterInterface $rollingDateConverter ) { - $this->userRender = $userRender; $this->rollingDateConverter = $rollingDateConverter; } diff --git a/src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/UserJobFilter.php b/src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/UserJobFilter.php index 2b69c528b..b9d0d0b15 100644 --- a/src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/UserJobFilter.php +++ b/src/Bundle/ChillPersonBundle/Export/Filter/AccompanyingCourseFilters/UserJobFilter.php @@ -37,19 +37,15 @@ class UserJobFilter implements FilterInterface private RollingDateConverterInterface $rollingDateConverter; - private Security $security; - private TranslatableStringHelper $translatableStringHelper; private UserJobRepositoryInterface $userJobRepository; public function __construct( - Security $security, TranslatableStringHelper $translatableStringHelper, UserJobRepositoryInterface $userJobRepository, RollingDateConverterInterface $rollingDateConverter ) { - $this->security = $security; $this->translatableStringHelper = $translatableStringHelper; $this->userJobRepository = $userJobRepository; $this->rollingDateConverter = $rollingDateConverter; diff --git a/src/Bundle/ChillPersonBundle/Export/Filter/SocialWorkFilters/ReferrerFilter.php b/src/Bundle/ChillPersonBundle/Export/Filter/SocialWorkFilters/ReferrerFilter.php index b7e9ff56e..8d0da32fb 100644 --- a/src/Bundle/ChillPersonBundle/Export/Filter/SocialWorkFilters/ReferrerFilter.php +++ b/src/Bundle/ChillPersonBundle/Export/Filter/SocialWorkFilters/ReferrerFilter.php @@ -22,13 +22,6 @@ use function in_array; class ReferrerFilter implements FilterInterface { - private UserRender $userRender; - - public function __construct(UserRender $userRender) - { - $this->userRender = $userRender; - } - public function addRole(): ?string { return null;