From c35ca3dbebdefa9354488f436b3a4541ca737ee2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Tue, 28 Feb 2023 22:39:33 +0100
Subject: [PATCH] DX: fix cs

---
 .../Service/DocGenerator/CalendarContext.php  |  1 +
 .../DocGeneratorTemplateController.php        |  5 +++--
 .../Service/Generator/Generator.php           | 19 ++++++++++++++-----
 .../Service/Generator/GeneratorException.php  | 16 ++++++++++++++--
 .../Service/Generator/GeneratorInterface.php  |  9 +++++++++
 .../Generator/ObjectReadyException.php        |  9 +++++++++
 .../RelatedEntityNotFoundException.php        | 12 +++++++++++-
 .../Service/Messenger/OnGenerationFails.php   | 11 ++++++++++-
 .../Messenger/RequestGenerationHandler.php    |  9 +++++++++
 .../Messenger/RequestGenerationMessage.php    | 19 ++++++++++++++-----
 .../migrations/Version20230214192558.php      |  7 +++++++
 .../Context/Generator/GeneratorTest.php       | 15 ++++++++++++++-
 .../Controller/StoredObjectApiController.php  |  9 +++++++++
 .../Entity/StoredObject.php                   |  3 +--
 .../migrations/Version20230227161327.php      |  7 +++++++
 .../ChillWopiBundle/src/Controller/Editor.php |  3 ++-
 16 files changed, 134 insertions(+), 20 deletions(-)

diff --git a/src/Bundle/ChillCalendarBundle/Service/DocGenerator/CalendarContext.php b/src/Bundle/ChillCalendarBundle/Service/DocGenerator/CalendarContext.php
index 9c436524d..5d20d3575 100644
--- a/src/Bundle/ChillCalendarBundle/Service/DocGenerator/CalendarContext.php
+++ b/src/Bundle/ChillCalendarBundle/Service/DocGenerator/CalendarContext.php
@@ -151,6 +151,7 @@ final class CalendarContext implements CalendarContextInterface
 
     /**
      * param array{mainPerson?: Person, thirdParty?: ThirdParty, title: string} $contextGenerationData
+     * @param mixed $entity
      */
     public function getData(DocGeneratorTemplate $template, $entity, array $contextGenerationData = []): array
     {
diff --git a/src/Bundle/ChillDocGeneratorBundle/Controller/DocGeneratorTemplateController.php b/src/Bundle/ChillDocGeneratorBundle/Controller/DocGeneratorTemplateController.php
index 6f153acd8..4e89861dd 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Controller/DocGeneratorTemplateController.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Controller/DocGeneratorTemplateController.php
@@ -257,7 +257,8 @@ final class DocGeneratorTemplateController extends AbstractController
             return $this->render('@ChillDocGenerator/Generator/debug_value.html.twig', [
                 'datas' => json_encode($context->getData($template, $entity, $contextGenerationData), JSON_PRETTY_PRINT)
             ]);
-        } elseif ($isTest) {
+        }
+        if ($isTest) {
             $generated = $this->generator->generateDocFromTemplate(
                 $template,
                 $entityId,
@@ -283,7 +284,7 @@ final class DocGeneratorTemplateController extends AbstractController
         // we prepare the object to store the document
         $storedObject = (new StoredObject())
             ->setStatus(StoredObject::STATUS_PENDING)
-            ;
+        ;
 
         $this->entityManager->persist($storedObject);
 
diff --git a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/Generator.php b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/Generator.php
index 394f8148b..624bf2435 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/Generator.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/Generator.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\Service\Generator;
 
 use Chill\DocGeneratorBundle\Context\ContextManagerInterface;
@@ -72,7 +81,7 @@ class Generator implements GeneratorInterface
         $entity = $this
             ->entityManager
             ->find($context->getEntityClass(), $entityId)
-            ;
+        ;
 
         if (null === $entity) {
             throw new RelatedEntityNotFoundException($template->getEntity(), $entityId);
@@ -80,9 +89,9 @@ class Generator implements GeneratorInterface
 
         $contextGenerationDataNormalized = array_merge(
             $contextGenerationDataNormalized,
-                $context instanceof DocGeneratorContextWithPublicFormInterface ?
-                    $context->contextGenerationDataDenormalize($template, $entity, $contextGenerationDataNormalized)
-                    : []
+            $context instanceof DocGeneratorContextWithPublicFormInterface ?
+                $context->contextGenerationDataDenormalize($template, $entity, $contextGenerationDataNormalized)
+                : []
         );
 
         $data = $context->getData($template, $entity, $contextGenerationDataNormalized);
@@ -127,7 +136,7 @@ class Generator implements GeneratorInterface
             ->setType($template->getFile()->getType())
             ->setFilename(sprintf('%s_odt', uniqid('doc_', true)))
             ->setStatus(StoredObject::STATUS_READY)
-            ;
+        ;
 
         $this->storedObjectManager->write($destinationStoredObject, $generatedResource);
 
diff --git a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/GeneratorException.php b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/GeneratorException.php
index 0f3412859..2124ee420 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/GeneratorException.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/GeneratorException.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\Service\Generator;
 
 class GeneratorException extends \RuntimeException
@@ -12,8 +21,11 @@ class GeneratorException extends \RuntimeException
     public function __construct(array $errors = [], \Throwable $previous = null)
     {
         $this->errors = $errors;
-        parent::__construct("Could not generate the document", 15252,
-            $previous);
+        parent::__construct(
+            "Could not generate the document",
+            15252,
+            $previous
+        );
     }
 
     /**
diff --git a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/GeneratorInterface.php b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/GeneratorInterface.php
index 385e1d010..fc2f0e2f9 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/GeneratorInterface.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/GeneratorInterface.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\Service\Generator;
 
 use Chill\DocGeneratorBundle\Entity\DocGeneratorTemplate;
diff --git a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/ObjectReadyException.php b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/ObjectReadyException.php
index 85c82cf95..4d17f0cf8 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/ObjectReadyException.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/ObjectReadyException.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\Service\Generator;
 
 class ObjectReadyException extends \RuntimeException
diff --git a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/RelatedEntityNotFoundException.php b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/RelatedEntityNotFoundException.php
index a8e6f4059..f504f3212 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Service/Generator/RelatedEntityNotFoundException.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Service/Generator/RelatedEntityNotFoundException.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\Service\Generator;
 
 class RelatedEntityNotFoundException extends \RuntimeException
@@ -9,6 +18,7 @@ class RelatedEntityNotFoundException extends \RuntimeException
         parent::__construct(
             sprintf("Related entity not found: %s, %s", $relatedEntityClass, $relatedEntityId),
             99876652,
-            $previous);
+            $previous
+        );
     }
 }
diff --git a/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/OnGenerationFails.php b/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/OnGenerationFails.php
index cbd539913..5f20a3e69 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/OnGenerationFails.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/OnGenerationFails.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\Service\Messenger;
 
 use Chill\DocGeneratorBundle\Repository\DocGeneratorTemplateRepository;
@@ -31,7 +40,7 @@ final class OnGenerationFails implements EventSubscriberInterface
 
     private UserRepositoryInterface $userRepository;
 
-    const LOG_PREFIX = '[docgen failed] ';
+    public const LOG_PREFIX = '[docgen failed] ';
 
     /**
      * @param DocGeneratorTemplateRepository $docGeneratorTemplateRepository
diff --git a/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/RequestGenerationHandler.php b/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/RequestGenerationHandler.php
index 0cfdecd0a..eec6ce666 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/RequestGenerationHandler.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/RequestGenerationHandler.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\Service\Messenger;
 
 use Chill\DocGeneratorBundle\Repository\DocGeneratorTemplateRepository;
diff --git a/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/RequestGenerationMessage.php b/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/RequestGenerationMessage.php
index edba90ce4..3a1318d39 100644
--- a/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/RequestGenerationMessage.php
+++ b/src/Bundle/ChillDocGeneratorBundle/Service/Messenger/RequestGenerationMessage.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\Service\Messenger;
 
 use Chill\DocGeneratorBundle\Entity\DocGeneratorTemplate;
@@ -8,15 +17,15 @@ use Chill\MainBundle\Entity\User;
 
 class RequestGenerationMessage
 {
-   private int $creatorId;
+    private int $creatorId;
 
-   private int $templateId;
+    private int $templateId;
 
-   private int $entityId;
+    private int $entityId;
 
-   private int $destinationStoredObjectId;
+    private int $destinationStoredObjectId;
 
-   private array $contextGenerationData;
+    private array $contextGenerationData;
 
     public function __construct(
         User $creator,
diff --git a/src/Bundle/ChillDocGeneratorBundle/migrations/Version20230214192558.php b/src/Bundle/ChillDocGeneratorBundle/migrations/Version20230214192558.php
index de536ca84..176256924 100644
--- a/src/Bundle/ChillDocGeneratorBundle/migrations/Version20230214192558.php
+++ b/src/Bundle/ChillDocGeneratorBundle/migrations/Version20230214192558.php
@@ -2,6 +2,13 @@
 
 declare(strict_types=1);
 
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\Migrations\DocGenerator;
 
 use Doctrine\DBAL\Schema\Schema;
diff --git a/src/Bundle/ChillDocGeneratorBundle/tests/Service/Context/Generator/GeneratorTest.php b/src/Bundle/ChillDocGeneratorBundle/tests/Service/Context/Generator/GeneratorTest.php
index 066715b60..ea23d94b5 100644
--- a/src/Bundle/ChillDocGeneratorBundle/tests/Service/Context/Generator/GeneratorTest.php
+++ b/src/Bundle/ChillDocGeneratorBundle/tests/Service/Context/Generator/GeneratorTest.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocGeneratorBundle\tests\Service\Context\Generator;
 
 use Chill\DocGeneratorBundle\Context\ContextManagerInterface;
@@ -17,6 +26,10 @@ use Prophecy\Argument;
 use Prophecy\PhpUnit\ProphecyTrait;
 use Psr\Log\NullLogger;
 
+/**
+ * @internal
+ * @coversNothing
+ */
 class GeneratorTest extends TestCase
 {
     use ProphecyTrait;
@@ -29,7 +42,7 @@ class GeneratorTest extends TestCase
         $reflection = new \ReflectionClass($destinationStoredObject);
         $reflection->getProperty('id')->setAccessible(true);
         $reflection->getProperty('id')->setValue($destinationStoredObject, 1);
-        $entity = new class {};
+        $entity = new class () {};
         $data = [];
 
         $context = $this->prophesize(DocGeneratorContextInterface::class);
diff --git a/src/Bundle/ChillDocStoreBundle/Controller/StoredObjectApiController.php b/src/Bundle/ChillDocStoreBundle/Controller/StoredObjectApiController.php
index 29b978ffb..a11556e42 100644
--- a/src/Bundle/ChillDocStoreBundle/Controller/StoredObjectApiController.php
+++ b/src/Bundle/ChillDocStoreBundle/Controller/StoredObjectApiController.php
@@ -1,5 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\DocStoreBundle\Controller;
 
 use Chill\DocStoreBundle\Entity\StoredObject;
diff --git a/src/Bundle/ChillDocStoreBundle/Entity/StoredObject.php b/src/Bundle/ChillDocStoreBundle/Entity/StoredObject.php
index 8821ead7c..e83d3b3fc 100644
--- a/src/Bundle/ChillDocStoreBundle/Entity/StoredObject.php
+++ b/src/Bundle/ChillDocStoreBundle/Entity/StoredObject.php
@@ -35,12 +35,11 @@ use Symfony\Component\Serializer\Annotation as Serializer;
  */
 class StoredObject implements AsyncFileInterface, Document, TrackCreationInterface
 {
+    use TrackCreationTrait;
     public const STATUS_READY = "ready";
     public const STATUS_PENDING = "pending";
     public const STATUS_FAILURE = "failure";
 
-    use TrackCreationTrait;
-
     /**
      * @ORM\Column(type="json", name="datas")
      * @Serializer\Groups({"read", "write"})
diff --git a/src/Bundle/ChillDocStoreBundle/migrations/Version20230227161327.php b/src/Bundle/ChillDocStoreBundle/migrations/Version20230227161327.php
index f3b29b8b1..a9453fa07 100644
--- a/src/Bundle/ChillDocStoreBundle/migrations/Version20230227161327.php
+++ b/src/Bundle/ChillDocStoreBundle/migrations/Version20230227161327.php
@@ -2,6 +2,13 @@
 
 declare(strict_types=1);
 
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\Migrations\DocStore;
 
 use Doctrine\DBAL\Schema\Schema;
diff --git a/src/Bundle/ChillWopiBundle/src/Controller/Editor.php b/src/Bundle/ChillWopiBundle/src/Controller/Editor.php
index d19a98052..b0ff7fb4c 100644
--- a/src/Bundle/ChillWopiBundle/src/Controller/Editor.php
+++ b/src/Bundle/ChillWopiBundle/src/Controller/Editor.php
@@ -104,7 +104,8 @@ final class Editor
                 $this->engine
                     ->render('@ChillWopi/Editor/stored_object_failure.html.twig')
             );
-        } elseif (StoredObject::STATUS_PENDING === $storedObject->getStatus()) {
+        }
+        if (StoredObject::STATUS_PENDING === $storedObject->getStatus()) {
             return new Response(
                 $this->engine
                     ->render('@ChillWopi/Editor/stored_object_pending.html.twig', [