From ba495def7e3d7f9d0666259b8f1c1586c6a13ba0 Mon Sep 17 00:00:00 2001
From: nobohan
Date: Thu, 5 May 2022 09:47:17 +0200
Subject: [PATCH] admin: refactor templates and delete some show pages for
Center, Scope, User, UserJob, PermissionsGroup
---
.../Controller/CenterController.php | 2 +-
.../Controller/ScopeController.php | 2 +-
.../ChillMainExtension.php | 2 +
.../Resources/views/Center/edit.html.twig | 16 ++--
.../Resources/views/Center/index.html.twig | 28 ++++---
.../Resources/views/Center/new.html.twig | 16 ++--
.../Resources/views/Center/show.html.twig | 29 -------
.../views/PermissionsGroup/edit.html.twig | 76 +++++++++----------
.../views/PermissionsGroup/index.html.twig | 27 ++++---
.../views/PermissionsGroup/new.html.twig | 16 ++--
.../views/PermissionsGroup/show.html.twig | 23 +++---
.../Resources/views/Scope/edit.html.twig | 20 ++---
.../Resources/views/Scope/index.html.twig | 28 ++++---
.../Resources/views/Scope/new.html.twig | 18 ++---
.../Resources/views/Scope/show.html.twig | 29 -------
.../Resources/views/User/edit.html.twig | 2 +-
.../views/User/edit_password.html.twig | 2 +-
.../Resources/views/User/index.html.twig | 7 +-
.../Resources/views/User/new.html.twig | 4 +-
.../Resources/views/User/show.html.twig | 10 +--
.../Resources/views/UserJob/edit.html.twig | 11 +++
.../Resources/views/UserJob/index.html.twig | 22 +++++-
.../Resources/views/UserJob/new.html.twig | 11 +++
.../MenuBuilder/AdminSectionMenuBuilder.php | 5 --
.../ChillMainBundle/config/routes/center.yaml | 4 -
.../ChillMainBundle/config/routes/scope.yaml | 4 -
.../translations/messages.fr.yml | 21 +++--
27 files changed, 207 insertions(+), 228 deletions(-)
delete mode 100644 src/Bundle/ChillMainBundle/Resources/views/Center/show.html.twig
delete mode 100644 src/Bundle/ChillMainBundle/Resources/views/Scope/show.html.twig
create mode 100644 src/Bundle/ChillMainBundle/Resources/views/UserJob/edit.html.twig
create mode 100644 src/Bundle/ChillMainBundle/Resources/views/UserJob/new.html.twig
diff --git a/src/Bundle/ChillMainBundle/Controller/CenterController.php b/src/Bundle/ChillMainBundle/Controller/CenterController.php
index 729f2b243..005fa4a01 100644
--- a/src/Bundle/ChillMainBundle/Controller/CenterController.php
+++ b/src/Bundle/ChillMainBundle/Controller/CenterController.php
@@ -36,7 +36,7 @@ class CenterController extends AbstractController
$em->persist($center);
$em->flush();
- return $this->redirect($this->generateUrl('admin_center_show', ['id' => $center->getId()]));
+ return $this->redirect($this->generateUrl('admin_center'));
}
return $this->render('@ChillMain/Center/new.html.twig', [
diff --git a/src/Bundle/ChillMainBundle/Controller/ScopeController.php b/src/Bundle/ChillMainBundle/Controller/ScopeController.php
index 74ebc73a7..5dc85d201 100644
--- a/src/Bundle/ChillMainBundle/Controller/ScopeController.php
+++ b/src/Bundle/ChillMainBundle/Controller/ScopeController.php
@@ -36,7 +36,7 @@ class ScopeController extends AbstractController
$em->persist($scope);
$em->flush();
- return $this->redirect($this->generateUrl('admin_scope_show', ['id' => $scope->getId()]));
+ return $this->redirect($this->generateUrl('admin_scope'));
}
return $this->render('@ChillMain/Scope/new.html.twig', [
diff --git a/src/Bundle/ChillMainBundle/DependencyInjection/ChillMainExtension.php b/src/Bundle/ChillMainBundle/DependencyInjection/ChillMainExtension.php
index 0c974b637..a62ca88f3 100644
--- a/src/Bundle/ChillMainBundle/DependencyInjection/ChillMainExtension.php
+++ b/src/Bundle/ChillMainBundle/DependencyInjection/ChillMainExtension.php
@@ -319,9 +319,11 @@ class ChillMainExtension extends Extension implements
],
'new' => [
'role' => 'ROLE_ADMIN',
+ 'template' => '@ChillMain/UserJob/new.html.twig',
],
'edit' => [
'role' => 'ROLE_ADMIN',
+ 'template' => '@ChillMain/UserJob/edit.html.twig',
],
],
],
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Center/edit.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Center/edit.html.twig
index d2018e2d3..30bea2d6e 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/Center/edit.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/Center/edit.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'Center edit'|trans }}{% endblock %}
@@ -10,11 +10,11 @@
{{ form_row(edit_form.submit, { 'attr' : { 'class' : 'btn btn-chill-green' } } ) }}
{{ form_end(edit_form) }}
-
+
{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Center/index.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Center/index.html.twig
index 5ebd271b5..d6d4bb4cd 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/Center/index.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/Center/index.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'Center list'|trans }}{% endblock %}
@@ -15,27 +15,25 @@
{% for entity in entities %}
- {{ entity.name }} |
+ {{ entity.name }} |
-
+
|
{% endfor %}
-
+
- {% endblock %}
+{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Center/new.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Center/new.html.twig
index b100d0b8b..ef614722b 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/Center/new.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/Center/new.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'Center creation'|trans }}{% endblock %}
@@ -10,11 +10,11 @@
{{ form_row(form.submit, { 'attr' : { 'class' : 'btn btn-chill-green' } } ) }}
{{ form_end(form) }}
-
+
{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Center/show.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Center/show.html.twig
deleted file mode 100644
index b471fa2d1..000000000
--- a/src/Bundle/ChillMainBundle/Resources/views/Center/show.html.twig
+++ /dev/null
@@ -1,29 +0,0 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
-
-{% block title %}{{ 'Centre %name%'|trans({ '%name%': entity.name }) }}{% endblock %}
-
-{% block admin_content -%}
- {{ 'Centre %name%'|trans({ '%name%': entity.name }) }}
-
-
-
-
- {{ 'Name'|trans }} |
- {{ entity.name }} |
-
-
-
-
-
-{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/edit.html.twig b/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/edit.html.twig
index 9054176d7..f61c8f2c8 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/edit.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/edit.html.twig
@@ -1,12 +1,12 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'PermissionsGroup "%name%" edit'|trans( { '%name%': entity.name } ) }}{% endblock %}
{% block admin_content -%}
{{ 'PermissionsGroup "%name%" edit'|trans( { '%name%': entity.name } ) }}
-
+
{{ 'Details'|trans }}
-
+
{{ form_start(edit_form) }}
{{ form_row(edit_form.name) }}
{% if edit_form.flags is defined %}
@@ -14,28 +14,28 @@
{% endif %}
{{ form_row(edit_form.submit, { 'attr': { 'class': 'btn btn-chill-green' } } ) }}
{{ form_end(edit_form) }}
-
+
{{ 'Grant those permissions'|trans }} :
-
+
{%- if entity.getRoleScopes|length > 0 -%}
{% for title, role_scopes in role_scopes_sorted %}
-
+
{{ title|default("Unclassified")|trans }}
-
+
{{ 'Role'|trans }} |
{{ 'Circle'|trans }} |
{{ 'Actions'|trans }} |
-
+
-
+
{% for role_scope in role_scopes %}
- {{ role_scope.role|trans }}
+ {{ role_scope.role|trans }}
{% if expanded_roles[role_scope.role]|length > 1 %}
{{ 'Which implies'|trans }} : {% for role in expanded_roles[role_scope.role] %}{{ role|trans }}{% if not loop.last %}, {% endif %}{% endfor %}
@@ -56,40 +56,40 @@
{{ form_end(delete_role_scopes_form[role_scope.id]) }}
|
-
+
{% endfor %}
{% endfor %}
-
+
{%- else -%}
{{ 'This group does not provide any permission'|trans }}
{%- endif -%}
-
- {{ 'Grant new permissions'|trans }}
-
- {{ form_start(add_role_scopes_form) }}
- {{ form_errors(add_role_scopes_form) }}
- {{ form_row(add_role_scopes_form.composed_role_scope.role) }}
- {{ form_row(add_role_scopes_form.composed_role_scope.scope) }}
-
-
-
-
- {{ form_end(add_role_scopes_form) }}
-
-
+
+
{{ 'Grant new permissions'|trans }}
+
+ {{ form_start(add_role_scopes_form) }}
+ {{ form_errors(add_role_scopes_form) }}
+ {{ form_row(add_role_scopes_form.composed_role_scope.role) }}
+ {{ form_row(add_role_scopes_form.composed_role_scope.scope) }}
+
+
+
+ {{ form_end(add_role_scopes_form) }}
+
+
+
{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/index.html.twig b/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/index.html.twig
index cc3cabc48..1b35e9799 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/index.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/index.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'Permissions group list'|trans }}{% endblock %}
@@ -15,27 +15,30 @@
{% for entity in entities %}
- {{ entity.name }} |
+ {{ entity.name }} |
-
+
|
{% endfor %}
-
+
- {% endblock %}
+{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/new.html.twig b/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/new.html.twig
index 76474f220..921db8e6d 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/new.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/new.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'New permission group'|trans }}{% endblock %}
@@ -13,11 +13,11 @@
{{ form_row(form.submit, { 'attr': { 'class': 'btn btn-chill-green' } } ) }}
{{ form_end(form) }}
-
+
{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/show.html.twig b/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/show.html.twig
index b94b5204d..fbbe6245b 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/show.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/PermissionsGroup/show.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'Permission group "%name%"'|trans({ '%name%': entity.name }) }}{% endblock %}
@@ -13,9 +13,9 @@
- {% if role_scopes_sorted|length > 0 %}
+ {% if role_scopes_sorted|length > 0 %}
{{ 'Grant those permissions'|trans }} :
-
+
{% for title, role_scopes in role_scopes_sorted %}
{{ title|default('Unclassified')|trans }}
@@ -23,14 +23,14 @@
{{ 'Role'|trans }} |
{{ 'Circle'|trans }} |
-
+
-
+
{% for role_scope in role_scopes %}
- {{ role_scope.role|trans }}
+ {{ role_scope.role|trans }}
{% if expanded_roles[role_scope.role]|length > 1 %}
{{ 'Which implies'|trans }} : {% for role in expanded_roles[role_scope.role] %}{{ role|trans }}{% if not loop.last %}, {% endif %}{% endfor %}
@@ -47,16 +47,17 @@
|
{% endfor %}
-
+
{% else %}
-
- {{ 'This group does not provide any permission'|trans }}.
+
{{ 'This group does not provide any permission'|trans }}.
- {{ 'add permissions'|trans|capitalize }}
+ {{ 'add permissions'|trans|capitalize }}
+
+
{% endif %}
-
+
-
{{ 'Edit'|trans }}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Scope/edit.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Scope/edit.html.twig
index 2f1098761..6330f2b26 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/Scope/edit.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/Scope/edit.html.twig
@@ -1,20 +1,20 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'Circle edit'|trans }}{% endblock %}
-{% block admin_content -%}
+{% block admin_content %}
{{ 'Circle edit'|trans }}
-
+
{{ form_start(edit_form) }}
{{ form_row(edit_form.name) }}
{{ form_row(edit_form.submit, { 'attr' : { 'class' : 'btn btn-chill-green' } } ) }}
{{ form_end(edit_form) }}
-
+
{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Scope/index.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Scope/index.html.twig
index 5167b9d07..444ba2cc5 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/Scope/index.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/Scope/index.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'List circles'|trans }}{% endblock %}
@@ -15,27 +15,25 @@
{% for entity in entities %}
- {{ entity.name|localize_translatable_string }} |
+ {{ entity.name|localize_translatable_string }} |
-
+
|
{% endfor %}
-
+
- {% endblock %}
+{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Scope/new.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Scope/new.html.twig
index 0807e6088..56eb110d0 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/Scope/new.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/Scope/new.html.twig
@@ -1,8 +1,8 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'Circle creation'|trans }}{% endblock %}
-{% block admin_content -%}
+{% block admin_content %}
{{ 'Circle creation'|trans }}
{{ form_start(form) }}
@@ -10,11 +10,11 @@
{{ form_row(form.submit, { 'attr' : { 'class' : 'btn btn-chill-green' } } ) }}
{{ form_end(form) }}
-
+
{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Scope/show.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Scope/show.html.twig
deleted file mode 100644
index 57c573368..000000000
--- a/src/Bundle/ChillMainBundle/Resources/views/Scope/show.html.twig
+++ /dev/null
@@ -1,29 +0,0 @@
-{% extends '@ChillMain/Admin/layout_permissions.html.twig' %}
-
-{% block title %}{{ 'Circle'|trans }}{% endblock %}
-
-{% block admin_content -%}
- {{ 'Circle'|trans }}
-
-
-
-
- {{ 'Name'|trans }} |
- {{ entity.name|localize_translatable_string }} |
-
-
-
-
-
-{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/User/edit.html.twig b/src/Bundle/ChillMainBundle/Resources/views/User/edit.html.twig
index 0ea1d529c..0fa376b34 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/User/edit.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/User/edit.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/Permission/layout_crud_permission_index.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block admin_content -%}
{% embed '@ChillMain/CRUD/_edit_content.html.twig' %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/User/edit_password.html.twig b/src/Bundle/ChillMainBundle/Resources/views/User/edit_password.html.twig
index c26f6cf24..c1972c211 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/User/edit_password.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/User/edit_password.html.twig
@@ -1,4 +1,4 @@
-{% extends '@ChillMain/Admin/Permission/layout_crud_permission_index.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
{% block title %}{{ 'Edit password for %username%'|trans( { '%username%': entity.username } ) }}{% endblock %}
diff --git a/src/Bundle/ChillMainBundle/Resources/views/User/index.html.twig b/src/Bundle/ChillMainBundle/Resources/views/User/index.html.twig
index 83a82f140..46fb7aa29 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/User/index.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/User/index.html.twig
@@ -1,6 +1,6 @@
-{% extends '@ChillMain/Admin/Permission/layout_crud_permission_index.html.twig' %}
+{% extends '@ChillMain/Admin/layoutWithVerticalMenu.html.twig' %}
-{% block admin_content -%}
+{% block admin_content %}
{{"Users"|trans}}
{% for entity in entities %}
@@ -60,6 +60,9 @@
{{ chill_pagination(paginator) }}