From b69aaeafd98c4c00fda7392c2e26ecae44101a4b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Wed, 26 May 2021 23:54:00 +0200
Subject: [PATCH] fix tests for search

---
 .../Tests/Search/PersonSearchTest.php         | 52 +++++++++----------
 1 file changed, 25 insertions(+), 27 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Tests/Search/PersonSearchTest.php b/src/Bundle/ChillPersonBundle/Tests/Search/PersonSearchTest.php
index b2c94b6bc..50037e5de 100644
--- a/src/Bundle/ChillPersonBundle/Tests/Search/PersonSearchTest.php
+++ b/src/Bundle/ChillPersonBundle/Tests/Search/PersonSearchTest.php
@@ -52,75 +52,75 @@ class PersonSearchTest extends WebTestCase
         $this->assertRegExp('/Depardieu/', $crawler->text());
     }
     
-    public function testSearchByFirstName()
+    public function testSearchByLastName()
     {
-        $crawler = $this->generateCrawlerForSearch('@person firstname:Depardieu');
+        $crawler = $this->generateCrawlerForSearch('@person lastname:Depardieu');
         
         $this->assertRegExp('/Depardieu/', $crawler->text());
     }
     
     public function testSearchByFirstNameLower()
     {
-        $crawler = $this->generateCrawlerForSearch('@person firstname:depardieu');
+        $crawler = $this->generateCrawlerForSearch('@person firstname:Gérard');
         
         $this->assertRegExp('/Depardieu/', $crawler->text());
     }
     
     public function testSearchByFirstNamePartim()
     {
-        $crawler = $this->generateCrawlerForSearch('@person firstname:Dep');
+        $crawler = $this->generateCrawlerForSearch('@person firstname:Ger');
         
         $this->assertRegExp('/Depardieu/', $crawler->text());
     }
     
-    public function testFirstNameAccentued()
+    public function testLastNameAccentued()
     {
-        $crawlerSpecial = $this->generateCrawlerForSearch('@person firstname:manço');
+        $crawlerSpecial = $this->generateCrawlerForSearch('@person lastname:manço');
         
         $this->assertRegExp('/Manço/', $crawlerSpecial->text());
         
         
-        $crawlerNoSpecial = $this->generateCrawlerForSearch('@person firstname:manco');
+        $crawlerNoSpecial = $this->generateCrawlerForSearch('@person lastname:manco');
         
         $this->assertRegExp('/Manço/', $crawlerNoSpecial->text());
     }
-    
-    public function testSearchByLastName()
+   
+    public function testSearchByFirstName()
     {
-        $crawler = $this->generateCrawlerForSearch('@person lastname:Jean');
+        $crawler = $this->generateCrawlerForSearch('@person firstname:Jean');
         
         $this->assertRegExp('/Depardieu/', $crawler->text());
     }
     
-    public function testSearchByLastNameLower()
+    public function testSearchByFirstNameLower2()
     {
-        $crawler = $this->generateCrawlerForSearch('@person lastname:jean');
+        $crawler = $this->generateCrawlerForSearch('@person firstname:jean');
         
         $this->assertRegExp('/Depardieu/', $crawler->text());
     }
     
-    public function testSearchByLastNamePartim()
+    public function testSearchByFirstNamePartim2()
     {
-        $crawler = $this->generateCrawlerForSearch('@person lastname:ean');
+        $crawler = $this->generateCrawlerForSearch('@person firstname:ean');
         
         $this->assertRegExp('/Depardieu/', $crawler->text());
     }
     
-    public function testSearchByLastNameAccented()
+    public function testSearchByFirstNameAccented()
     {
-        $crawlerSpecial = $this->generateCrawlerForSearch('@person lastname:Gérard');
+        $crawlerSpecial = $this->generateCrawlerForSearch('@person firstname:Gérard');
         
         $this->assertRegExp('/Gérard/', $crawlerSpecial->text());
         
         
-        $crawlerNoSpecial = $this->generateCrawlerForSearch('@person lastname:Gerard');
+        $crawlerNoSpecial = $this->generateCrawlerForSearch('@person firstname:Gerard');
         
         $this->assertRegExp('/Gérard/', $crawlerNoSpecial->text());
     }
     
-    public function testSearchCombineFirstnameAndNationality()
+    public function testSearchCombineLastnameAndNationality()
     {
-        $crawler = $this->generateCrawlerForSearch('@person firstname:Depardieu nationality:RU');
+        $crawler = $this->generateCrawlerForSearch('@person lastname:Depardieu nationality:RU');
         
         $this->assertRegExp('/Gérard/', $crawler->text());
         //if this is a AND clause, Jean Depardieu should not appears
@@ -130,7 +130,7 @@ class PersonSearchTest extends WebTestCase
     
     public function testSearchCombineLastnameAndFirstName()
     {
-        $crawler = $this->generateCrawlerForSearch('@person firstname:Depardieu lastname:Jean');
+        $crawler = $this->generateCrawlerForSearch('@person lastname:Depardieu firstname:Jean');
         
         $this->assertRegExp('/Depardieu/', $crawler->text());
         //if this is a AND clause, Jean Depardieu should not appears
@@ -146,17 +146,17 @@ class PersonSearchTest extends WebTestCase
         $this->assertRegExp('/Bart/', $crawler->text());
     }
     
-    public function testSearchCombineBirthdateAndFirstName()
+    public function testSearchCombineBirthdateAndLastName()
     {
-        $crawler = $this->generateCrawlerForSearch('@person birthdate:1948-12-27 firstname:(Van Snick)');
+        $crawler = $this->generateCrawlerForSearch('@person birthdate:1948-12-27 lastname:(Van Snick)');
         
         $this->assertRegExp('/Bart/', $crawler->text());
         $this->assertNotRegExp('/Depardieu/', $crawler->text());
     }
     
-    public function testSearchCombineGenderAndFirstName()
+    public function testSearchCombineGenderAndLastName()
     {
-        $crawler = $this->generateCrawlerForSearch('@person gender:woman firstname:(Depardieu)');
+        $crawler = $this->generateCrawlerForSearch('@person gender:woman lastname:(Depardieu)');
         
         $this->assertRegExp('/Charline/', $crawler->text());
         $this->assertNotRegExp('/Gérard/', $crawler->text());
@@ -171,8 +171,6 @@ class PersonSearchTest extends WebTestCase
         $this->assertNotRegExp('/Jean/', $crawler->text());
     }
     
-    
-    
     public function testDefaultAccented()
     {
         $crawlerSpecial = $this->generateCrawlerForSearch('@person manço');
@@ -215,7 +213,7 @@ class PersonSearchTest extends WebTestCase
         $client = $this->getAuthenticatedClient($username);
         
         $crawler = $client->request('GET', '/fr/search', array(
-           'q' => $pattern
+           'q' => $pattern,
         ));
         
         $this->assertTrue($client->getResponse()->isSuccessful());