From ad3ced9683fb98322382b39e49dd158244284a5b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Thu, 12 Mar 2020 12:14:38 +0100
Subject: [PATCH] use Menu api for handling menu

---
 Resources/config/routing.yml                  |  6 --
 Resources/config/services/menu.yml            |  6 ++
 Resources/views/Menu/adminSection.html.twig   | 10 +--
 .../MenuBuilder/AdminSectionMenuBuilder.php   | 62 +++++++++++++++++++
 4 files changed, 74 insertions(+), 10 deletions(-)
 create mode 100644 Routing/MenuBuilder/AdminSectionMenuBuilder.php

diff --git a/Resources/config/routing.yml b/Resources/config/routing.yml
index ee3ca9516..983e5237d 100644
--- a/Resources/config/routing.yml
+++ b/Resources/config/routing.yml
@@ -58,12 +58,6 @@ chill_main_admin_central:
 chill_main_admin_permissions:
     path: /{_locale}/admin/permissions
     defaults: {_controller: ChillMainBundle:Admin:indexPermissions }
-    options:
-        menus:
-            admin_section:
-                order: 200
-                label: Users and permissions
-                icons: [key]
 
 chill_main_search:
     path: /{_locale}/search.{_format}
diff --git a/Resources/config/services/menu.yml b/Resources/config/services/menu.yml
index b56c34d4e..ac331bd5a 100644
--- a/Resources/config/services/menu.yml
+++ b/Resources/config/services/menu.yml
@@ -10,3 +10,9 @@ services:
             $authorizationChecker: '@Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface'
         tags:
             - { name: 'chill.menu_builder' }
+            
+    Chill\MainBundle\Routing\MenuBuilder\AdminSectionMenuBuilder:
+        arguments:
+            $authorizationChecker: '@Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface'
+        tags:
+            - { name: 'chill.menu_builder' }
diff --git a/Resources/views/Menu/adminSection.html.twig b/Resources/views/Menu/adminSection.html.twig
index d93d9d931..5434b4be8 100644
--- a/Resources/views/Menu/adminSection.html.twig
+++ b/Resources/views/Menu/adminSection.html.twig
@@ -21,16 +21,18 @@
         <a href="{{ path('chill_main_admin_central') }}" class="more">Admin Sections</a>
     </div>
     <ul class="submenu width-15-em" style="padding-left: 0; padding-right: 0;  background-color:transparent;">
-        {% for route in routes %}
+        {% for menu in menus %}
             <li style="display:block; background-color: #333333; padding-left:1.5em; border-bottom:1px; border-bottom: 1px solid #FFF;padding-top:0; padding-bottom:0;">
                 <div style="margin-bottom:2px;">
-                        <div style="font-family: 'Open Sans'; font-weight: 300; font-size: 0.75em; text-align:left; height: 46px; display:inline-block;  width: calc(100% - 5em - 1px); vertical-align:top;">
-                            <a href="{{ path(route.key, args ) }}">{{ route.label|trans }}</a>
+                        <div style="font-family: 'Open Sans'; font-weight:300; font-size: 0.75em; text-align:left; height: 46px; display:inline-block;  width: calc(100% - 5em - 1px); vertical-align:top;">
+                            <a href="{{ menu.uri }}">{{ menu.label|trans }}</a>
                         </div>
                         <div style="background-color: #333333;  text-align:center;width: 2em; margin-left:-0.15em; font-size:1.5em; color:#FFF; height: 46px; display:inline-block; vertical-align:top;float:right">{% spaceless %}
-                            {% for icon in route.icons %}
+                            {% if menu.extras.icons is defined %}
+                            {% for icon in menu.extras.icons %}
                                 <i class="fa fa-{{ icon }}"></i> 
                             {% endfor %}
+                            {% endif %}
                         {% endspaceless %}</div>
                 </div>
             </li>
diff --git a/Routing/MenuBuilder/AdminSectionMenuBuilder.php b/Routing/MenuBuilder/AdminSectionMenuBuilder.php
new file mode 100644
index 000000000..96a63ff75
--- /dev/null
+++ b/Routing/MenuBuilder/AdminSectionMenuBuilder.php
@@ -0,0 +1,62 @@
+<?php
+/*
+ * Copyright (C) 2018 Champs Libres Cooperative <info@champs-libres.coop>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+namespace Chill\MainBundle\Routing\MenuBuilder;
+
+use Chill\MainBundle\Routing\LocalMenuBuilderInterface;
+use Knp\Menu\MenuItem;
+use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
+use Chill\MainBundle\Security\Authorization\ChillExportVoter;
+
+/**
+ * 
+ *
+ */
+class AdminSectionMenuBuilder implements LocalMenuBuilderInterface
+{
+    /**
+     *
+     * @var AuthorizationCheckerInterface
+     */
+    protected $authorizationChecker;
+    
+    public function __construct(AuthorizationCheckerInterface $authorizationChecker)
+    {
+        $this->authorizationChecker = $authorizationChecker;
+    }
+    
+    public function buildMenu($menuId, MenuItem $menu, array $parameters)
+    {
+        // all the entries below must have ROLE_ADMIN permissions
+        if (!$this->authorizationChecker->isGranted('ROLE_ADMIN')) {
+            return;
+        }
+        
+        $menu->addChild('Users and permissions', [
+                'route' => 'chill_main_admin_permissions'
+            ])
+            ->setExtras([
+                'icons' => ['key'],
+                'order' => 200
+            ]);
+    }
+
+    public static function getMenuIds(): array
+    {
+        return [ 'admin_section' ];
+    }
+}