From 88362bd284a1c77e8ab00b1a1b0d9625e8d7f386 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 25 Aug 2021 17:46:51 +0200
Subject: [PATCH 1/9] start of updating personrenderbox to display age. only
 one scenario done

---
 .../Resources/public/vuejs/_js/i18n.js        |  3 ++-
 .../_components/Entity/PersonRenderBox.vue    | 22 +++++++++++++++----
 2 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
index 84db72236..9c28c9fdb 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
@@ -76,7 +76,8 @@ const messages = {
          birthday: {
             man: "Né le",
             woman: "Née le"
-         } ,
+         },
+         years_old: "ans",
          no_data: "Aucune information renseignée",
          type: {
             thirdparty: "Tiers",
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
index 464e2190e..0a8a8da9f 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
@@ -27,7 +27,7 @@
 
                 </div>
 
-                <p v-if="this.options.addInfo == true" class="moreinfo">
+                <p v-if="options.addInfo == true" class="moreinfo">
                     <i :class="'fa fa-fw ' + getGenderIcon" title="{{ getGender }}"></i>
                     <time v-if="person.birthdate" datetime="{{ person.birthdate }}" title="{{ birthdate }}">
                         {{ $t(getGender) + ' ' + $d(birthdate, 'text') }}
@@ -35,7 +35,7 @@
                     <time v-else-if="person.deathdate" datetime="{{ person.deathdate }}" title="{{ person.deathdate }}">
                         {{ birthdate }} - {{ deathdate }}
                     </time>
-                    <!-- <span class="age">{{ person.age }}</span> -->
+                    <span v-if="options.addAge" class="age">{{ getAge }} {{ $t('renderbox.years_old')}}</span>
                 </p>
             </div>
         </div>
@@ -114,12 +114,14 @@ export default {
             return this.person.gender == 'woman' ? 'fa-venus' : this.person.gender == 'man' ? 'fa-mars' : 'fa-neuter';
         },
         birthdate: function(){
-            var date = new Date(this.person.birthdate.datetime);
+            const date = new Date(this.person.birthdate.datetime);
             return dateToISO(date);
         },
         deathdate: function(){
-            var date = new Date(this.person.deathdate.datetime);
+            if(this.person.deathdate){
+            const date = new Date(this.person.deathdate.datetime);
             return dateToISO(date);
+            }
         },
         altNameLabel: function(){
             for(let i = 0; i < this.person.altNames.length; i++){
@@ -131,6 +133,12 @@ export default {
                 return this.person.altNames[i].key
             }
         },
+        getAge: function(){
+            if(this.person.birthdate && !this.person.deathdate){
+                const birthday = new Date(this.person.birthdate.datetime)
+                const now = new Date()
+                return (now.getFullYear() - birthday.getFullYear())
+        }
     }
 }
 </script>
@@ -153,6 +161,12 @@ div.flex-table {
       }
    }
 }
+
+.age{
+    margin-left: 0.5em;
+    &:before { content: '('; }
+    &:after { content: ')'; }
+}
 </style>
 
 

From 5194cad354ebb8873d66c362399a8e289f7d35cb Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Thu, 26 Aug 2021 14:53:04 +0200
Subject: [PATCH 2/9] Adaptations for display of age and deathdate (different
 scenarios not all finished)

---
 .../Resources/public/vuejs/_js/i18n.js        |  1 +
 .../_components/Entity/PersonRenderBox.vue    | 23 +++++++++++++++----
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
index 9c28c9fdb..593d76f7d 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
@@ -77,6 +77,7 @@ const messages = {
             man: "Né le",
             woman: "Née le"
          },
+         deathdate: "Date de décès",
          years_old: "ans",
          no_data: "Aucune information renseignée",
          type: {
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
index 0a8a8da9f..f886a3d29 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
@@ -28,12 +28,16 @@
                 </div>
 
                 <p v-if="options.addInfo == true" class="moreinfo">
+                    {{ person.deathdate }}
                     <i :class="'fa fa-fw ' + getGenderIcon" title="{{ getGender }}"></i>
-                    <time v-if="person.birthdate" datetime="{{ person.birthdate }}" title="{{ birthdate }}">
-                        {{ $t(getGender) + ' ' + $d(birthdate, 'text') }}
+                    <time v-if="person.birthdate && !person.deathdate" datetime="{{ person.birthdate }}" title="{{ birthdate }}">
+                        {{ $t(getGenderTranslation) + ' ' + $d(birthdate, 'text') }}
+                    </time>
+                    <time v-else-if="person.birthdate && person.deathdate" datetime="{{ person.deathdate }}" title="{{ person.deathdate }}">
+                        {{ birthdate }} - {{ deathdate }}
                     </time>
                     <time v-else-if="person.deathdate" datetime="{{ person.deathdate }}" title="{{ person.deathdate }}">
-                        {{ birthdate }} - {{ deathdate }}
+                        {{ $t('renderbox.deathdate') + ' ' + deathdate }}
                     </time>
                     <span v-if="options.addAge" class="age">{{ getAge }} {{ $t('renderbox.years_old')}}</span>
                 </p>
@@ -100,7 +104,7 @@ export default {
     },
     props: ['person', 'options'],
     computed: {
-        getGender: function() {
+        getGenderTranslation: function() {
             return this.person.gender == 'woman' ? 'renderbox.birthday.woman' : 'renderbox.birthday.man';
         },
         isMultiline: function() {
@@ -138,6 +142,17 @@ export default {
                 const birthday = new Date(this.person.birthdate.datetime)
                 const now = new Date()
                 return (now.getFullYear() - birthday.getFullYear())
+            } else if(this.person.birthdate && this.person.deathdate){
+                    const birthday = new Date(this.person.birthdate.datetime)
+                    const deathdate = new Date(this.person.deathdate.datetime)
+                    return (deathdate.getFullYear() - birthday.getFullYear())
+            } else if(!this.person.birthdate && this.person.deathdate.datetime) {
+                // todo: change this
+                    return "Age unknown"
+            } else {
+                // todo: change this
+                    return "Age unknown"
+            }
         }
     }
 }

From c5f40c53ea258e8dd982ed43f87816ddb2e71993 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Thu, 26 Aug 2021 16:42:33 +0200
Subject: [PATCH 3/9] further adaptations to display deathdate. deathdate added
 to what API returns

---
 .../PersonsAssociated/ParticipationItem.vue   |   2 +-
 .../_components/Entity/PersonRenderBox.vue    |   9 +-
 .../Normalizer/PersonNormalizer.php           |   2 +
 .../ChillPersonBundle/chill.api.specs.yaml    | 138 ++++++++----------
 4 files changed, 72 insertions(+), 79 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
index 04c6b73a9..704f66be3 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
@@ -6,7 +6,7 @@
                addEntity: false,
                addLink: false,
                addAltNames: true,
-               addAge : false,
+               addAge : true,
                hLevel : 3,
             }"
       :person="participation.person">
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
index f886a3d29..82948a37a 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
@@ -28,7 +28,6 @@
                 </div>
 
                 <p v-if="options.addInfo == true" class="moreinfo">
-                    {{ person.deathdate }}
                     <i :class="'fa fa-fw ' + getGenderIcon" title="{{ getGender }}"></i>
                     <time v-if="person.birthdate && !person.deathdate" datetime="{{ person.birthdate }}" title="{{ birthdate }}">
                         {{ $t(getGenderTranslation) + ' ' + $d(birthdate, 'text') }}
@@ -39,7 +38,7 @@
                     <time v-else-if="person.deathdate" datetime="{{ person.deathdate }}" title="{{ person.deathdate }}">
                         {{ $t('renderbox.deathdate') + ' ' + deathdate }}
                     </time>
-                    <span v-if="options.addAge" class="age">{{ getAge }} {{ $t('renderbox.years_old')}}</span>
+                    <span v-if="options.addAge && person.birthdate" class="age">{{ getAge }} {{ $t('renderbox.years_old')}}</span>
                 </p>
             </div>
         </div>
@@ -118,13 +117,15 @@ export default {
             return this.person.gender == 'woman' ? 'fa-venus' : this.person.gender == 'man' ? 'fa-mars' : 'fa-neuter';
         },
         birthdate: function(){
+            if(this.person.birthdate){
             const date = new Date(this.person.birthdate.datetime);
-            return dateToISO(date);
+            return dateToISO(date)
+            }
         },
         deathdate: function(){
             if(this.person.deathdate){
             const date = new Date(this.person.deathdate.datetime);
-            return dateToISO(date);
+            return date.toLocaleDateString("fr-FR");
             }
         },
         altNameLabel: function(){
diff --git a/src/Bundle/ChillPersonBundle/Serializer/Normalizer/PersonNormalizer.php b/src/Bundle/ChillPersonBundle/Serializer/Normalizer/PersonNormalizer.php
index cde495f52..3dabb43cb 100644
--- a/src/Bundle/ChillPersonBundle/Serializer/Normalizer/PersonNormalizer.php
+++ b/src/Bundle/ChillPersonBundle/Serializer/Normalizer/PersonNormalizer.php
@@ -69,6 +69,7 @@ class PersonNormalizer implements
             'firstName' => $person->getFirstName(),
             'lastName' => $person->getLastName(),
             'birthdate' => $this->normalizer->normalize($person->getBirthdate()),
+            'deathdate' => $this->normalizer->normalize($person->getDeathdate()),
             'center' => $this->normalizer->normalize($person->getCenter()),
             'phonenumber' => $person->getPhonenumber(),
             'mobilenumber' => $person->getMobilenumber(),
@@ -125,6 +126,7 @@ class PersonNormalizer implements
 
         foreach ([
             'birthdate' => \DateTime::class,
+            'deathdate' => \DateTime::class,
             'center' => Center::class
         ] as $item => $class) {
             if (\array_key_exists($item, $data)) {
diff --git a/src/Bundle/ChillPersonBundle/chill.api.specs.yaml b/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
index 1b2c9cd85..020fa409f 100644
--- a/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
+++ b/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
@@ -45,7 +45,7 @@ components:
         type:
           type: string
           enum:
-            - 'person'
+            - "person"
         firstName:
           type: string
         lastName:
@@ -55,7 +55,9 @@ components:
           description: a canonical representation for the person name
           readOnly: true
         birthdate:
-          $ref: '#/components/schemas/Date'
+          $ref: "#/components/schemas/Date"
+        deathdate:
+          $ref: "#/components/schemas/Date"
         phonenumber:
           type: string
         mobilenumber:
@@ -78,7 +80,7 @@ components:
         type:
           type: string
           enum:
-            - 'person'
+            - "person"
       required:
         - id
         - type
@@ -96,7 +98,7 @@ components:
         type:
           type: string
           enum:
-            - 'thirdparty'
+            - "thirdparty"
       required:
         - id
         - type
@@ -119,15 +121,15 @@ components:
         type:
           type: string
           enum:
-            - 'accompanying_period_resource'
+            - "accompanying_period_resource"
           readOnly: true
         id:
           type: integer
           readOnly: true
         resource:
           anyOf:
-            - $ref: '#/components/schemas/PersonById'
-            - $ref: '#/components/schemas/ThirdPartyById'
+            - $ref: "#/components/schemas/PersonById"
+            - $ref: "#/components/schemas/ThirdPartyById"
     ResourceById:
       type: object
       properties:
@@ -136,7 +138,7 @@ components:
         type:
           type: string
           enum:
-            - 'accompanying_period_resource'
+            - "accompanying_period_resource"
       required:
         - id
         - type
@@ -146,7 +148,7 @@ components:
         type:
           type: string
           enum:
-            - 'accompanying_period_comment'
+            - "accompanying_period_comment"
           readOnly: true
         id:
           type: integer
@@ -161,7 +163,7 @@ components:
         type:
           type: string
           enum:
-            - 'accompanying_period_comment'
+            - "accompanying_period_comment"
       required:
         - id
         - type
@@ -173,7 +175,7 @@ components:
         type:
           type: string
           enum:
-            - 'social_issue'
+            - "social_issue"
         parent_id:
           type: integer
           readOnly: true
@@ -195,12 +197,12 @@ components:
     Household:
       type: object
       properties:
-          id:
-            type: integer
-          type:
-            type: string
-            enum:
-              - 'household'
+        id:
+          type: integer
+        type:
+          type: string
+          enum:
+            - "household"
     HouseholdPosition:
       type: object
       properties:
@@ -209,7 +211,7 @@ components:
         type:
           type: string
           enum:
-            - 'household_position'
+            - "household_position"
     AccompanyingCourseWork:
       type: object
       properties:
@@ -218,7 +220,7 @@ components:
         type:
           type: string
           enum:
-            - 'accompanying_period_work'
+            - "accompanying_period_work"
         note:
           type: string
         startDate:
@@ -243,15 +245,15 @@ components:
         type:
           type: string
           enum:
-            - 'accompanying_period_work_goal'
+            - "accompanying_period_work_goal"
         note:
           type: string
         goal:
-          $ref: '#/components/schemas/SocialWorkGoalById'
+          $ref: "#/components/schemas/SocialWorkGoalById"
         results:
           type: array
           items:
-            $ref: '#/components/schemas/SocialWorkGoalById'
+            $ref: "#/components/schemas/SocialWorkGoalById"
 
     SocialWorkResultById:
       type: object
@@ -261,7 +263,7 @@ components:
         type:
           type: string
           enum:
-            - 'social_work_result'
+            - "social_work_result"
     SocialWorkGoalById:
       type: object
       properties:
@@ -270,7 +272,7 @@ components:
         type:
           type: string
           enum:
-            - 'social_work_goal'
+            - "social_work_goal"
 
 paths:
   /1.0/person/person/{id}.json:
@@ -308,7 +310,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/Person'
+              $ref: "#/components/schemas/Person"
       responses:
         200:
           description: "OK"
@@ -355,18 +357,17 @@ paths:
         422:
           description: "Unprocessable entity (validation errors)"
 
-
   /1.0/person/address/suggest/by-person/{id}.json:
     get:
       tags:
         - address
       summary: get a list of suggested address for a person
       description: >
-          The address are computed from various source. Currently:
+        The address are computed from various source. Currently:
 
-          - the address of course to which the person is participating
+        - the address of course to which the person is participating
 
-          The current person's address is always ignored.
+        The current person's address is always ignored.
       parameters:
         - name: id
           in: path
@@ -390,11 +391,11 @@ paths:
         - address
       summary: get a list of suggested address for a household
       description: >
-          The address are computed from various source. Currently:
+        The address are computed from various source. Currently:
 
-          - the address of course to which the members is participating
+        - the address of course to which the members is participating
 
-          The current household address is always ignored.
+        The current household address is always ignored.
       parameters:
         - name: id
           in: path
@@ -452,7 +453,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/AccompanyingPeriod'
+              $ref: "#/components/schemas/AccompanyingPeriod"
             examples:
               Set the requestor as anonymous:
                 value:
@@ -488,7 +489,7 @@ paths:
                   id: 0
                   personLocation: null
                   addressLocation:
-                      id: 7960
+                    id: 7960
       responses:
         401:
           description: "Unauthorized"
@@ -520,8 +521,8 @@ paths:
           application/json:
             schema:
               oneOf:
-                - $ref: '#/components/schemas/PersonById'
-                - $ref: '#/components/schemas/ThirdPartyById'
+                - $ref: "#/components/schemas/PersonById"
+                - $ref: "#/components/schemas/ThirdPartyById"
             examples:
               add person with id 50:
                 summary: "a person with id 50"
@@ -585,7 +586,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/PersonById'
+              $ref: "#/components/schemas/PersonById"
       responses:
         401:
           description: "Unauthorized"
@@ -614,7 +615,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/PersonById'
+              $ref: "#/components/schemas/PersonById"
       responses:
         401:
           description: "Unauthorized"
@@ -645,7 +646,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/Resource'
+              $ref: "#/components/schemas/Resource"
             examples:
               add person with id 50:
                 summary: "a person with id 50"
@@ -690,7 +691,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/ResourceById'
+              $ref: "#/components/schemas/ResourceById"
       responses:
         401:
           description: "Unauthorized"
@@ -721,7 +722,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/Comment'
+              $ref: "#/components/schemas/Comment"
             examples:
               a single comment:
                 summary: "a simple comment"
@@ -759,7 +760,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/CommentById'
+              $ref: "#/components/schemas/CommentById"
       responses:
         401:
           description: "Unauthorized"
@@ -790,7 +791,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/Scope'
+              $ref: "#/components/schemas/Scope"
             examples:
               add a scope:
                 value:
@@ -824,7 +825,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/ScopeById'
+              $ref: "#/components/schemas/ScopeById"
       responses:
         401:
           description: "Unauthorized"
@@ -855,7 +856,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/SocialIssue'
+              $ref: "#/components/schemas/SocialIssue"
             examples:
               add a social issue:
                 value:
@@ -889,7 +890,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/SocialIssue'
+              $ref: "#/components/schemas/SocialIssue"
       responses:
         401:
           description: "Unauthorized"
@@ -926,11 +927,11 @@ paths:
                 type:
                   type: string
                   enum:
-                    - 'accompanying_period_work'
+                    - "accompanying_period_work"
                 startDate:
-                  $ref: '#/components/schemas/Date'
+                  $ref: "#/components/schemas/Date"
                 endDate:
-                  $ref: '#/components/schemas/Date'
+                  $ref: "#/components/schemas/Date"
             examples:
               create a work:
                 value:
@@ -992,7 +993,7 @@ paths:
         content:
           application/json:
             schema:
-              $ref: '#/components/schemas/AccompanyingCourseWork'
+              $ref: "#/components/schemas/AccompanyingCourseWork"
       responses:
         401:
           description: "Unauthorized"
@@ -1029,8 +1030,6 @@ paths:
         400:
           description: "transition cannot be applyed"
 
-
-
   /1.0/person/accompanying-period/origin.json:
     get:
       tags:
@@ -1064,8 +1063,6 @@ paths:
         404:
           description: "Not found"
 
-
-
   /1.0/person/household.json:
     get:
       tags:
@@ -1095,7 +1092,7 @@ paths:
           content:
             application/json:
               schema:
-                $ref: '#/components/schemas/Household'
+                $ref: "#/components/schemas/Household"
         404:
           description: "not found"
         401:
@@ -1107,9 +1104,9 @@ paths:
         - household
       summary: Return households associated with the given person through accompanying periods
       description: |
-          Return households associated with the given person throught accompanying periods participation.
+        Return households associated with the given person throught accompanying periods participation.
 
-          The current household of the given person is excluded.
+        The current household of the given person is excluded.
       parameters:
         - name: person_id
           in: path
@@ -1125,7 +1122,7 @@ paths:
           content:
             application/json:
               schema:
-                $ref: '#/components/schemas/Household'
+                $ref: "#/components/schemas/Household"
         404:
           description: "not found"
         401:
@@ -1149,23 +1146,22 @@ paths:
                     type: object
                     properties:
                       person:
-                        $ref: '#/components/schemas/PersonById'
+                        $ref: "#/components/schemas/PersonById"
                       start_date:
-                        $ref: '#/components/schemas/Date'
+                        $ref: "#/components/schemas/Date"
                       position:
-                        $ref: '#/components/schemas/HouseholdPosition'
+                        $ref: "#/components/schemas/HouseholdPosition"
                       holder:
                         type: boolean
                       comment:
                         type: string
                 destination:
-                  $ref: '#/components/schemas/Household'
+                  $ref: "#/components/schemas/Household"
             examples:
               Moving person to a new household:
                 value:
                   concerned:
-                    -
-                      person:
+                    - person:
                         id: 0
                         type: person
                       position:
@@ -1180,8 +1176,7 @@ paths:
               Moving person to a new household and set an address to this household:
                 value:
                   concerned:
-                    -
-                      person:
+                    - person:
                         id: 0
                         type: person
                       position:
@@ -1198,8 +1193,7 @@ paths:
               Moving person to an existing household:
                 value:
                   concerned:
-                    -
-                      person:
+                    - person:
                         id: 0
                         type: person
                       position:
@@ -1215,8 +1209,7 @@ paths:
               Removing a person from any household:
                 value:
                   concerned:
-                    -
-                      person:
+                    - person:
                         id: 0
                         type: person
                       start_date:
@@ -1270,8 +1263,6 @@ paths:
         400:
           description: "transition cannot be applyed"
 
-
-
   /1.0/person/social/social-action.json:
     get:
       tags:
@@ -1349,7 +1340,6 @@ paths:
         404:
           description: not found
 
-
   /1.0/person/social-work/social-issue.json:
     get:
       tags:
@@ -1379,7 +1369,7 @@ paths:
           content:
             application/json:
               schema:
-                $ref: '#/components/schemas/SocialIssue'
+                $ref: "#/components/schemas/SocialIssue"
         404:
           description: "not found"
         401:

From 8182e35c9c424475bb1e0218764d48677d3e51a1 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Fri, 27 Aug 2021 15:13:21 +0200
Subject: [PATCH 4/9] renderbox options changed to not display age for
 thirdparties, but yes in person modal

---
 .../public/vuejs/AccompanyingCourse/components/Requestor.vue    | 2 +-
 .../AccompanyingCourse/components/Resources/ResourceItem.vue    | 2 +-
 .../Resources/public/vuejs/_components/OnTheFly/Person.vue      | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
index 1cb96bc69..6097d6d46 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
@@ -16,7 +16,7 @@
             addLink: false,
             addId: false,
             addEntity: true,
-            addInfo: true,
+            addInfo: false,
             hLevel: 3,
             isMultiline: true
             }"
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
index d37a4b84f..a1e2b3b10 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
@@ -17,7 +17,7 @@
    <third-party-render-box
       v-if="resource.resource.type === 'thirdparty'"
       :thirdparty="resource.resource"
-      :options="{ addLink : false, addId : false, addEntity: true, addInfo: true, hLevel: 3 }"
+      :options="{ addLink : false, addId : false, addEntity: true, addInfo: false, hLevel: 3 }"
       >
       <template v-slot:record-actions>
          <ul class="record_actions">
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
index 84c5e1a57..ebc6db5dd 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
@@ -7,6 +7,7 @@
             addInfo: true,
             addEntity: false,
             addAltNames: true,
+            addAge: true,
             addId: true,
             addLink: false,
             hLevel: 3,

From f41997e6da595d60dd8f1cc68501a552545f8756 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 1 Sep 2021 14:33:31 +0200
Subject: [PATCH 5/9] creation api endpoint. Route found, but ajax call still
 needs to be tested

---
 .../ChillThirdPartyExtension.php              | 28 ++++++++++++-
 .../Entity/ThirdParty.php                     |  5 +++
 .../chill.api.specs.yaml                      | 41 +++++++++++++++++++
 3 files changed, 72 insertions(+), 2 deletions(-)
 create mode 100644 src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml

diff --git a/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php b/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
index 7ada8db8e..fb3770f02 100644
--- a/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
+++ b/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
@@ -8,6 +8,7 @@ use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 use Symfony\Component\DependencyInjection\Loader;
 use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
 use Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter;
+use Symfony\Component\HttpFoundation\Request;
 
 /**
  * This is the class that loads and manages your bundle configuration.
@@ -47,11 +48,34 @@ class ChillThirdPartyExtension extends Extension implements PrependExtensionInte
     {
         //declare routes for 3party bundle
         $container->prependExtensionConfig('chill_main', array(
-           'routing' => array(
+           'routing' => [
               'resources' => array(
                  '@ChillThirdPartyBundle/config/routes.yaml'
               )
-           )
+              ],
+            'apis' => [
+                [
+                    'class' => \Chill\ThirdPartyBundle\Entity\ThirdParty::class,
+                    'name' => 'thirdparty',
+                    'base_path' => '/api/1.0/thirdparty/thirdparty',
+                    'base_role' => \Chill\ThirdPartyBundle\Security\Authorization\ThirdPartyVoter::class,
+                    'actions' => [
+                        '_entity' => [
+                            'methods' => [
+                                Request::METHOD_GET => true,
+                                Request::METHOD_HEAD => true,
+                                Request::METHOD_POST=> true,
+                            ],
+                            'roles' => [
+                                Request::METHOD_GET => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::SHOW,
+                                Request::METHOD_HEAD => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::SHOW,
+                                Request::METHOD_POST => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE,
+
+                            ],
+                        ]
+                    ]
+                ]
+            ],
         ));
     }
     
diff --git a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
index 277202324..45a446443 100644
--- a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
+++ b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
@@ -30,6 +30,7 @@ use Chill\MainBundle\Entity\Center;
 use Symfony\Component\Validator\Constraints as Assert;
 use Chill\MainBundle\Entity\Address;
 use Symfony\Component\Serializer\Annotation\DiscriminatorMap;
+use Symfony\Component\Serializer\Annotation\Groups;
 
 /**
  * ThirdParty is a party recorded in the database.
@@ -59,6 +60,7 @@ class ThirdParty
      * @var string
      * @ORM\Column(name="name", type="string", length=255)
      * @Assert\Length(min="2")
+     * @Groups({"read", "write"})
      */
     private $name;
 
@@ -128,6 +130,7 @@ class ThirdParty
      * @Assert\Regex("/^([\+{1}])([0-9\s*]{4,20})$/",
      *   message="Invalid phone number: it should begin with the international prefix starting with ""+"", hold only digits and be smaller than 20 characters. Ex: +33123456789"
      * )
+     * @Groups({"read", "write"})
      */
     private $telephone;
 
@@ -135,6 +138,7 @@ class ThirdParty
      * @var string|null
      * @ORM\Column(name="email", type="string", length=255, nullable=true)
      * @Assert\Email(checkMX=false)
+     * @Groups({"read", "write"})
      */
     private $email;
 
@@ -143,6 +147,7 @@ class ThirdParty
      * @ORM\ManyToOne(targetEntity="\Chill\MainBundle\Entity\Address",
      *   cascade={"persist", "remove"})
      * @ORM\JoinColumn(nullable=true, onDelete="SET NULL")
+     * @Groups({"read", "write"})
      */
     private $address;
 
diff --git a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
new file mode 100644
index 000000000..32b23a747
--- /dev/null
+++ b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
@@ -0,0 +1,41 @@
+---
+openapi: "3.0.0"
+info:
+  version: "1.0.0"
+  title: "Chill api"
+  description: "Api documentation for chill. Currently, work in progress"
+servers:
+  - url: "/api"
+    description: "Your current dev server"
+
+paths:
+  /1.0/thirdparty/thirdparty.json:
+    get:
+      tags:
+        - thirdparty
+      summary: Return a list of all thirdparty items
+      responses:
+        200:
+          description: "ok"
+
+  /1.0/thirdparty/thirdparty/{id}.json:
+    get:
+      tags:
+        - thirdparty
+      summary: Return a thirdparty item by id
+      parameters:
+        - name: id
+          in: path
+          required: true
+          description: The thirdparty id
+          schema:
+            type: integer
+            format: integer
+            minimum: 1
+      responses:
+        200:
+          description: "ok"
+        404:
+          description: "not found"
+        401:
+          description: "Unauthorized"

From 9961c38b3ce1a2c6f5bd204fd9b7e6019f1ab451 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 1 Sep 2021 14:36:18 +0200
Subject: [PATCH 6/9] thirdparty onthefly, still with hardcoded data

---
 .../vuejs/_components/OnTheFly/ThirdParty.vue | 71 ++++++++++++++++---
 1 file changed, 63 insertions(+), 8 deletions(-)

diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index b8dced534..a681952a7 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -1,23 +1,78 @@
 <template>
-   <div v-if="action === 'show'">
-      show
-      thirdparty
-      {{ id }}
+  <div v-if="action === 'show'">
+      <div class="flex-table">
+         <third-party-render-box
+            :thirdparty="thirdparty"
+            :options="{
+               addInfo: true,
+               addEntity: false,
+               addAltNames: true,
+               addId: true,
+               addLink: false,
+               hLevel: 3,
+               addCenter: true,
+               addNoData: true,
+               isMultiline: true
+            }"
+         ></third-party-render-box>
+      </div>
    </div>
    <div v-else-if="action === 'edit' || action === 'create'">
-      {{ action }}
-      thirdparty 
-      {{ id }}
+      <div class="form-floating mb-3">
+         <input class="form-control form-control-lg" id="firstname" v-model="thirdparty.firstName" v-bind:placeholder="$t('thirdparty.firstname')" />
+         <label for="firstname">{{ $t('thirdparty.firstname') }}</label>
+      </div>
+
+      <div class="form-floating mb-3">
+         <input class="form-control form-control-lg" id="lastname" v-model="thirdparty.lastName" v-bind:placeholder="$t('thirdparty.lastname')" />
+         <label for="lastname">{{ $t('thirdparty.lastname') }}</label>
+      </div>
+
+      <div class="input-group mb-3">
+         <span class="input-group-text" id="email"><i class="fa fa-fw fa-envelope"></i></span>
+         <input class="form-control form-control-lg"
+            v-model="thirdparty.email"
+            v-bind:placeholder="$t('thirdparty.email')"
+            v-bind:aria-label="$t('thirdparty.email')"
+            aria-describedby="email" />
+      </div>
+
+      <div class="input-group mb-3">
+         <span class="input-group-text" id="phonenumber"><i class="fa fa-fw fa-phone"></i></span>
+         <input class="form-control form-control-lg"
+            v-model="thirdparty.telephone"
+            v-bind:placeholder="$t('thirdparty.phonenumber')"
+            v-bind:aria-label="$t('thirdparty.phonenumber')"
+            aria-describedby="phonenumber" />
+      </div>
+
    </div>
 </template>
 
 <script>
+import ThirdPartyRenderBox from '../Entity/ThirdPartyRenderBox.vue'
+
 export default {
    name: "OnTheFlyThirdParty",
-   props: ['id', 'type', 'action']
+   props: ['id', 'type', 'action'],
+   components: {
+      ThirdPartyRenderBox,
+   },
+   data: function() {
+      return {
+         thirdparty: {
+            text : "Bart Maes",
+            firstName : "Bart",
+            lastName : "Maes",
+            email : "bartmaes@gmail.com",
+            telephone : "0475 94 66 15",
+         }
+      }
+   }
 }
 // TODO move in ChillThirdpartyAssets
 </script>
 
 <style lang="css" scoped>
 </style>
+

From 19a4542e2b38fc11b494f038216d63bc72b5e4cc Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 1 Sep 2021 17:34:30 +0200
Subject: [PATCH 7/9] creation of API endpoint thirdparty

---
 .../DependencyInjection/ChillThirdPartyExtension.php     | 9 +++++++++
 src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php   | 8 ++++----
 .../Serializer/Normalizer/ThirdPartyNormalizer.php       | 2 ++
 src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml    | 2 ++
 4 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php b/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
index fb3770f02..0331e007d 100644
--- a/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
+++ b/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
@@ -10,6 +10,7 @@ use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
 use Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter;
 use Symfony\Component\HttpFoundation\Request;
 
+
 /**
  * This is the class that loads and manages your bundle configuration.
  *
@@ -59,7 +60,15 @@ class ChillThirdPartyExtension extends Extension implements PrependExtensionInte
                     'name' => 'thirdparty',
                     'base_path' => '/api/1.0/thirdparty/thirdparty',
                     'base_role' => \Chill\ThirdPartyBundle\Security\Authorization\ThirdPartyVoter::class,
+                    'controller' => \Chill\ThirdPartyBundle\Controller\ThirdPartyApiController::class,
                     'actions' => [
+                        '_index' => [
+                            'methods' => [
+                                Request::METHOD_GET => true,
+                                Request::METHOD_HEAD => true,
+                                Request::METHOD_POST => true,
+                            ],
+                        ],
                         '_entity' => [
                             'methods' => [
                                 Request::METHOD_GET => true,
diff --git a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
index 45a446443..75da7ad78 100644
--- a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
+++ b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
@@ -60,7 +60,7 @@ class ThirdParty
      * @var string
      * @ORM\Column(name="name", type="string", length=255)
      * @Assert\Length(min="2")
-     * @Groups({"read", "write"})
+     * @Groups({"read"})
      */
     private $name;
 
@@ -130,7 +130,7 @@ class ThirdParty
      * @Assert\Regex("/^([\+{1}])([0-9\s*]{4,20})$/",
      *   message="Invalid phone number: it should begin with the international prefix starting with ""+"", hold only digits and be smaller than 20 characters. Ex: +33123456789"
      * )
-     * @Groups({"read", "write"})
+     * @Groups({"read"})
      */
     private $telephone;
 
@@ -138,7 +138,7 @@ class ThirdParty
      * @var string|null
      * @ORM\Column(name="email", type="string", length=255, nullable=true)
      * @Assert\Email(checkMX=false)
-     * @Groups({"read", "write"})
+     * @Groups({"read"})
      */
     private $email;
 
@@ -147,7 +147,7 @@ class ThirdParty
      * @ORM\ManyToOne(targetEntity="\Chill\MainBundle\Entity\Address",
      *   cascade={"persist", "remove"})
      * @ORM\JoinColumn(nullable=true, onDelete="SET NULL")
-     * @Groups({"read", "write"})
+     * @Groups({"read"})
      */
     private $address;
 
diff --git a/src/Bundle/ChillThirdPartyBundle/Serializer/Normalizer/ThirdPartyNormalizer.php b/src/Bundle/ChillThirdPartyBundle/Serializer/Normalizer/ThirdPartyNormalizer.php
index 203331cb7..b8c3e2827 100644
--- a/src/Bundle/ChillThirdPartyBundle/Serializer/Normalizer/ThirdPartyNormalizer.php
+++ b/src/Bundle/ChillThirdPartyBundle/Serializer/Normalizer/ThirdPartyNormalizer.php
@@ -21,6 +21,8 @@ class ThirdPartyNormalizer implements NormalizerInterface, NormalizerAwareInterf
         $data['id'] = $thirdParty->getId();
         $data['address'] = $this->normalizer->normalize($thirdParty->getAddress(), $format,
             [ 'address_rendering' => 'short' ]);
+        $data['phonenumber'] = $thirdParty->getTelephone();
+        $data['email'] = $thirdParty->getEmail();
 
         return $data;
     }
diff --git a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
index 32b23a747..957bf9324 100644
--- a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
+++ b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
@@ -17,6 +17,8 @@ paths:
       responses:
         200:
           description: "ok"
+        401:
+          description: "Unauthorized"
 
   /1.0/thirdparty/thirdparty/{id}.json:
     get:

From 820def6294073f09bfd7b49ad49787d0935ed9ca Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 1 Sep 2021 17:35:11 +0200
Subject: [PATCH 8/9] make onTheFly with API call

---
 .../Resources/public/vuejs/_api/OnTheFly.js   | 36 ++++++++++++++
 .../Entity/ThirdPartyRenderBox.vue            |  6 +--
 .../vuejs/_components/OnTheFly/ThirdParty.vue | 49 +++++++++++++++----
 3 files changed, 79 insertions(+), 12 deletions(-)
 create mode 100644 src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_api/OnTheFly.js

diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_api/OnTheFly.js b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_api/OnTheFly.js
new file mode 100644
index 000000000..ed91ef415
--- /dev/null
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_api/OnTheFly.js
@@ -0,0 +1,36 @@
+/*
+* GET a thirdparty by id
+*/
+const getThirdparty = (id) => {
+   const url = `/api/1.0/thirdparty/thirdparty/${id}.json`;
+   return fetch(url)
+      .then(response => {
+         if (response.ok) { 
+             return response.json(); 
+            }
+         throw Error('Error with request resource response');
+      });
+};
+
+/*
+* POST a new person
+*/
+const postThirdparty = (body) => {
+   const url = `/api/1.0/thirdparty/thirdparty.json`;
+   return fetch(url, {
+         method: 'POST',
+         headers: {
+           'Content-Type': 'application/json;charset=utf-8'
+         },
+         body: JSON.stringify(body)
+      })
+      .then(response => {
+         if (response.ok) { return response.json(); }
+         throw Error('Error with request resource response');
+      });
+};
+   
+export { 
+   getThirdparty, 
+   postThirdparty 
+};
\ No newline at end of file
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
index 7f21e3379..a5142b9e6 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
@@ -26,7 +26,7 @@
                     <time v-else-if="thirdparty.deathdate" datetime="{{ thirdparty.deathdate.datetime }}" title="{{ thirdparty.deathdate }}">
                         {{ birthdate }} - {{ deathdate }}
                     </time>
-                    <span class="age">{{ thirdparty.age }}</span>
+                    <span v-if="options.addAge == true" class="age">{{ thirdparty.age }}</span>
                 </p>
             </div>
         </div>
@@ -37,9 +37,9 @@
                     <i class="fa fa-li fa-map-marker"></i>
                     <show-address :address="thirdparty.address" :isMultiline="isMultiline"></show-address>
                 </li>
-                <li v-if="thirdparty.telephone">
+                <li v-if="thirdparty.phonenumber">
                     <i class="fa fa-li fa-mobile"></i>
-                    <a :href="'tel: ' + thirdparty.telephone">{{ thirdparty.telephone }}</a>
+                    <a :href="'tel: ' + thirdparty.phonenumber">{{ thirdparty.phonenumber }}</a>
                 </li>
                 <li v-if="thirdparty.email">
                     <i class="fa fa-li fa-envelope-o"></i>
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index a681952a7..b23121c56 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -9,6 +9,7 @@
                addAltNames: true,
                addId: true,
                addLink: false,
+               addAge: false,
                hLevel: 3,
                addCenter: true,
                addNoData: true,
@@ -40,7 +41,7 @@
       <div class="input-group mb-3">
          <span class="input-group-text" id="phonenumber"><i class="fa fa-fw fa-phone"></i></span>
          <input class="form-control form-control-lg"
-            v-model="thirdparty.telephone"
+            v-model="thirdparty.phonenumber"
             v-bind:placeholder="$t('thirdparty.phonenumber')"
             v-bind:aria-label="$t('thirdparty.phonenumber')"
             aria-describedby="phonenumber" />
@@ -50,7 +51,8 @@
 </template>
 
 <script>
-import ThirdPartyRenderBox from '../Entity/ThirdPartyRenderBox.vue'
+import ThirdPartyRenderBox from '../Entity/ThirdPartyRenderBox.vue';
+import { getThirdparty, postThirdparty } from '../../_api/OnTheFly';
 
 export default {
    name: "OnTheFlyThirdParty",
@@ -61,18 +63,47 @@ export default {
    data: function() {
       return {
          thirdparty: {
-            text : "Bart Maes",
-            firstName : "Bart",
-            lastName : "Maes",
-            email : "bartmaes@gmail.com",
-            telephone : "0475 94 66 15",
+            type: 'thirdparty'
          }
       }
-   }
+   },
+   methods: {
+      loadThirdparty(){
+         getThirdparty(this.id).then(thirdparty => new Promise((resolve, reject) => {
+            this.thirdparty = thirdparty;
+            resolve();
+         }));
+      },
+      postData() {
+         postThirdparty(this.thirdparty).then(thirdparty => new Promise((resolve, reject) => {
+            this.thirdparty = thirdparty;
+            resolve();
+         }))
+      }
+   },
+   mounted() {
+      if (this.action !== 'create'){
+         this.loadThirdparty();
+      }
+   },
 }
 // TODO move in ChillThirdpartyAssets
 </script>
 
-<style lang="css" scoped>
+<style lang="scss" scoped>
+div.flex-table {
+   div.item-bloc {
+      div.item-row {
+         div.item-col:last-child {
+            justify-content: flex-start;
+         }
+      }
+   }
+}
+dl {
+   dd {
+      margin-left: 1em;
+   }
+}
 </style>
 

From 903d57ea9dfc1b349dda7cdd9b62fb48b7a43bee Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 1 Sep 2021 17:36:17 +0200
Subject: [PATCH 9/9] person_renderbox fix if there is no birthdate

---
 .../public/vuejs/_components/Entity/PersonRenderBox.vue   | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
index 82948a37a..38039501d 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
@@ -117,15 +117,19 @@ export default {
             return this.person.gender == 'woman' ? 'fa-venus' : this.person.gender == 'man' ? 'fa-mars' : 'fa-neuter';
         },
         birthdate: function(){
-            if(this.person.birthdate){
+            if(this.person.birthdate !== null){
             const date = new Date(this.person.birthdate.datetime);
             return dateToISO(date)
+            } else {
+                return "";
             }
         },
         deathdate: function(){
-            if(this.person.deathdate){
+            if(this.person.deathdate !== null){
             const date = new Date(this.person.deathdate.datetime);
             return date.toLocaleDateString("fr-FR");
+            } else {
+                return "";
             }
         },
         altNameLabel: function(){