From a17c22c74fa9f51f292668d42562715994df3b50 Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Tue, 16 Nov 2021 15:27:46 +0100 Subject: [PATCH] fix: SA: Fix "...does not call parent constructor...." rule. SA stands for Static Analysis. --- phpstan-baseline.neon | 5 ----- src/Bundle/ChillTaskBundle/Entity/AbstractTask.php | 5 ----- src/Bundle/ChillTaskBundle/Entity/SingleTask.php | 5 ++--- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 40b6b2425..eaa4dc3b2 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -125,11 +125,6 @@ parameters: count: 1 path: src/Bundle/ChillPersonBundle/Repository/SocialWork/ResultRepository.php - - - message: "#^Chill\\\\TaskBundle\\\\Entity\\\\RecurringTask\\:\\:__construct\\(\\) does not call parent constructor from Chill\\\\TaskBundle\\\\Entity\\\\AbstractTask\\.$#" - count: 1 - path: src/Bundle/ChillTaskBundle/Entity/RecurringTask.php - - message: "#^Foreach overwrites \\$value with its value variable\\.$#" count: 1 diff --git a/src/Bundle/ChillTaskBundle/Entity/AbstractTask.php b/src/Bundle/ChillTaskBundle/Entity/AbstractTask.php index d34a0b05f..c4b76736e 100644 --- a/src/Bundle/ChillTaskBundle/Entity/AbstractTask.php +++ b/src/Bundle/ChillTaskBundle/Entity/AbstractTask.php @@ -90,11 +90,6 @@ abstract class AbstractTask implements HasScopeInterface, HasCenterInterface */ private $closed = false; - public function __construct() - { - - } - /** * Set type * diff --git a/src/Bundle/ChillTaskBundle/Entity/SingleTask.php b/src/Bundle/ChillTaskBundle/Entity/SingleTask.php index cef59a10a..579143718 100644 --- a/src/Bundle/ChillTaskBundle/Entity/SingleTask.php +++ b/src/Bundle/ChillTaskBundle/Entity/SingleTask.php @@ -2,6 +2,7 @@ namespace Chill\TaskBundle\Entity; +use Doctrine\Common\Collections\ArrayCollection; use Doctrine\ORM\Mapping as ORM; use Symfony\Component\Validator\Constraints as Assert; use Doctrine\Common\Collections\Collection; @@ -103,9 +104,7 @@ class SingleTask extends AbstractTask public function __construct() { - $this->taskPlaceEvents = $events = new \Doctrine\Common\Collections\ArrayCollection; - - parent::__construct(); + $this->taskPlaceEvents = new ArrayCollection(); }