From ef2ab5faf62ab60c3c1bd370548ebd19c186995a Mon Sep 17 00:00:00 2001 From: Mathieu Jaumotte Date: Fri, 11 Feb 2022 12:12:12 +0100 Subject: [PATCH 1/2] vue pick entity: improve picked condition when value is empty string --- .../Resources/public/module/pick-entity/index.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Bundle/ChillMainBundle/Resources/public/module/pick-entity/index.js b/src/Bundle/ChillMainBundle/Resources/public/module/pick-entity/index.js index 4cc917502..f184bf100 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/module/pick-entity/index.js +++ b/src/Bundle/ChillMainBundle/Resources/public/module/pick-entity/index.js @@ -17,7 +17,12 @@ function loadDynamicPicker(element) { isMultiple = parseInt(el.dataset.multiple) === 1, uniqId = el.dataset.uniqid, input = element.querySelector('[data-input-uniqid="'+ el.dataset.uniqid +'"]'), - picked = (isMultiple) ? (JSON.parse(input.value)) : ((input.value === '[]') ? (null) : ([JSON.parse(input.value)])); + picked = isMultiple ? + JSON.parse(input.value) : ( + (input.value === '[]' || input.value === '') ? + null : [ JSON.parse(input.value) ] + ) + ; if (!isMultiple) { if (input.value === '[]'){ From 28c4d6b92fe6fee7301c713430d6cb4aaa3d94b1 Mon Sep 17 00:00:00 2001 From: Mathieu Jaumotte Date: Fri, 11 Feb 2022 12:13:05 +0100 Subject: [PATCH 2/2] vue pick entity: fix i18n translations in create thirdparty modal --- CHANGELOG.md | 1 + .../Resources/public/vuejs/PickEntity/i18n.js | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 570bb2c0a..84dc079a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ and this project adheres to * change order for accompanying course work list * [person]: style fix in parcours listing per person. (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/432) +* [pick entity]: fix translations in modal (https://gitlab.com/champs-libres/departement-de-la-vendee/accent-suivi-developpement/-/issues/419) ## Test releases diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/PickEntity/i18n.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/PickEntity/i18n.js index 2c4432218..f3ae3a928 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/PickEntity/i18n.js +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/PickEntity/i18n.js @@ -1,4 +1,7 @@ import { personMessages } from 'ChillPersonAssets/vuejs/_js/i18n'; +import { thirdpartyMessages } from 'ChillThirdPartyAssets/vuejs/_js/i18n'; +import { addressMessages } from 'ChillMainAssets/vuejs/Address/i18n'; +import { ontheflyMessages } from 'ChillMainAssets/vuejs/OnTheFly/i18n'; const appMessages = { fr: { @@ -12,6 +15,6 @@ const appMessages = { } } -Object.assign(appMessages.fr, personMessages.fr); +Object.assign(appMessages.fr, personMessages.fr, thirdpartyMessages.fr, addressMessages.fr, ontheflyMessages.fr ); export { appMessages };