From 9789c794025aa30e5b6e5001b53dfed6dd9406ea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Wed, 27 Apr 2022 14:46:43 +0200
Subject: [PATCH] use strict type comparison and replace use of
 BadRequestException by BadRequestHttpException

---
 .../Controller/HouseholdMemberController.php                 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Controller/HouseholdMemberController.php b/src/Bundle/ChillPersonBundle/Controller/HouseholdMemberController.php
index a595eb8c7..cacba0630 100644
--- a/src/Bundle/ChillPersonBundle/Controller/HouseholdMemberController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/HouseholdMemberController.php
@@ -121,7 +121,8 @@ class HouseholdMemberController extends ApiController
             }
         }
 
-        if ($householdId = $request->query->get('household', false)) {
+        if ($request->query->has('household')) {
+            $householdId = $request->query->get('household', false);
             $household = $em->getRepository(Household::class)
                 ->find($householdId);
             $allowHouseholdCreate = false;
@@ -189,7 +190,7 @@ class HouseholdMemberController extends ApiController
                     ['groups' => ['read']]
                 );
         } catch (Exception\InvalidArgumentException|Exception\UnexpectedValueException $e) {
-            throw new BadRequestException("Deserialization error: {$e->getMessage()}", 45896, $e);
+            throw new BadRequestHttpException("Deserialization error: {$e->getMessage()}", 45896, $e);
         }
 
         // TODO ACL