From 82ca32171570692f115bbc797bf6d58f0aa72b2e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Mon, 11 Dec 2023 22:47:15 +0100
Subject: [PATCH] Add exceptions for async file handling failures

Introduced two new exceptions, `BadCallToRemoteServer` and `TempUrlRemoteServerException`, to improve error handling in asynchronous file operations. These exceptions are thrown when there are issues with the remote server during an async file operation such as HTTP status codes >= 400 and if the server is unreachable.
---
 .../Exception/BadCallToRemoteServer.php       | 20 +++++++++++++++++++
 .../TempUrlRemoteServerException.php          | 20 +++++++++++++++++++
 .../Constraints/AsyncFileExistsValidator.php  | 11 +++++++++-
 3 files changed, 50 insertions(+), 1 deletion(-)
 create mode 100644 src/Bundle/ChillDocStoreBundle/AsyncUpload/Exception/BadCallToRemoteServer.php
 create mode 100644 src/Bundle/ChillDocStoreBundle/AsyncUpload/Exception/TempUrlRemoteServerException.php

diff --git a/src/Bundle/ChillDocStoreBundle/AsyncUpload/Exception/BadCallToRemoteServer.php b/src/Bundle/ChillDocStoreBundle/AsyncUpload/Exception/BadCallToRemoteServer.php
new file mode 100644
index 000000000..58ddfe0b0
--- /dev/null
+++ b/src/Bundle/ChillDocStoreBundle/AsyncUpload/Exception/BadCallToRemoteServer.php
@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\DocStoreBundle\AsyncUpload\Exception;
+
+class BadCallToRemoteServer extends \LogicException
+{
+    public function __construct(string $content, int $statusCode, int $code = 0, \Throwable $previous = null)
+    {
+        parent::__construct("Bad call to remote server: {$statusCode}, {$content}", $code, $previous);
+    }
+}
diff --git a/src/Bundle/ChillDocStoreBundle/AsyncUpload/Exception/TempUrlRemoteServerException.php b/src/Bundle/ChillDocStoreBundle/AsyncUpload/Exception/TempUrlRemoteServerException.php
new file mode 100644
index 000000000..5e82e63f7
--- /dev/null
+++ b/src/Bundle/ChillDocStoreBundle/AsyncUpload/Exception/TempUrlRemoteServerException.php
@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\DocStoreBundle\AsyncUpload\Exception;
+
+class TempUrlRemoteServerException extends \RuntimeException
+{
+    public function __construct(int $statusCode, int $code = 0, \Throwable $previous = null)
+    {
+        parent::__construct('Could not reach remote server: '.(string) $statusCode, $code, $previous);
+    }
+}
diff --git a/src/Bundle/ChillDocStoreBundle/Validator/Constraints/AsyncFileExistsValidator.php b/src/Bundle/ChillDocStoreBundle/Validator/Constraints/AsyncFileExistsValidator.php
index f9b64222f..e5ccd2fdf 100644
--- a/src/Bundle/ChillDocStoreBundle/Validator/Constraints/AsyncFileExistsValidator.php
+++ b/src/Bundle/ChillDocStoreBundle/Validator/Constraints/AsyncFileExistsValidator.php
@@ -11,6 +11,8 @@ declare(strict_types=1);
 
 namespace Chill\DocStoreBundle\Validator\Constraints;
 
+use Chill\DocStoreBundle\AsyncUpload\Exception\BadCallToRemoteServer;
+use Chill\DocStoreBundle\AsyncUpload\Exception\TempUrlRemoteServerException;
 use Chill\DocStoreBundle\AsyncUpload\TempUrlGeneratorInterface;
 use Chill\DocStoreBundle\Entity\StoredObject;
 use Symfony\Component\Validator\Constraint;
@@ -18,6 +20,7 @@ use Symfony\Component\Validator\ConstraintValidator;
 use Symfony\Component\Validator\Exception\UnexpectedTypeException;
 use Symfony\Component\Validator\Exception\UnexpectedValueException;
 use Symfony\Contracts\HttpClient\Exception\HttpExceptionInterface;
+use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
 final class AsyncFileExistsValidator extends ConstraintValidator
@@ -53,15 +56,21 @@ final class AsyncFileExistsValidator extends ConstraintValidator
         try {
             $response = $this->client->request('HEAD', $urlHead->url);
 
-            if (404 === $response->getStatusCode()) {
+            if (404 === $status = $response->getStatusCode()) {
                 $this->context->buildViolation($constraint->message)
                     ->setParameter('{{ filename }}', $file)
                     ->addViolation();
+            } elseif (500 <= $status) {
+                throw new TempUrlRemoteServerException($response->getStatusCode());
+            } elseif (400 <= $status) {
+                throw new BadCallToRemoteServer($response->getContent(false), $response->getStatusCode());
             }
         } catch (HttpExceptionInterface $exception) {
             if (404 !== $exception->getResponse()->getStatusCode()) {
                 throw $exception;
             }
+        } catch (TransportExceptionInterface $e) {
+            throw new TempUrlRemoteServerException(0, previous: $e);
         }
     }
 }