From 6e42b0862715105b6666f6257688a485432cee5e Mon Sep 17 00:00:00 2001 From: Mathieu Jaumotte Date: Fri, 17 Sep 2021 08:19:12 +0200 Subject: [PATCH 1/7] Address: remove unused file --- .../AddAddress/SelectHouseholdAddress.vue | 47 ------------------- 1 file changed, 47 deletions(-) delete mode 100644 src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress/SelectHouseholdAddress.vue diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress/SelectHouseholdAddress.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress/SelectHouseholdAddress.vue deleted file mode 100644 index 74ce14c3c..000000000 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress/SelectHouseholdAddress.vue +++ /dev/null @@ -1,47 +0,0 @@ - - - - - - - From 4bafa83b65297ccf621c2c8775ceb7d5cfec3da4 Mon Sep 17 00:00:00 2001 From: Mathieu Jaumotte Date: Fri, 17 Sep 2021 08:27:58 +0200 Subject: [PATCH 2/7] Address: rename [Show|Edit]AddressPane files --- .../vuejs/Address/components/AddAddress.vue | 24 +++++++++---------- .../{EditAddressPane.vue => EditPane.vue} | 2 +- .../{ShowAddressPane.vue => ShowPane.vue} | 2 +- 3 files changed, 14 insertions(+), 14 deletions(-) rename src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/{EditAddressPane.vue => EditPane.vue} (99%) rename src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/{ShowAddressPane.vue => ShowPane.vue} (99%) diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue index 2a210e992..248e7da2b 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue @@ -24,14 +24,14 @@ @@ -121,16 +121,16 @@ import Modal from 'ChillMainAssets/vuejs/_components/Modal'; import { getAddress, fetchCountries, fetchCities, fetchReferenceAddresses, patchAddress, postAddress, postPostalCode } from '../api'; import { postAddressToPerson, postAddressToHousehold } from "ChillPersonAssets/vuejs/_api/AddAddress.js"; -import ShowAddressPane from './ShowAddressPane.vue'; -import EditAddressPane from './EditAddressPane.vue'; +import ShowPane from './ShowPane.vue'; +import EditPane from './EditPane.vue'; export default { name: "AddAddress", props: ['context', 'options', 'addressChangedCallback'], components: { Modal, - ShowAddressPane, - EditAddressPane, + ShowPane, + EditPane, }, data() { return { diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditAddressPane.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditPane.vue similarity index 99% rename from src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditAddressPane.vue rename to src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditPane.vue index 7bbad3db5..8cacf9981 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditAddressPane.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditPane.vue @@ -85,7 +85,7 @@ import AddressMap from './AddAddress/AddressMap'; import AddressMore from './AddAddress/AddressMore' export default { - name: "EditAddressPane", + name: "EditPane", components: { CountrySelection, CitySelection, diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowAddressPane.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue similarity index 99% rename from src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowAddressPane.vue rename to src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue index 7e55f0c1b..eace3f6d2 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowAddressPane.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue @@ -66,7 +66,7 @@ import { dateToISO, ISOToDate, ISOToDatetime } from 'ChillMainAssets/chill/js/da import AddressRenderBox from 'ChillMainAssets/vuejs/_components/Entity/AddressRenderBox.vue'; export default { - name: 'ShowAddressPane', + name: 'ShowPane', components: { AddressRenderBox }, From 782f0bc3326a6ac145b9ef82afb2defc0fd33964 Mon Sep 17 00:00:00 2001 From: Mathieu Jaumotte Date: Fri, 17 Sep 2021 10:43:59 +0200 Subject: [PATCH 3/7] twig _insert_vue_address, rename mode create --- .../Resources/views/Address/_insert_vue_address.html.twig | 2 +- .../ChillPersonBundle/Resources/views/Address/list.html.twig | 2 +- .../Resources/views/Household/addresses.html.twig | 2 +- .../Resources/views/Household/summary.html.twig | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig index 05f557d44..fa08286f8 100644 --- a/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig +++ b/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig @@ -7,7 +7,7 @@ name: string id: integer } - * mode string ['edit*'|'create'] + * mode string ['edit*'|'new'] * addressId integer * backUrl twig route: path('route', {parameters}) * modalTitle twig translated chain diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Address/list.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Address/list.html.twig index 3719e0ebe..ce68e4da8 100644 --- a/src/Bundle/ChillPersonBundle/Resources/views/Address/list.html.twig +++ b/src/Bundle/ChillPersonBundle/Resources/views/Address/list.html.twig @@ -32,7 +32,7 @@ {% include '@ChillMain/Address/_insert_vue_address.html.twig' with { targetEntity: { name: 'person', id: person.id }, backUrl: path('chill_person_address_list', { 'person_id': person.id }), - mode: 'create', + mode: 'new', buttonSize: 'btn-lg', buttonText: 'Add an address', modalTitle: 'Add an address', diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Household/addresses.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Household/addresses.html.twig index 087e8be11..3bee011dd 100644 --- a/src/Bundle/ChillPersonBundle/Resources/views/Household/addresses.html.twig +++ b/src/Bundle/ChillPersonBundle/Resources/views/Household/addresses.html.twig @@ -18,7 +18,7 @@ {% include '@ChillMain/Address/_insert_vue_address.html.twig' with { targetEntity: { name: 'household', id: household.id }, backUrl: path('chill_person_household_address_move', { 'household_id': household.id }), - mode: 'create', + mode: 'new', buttonSize: 'btn-lg', buttonText: 'Move household', modalTitle: 'Move household', diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig index a680f18f2..e8b0c7b78 100644 --- a/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig +++ b/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig @@ -33,7 +33,7 @@ {% include '@ChillMain/Address/_insert_vue_address.html.twig' with { targetEntity: { name: 'household', id: household.id }, backUrl: path('chill_person_household_addresses', { 'household_id': household.id }), - mode: 'create', + mode: 'new', buttonSize: 'btn-sm', buttonText: 'Move household', modalTitle: 'Move household', From 6a60758c0d322c733c39952a86b41ee373581c1d Mon Sep 17 00:00:00 2001 From: Mathieu Jaumotte Date: Fri, 17 Sep 2021 10:50:57 +0200 Subject: [PATCH 4/7] AddAddress: openPanesInModal, uniq option to enable/disable all step123 in Modal --- .../vuejs/Address/components/AddAddress.vue | 25 +++++-------------- .../Resources/public/vuejs/Address/index.js | 7 ++---- .../Address/_insert_vue_address.html.twig | 10 +++----- .../components/CourseLocation.vue | 4 +-- .../Resources/views/Address/edit.html.twig | 3 +-- .../Resources/views/Address/list.html.twig | 6 ++--- .../Resources/views/Address/new.html.twig | 3 +-- .../views/Household/address_edit.html.twig | 3 +-- .../views/Household/address_move.html.twig | 3 +-- .../views/Household/summary.html.twig | 3 +-- 10 files changed, 19 insertions(+), 48 deletions(-) diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue index 248e7da2b..69f764284 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue @@ -9,8 +9,8 @@ - modalDialogClass="modal-dialog-scrollable modal-xl" @close="flag.showPane = false"> @@ -62,7 +62,7 @@ - + @@ -147,10 +147,7 @@ export default { displayText: true }, title: { create: 'add_an_address_title', edit: 'edit_address' }, - bindModal: { - step1: true, - step2: true, - }, + openPanesInModal: true, useDate: { validFrom: false, validTo: false @@ -192,19 +189,9 @@ export default { } }, computed: { - step1WithModal() { - return (typeof this.options.bindModal !== 'undefined' && typeof this.options.bindModal.step1 !== 'undefined') ? - this.options.bindModal.step1 : this.default.bindModal.step1; - }, - step2WithModal() { - let step2 = (typeof this.options.bindModal !== 'undefined' && typeof this.options.bindModal.step2 !== 'undefined') ? - this.options.bindModal.step2 : this.default.bindModal.step2; - - if (step2 === false && this.step1WithModal === true) { - console.log("step2 must open in a Modal"); - return true; - } - return step2; + InModal() { + return (typeof this.options.openPanesInModal !== 'undefined') ? + this.options.openPanesInModal : this.default.openPanesInModal; }, getTextTitle() { if ( typeof this.options.title !== 'undefined' diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js index cb628586a..4e49b2207 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js @@ -38,12 +38,9 @@ containers.forEach((container) => { create: container.dataset.modalTitle || null, edit: container.dataset.modalTitle || null }, - /// Display each step in page or Modal - bindModal: { - step1: container.dataset.bindModalStep1 !== 'false', //boolean, default: true - step2: container.dataset.bindModalStep2 !== 'false' //boolean, default: true - }, // Use Date fields + /// Display panes in Modal for step123 + openPanesInModal: container.dataset.openPanesInModal !== 'false', //boolean, default: true useDate: { validFrom: container.dataset.useValidFrom === 'true', //boolean, default: false validTo: container.dataset.useValidTo === 'true' //boolean, default: false diff --git a/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig index fa08286f8..052cdbec9 100644 --- a/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig +++ b/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig @@ -14,9 +14,8 @@ * buttonText twig translated chain * buttonSize bootstrap class like 'btn-sm' * buttonDisplayText bool - * bindModalStep1 bool - * bindModalStep2 bool + * openPanesInModal bool (default: true) #}
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Household/address_move.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Household/address_move.html.twig index 6d65c0a7f..2b7dfa8f0 100644 --- a/src/Bundle/ChillPersonBundle/Resources/views/Household/address_move.html.twig +++ b/src/Bundle/ChillPersonBundle/Resources/views/Household/address_move.html.twig @@ -10,8 +10,7 @@ {% include '@ChillMain/Address/_insert_vue_address.html.twig' with { targetEntity: { name: 'household', id: household.id }, backUrl: path('chill_person_household_addresses', { 'household_id': household.id }), - bindModalStep1: false, - bindModalStep2: false, + openPanesInModal: false, } %}
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig index e8b0c7b78..d8c53dbf5 100644 --- a/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig +++ b/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig @@ -40,8 +40,7 @@ buttonDisplayText: false, } %} {# - bindModalStep1: false, - bindModalStep2: true, + openPanesInModal: false #}
  • From f048395a892b641148933b7c21c50bddfceb8229 Mon Sep 17 00:00:00 2001 From: Mathieu Jaumotte Date: Fri, 17 Sep 2021 10:57:13 +0200 Subject: [PATCH 5/7] AddAddress: reorganize 4 steps Pane: show, suggest, edit, and date --- .../Address/components/ActionButtons.vue | 30 +++++ .../vuejs/Address/components/AddAddress.vue | 123 ++++++++++++------ .../vuejs/Address/components/DatePane.vue | 121 +++++++++++++++++ .../vuejs/Address/components/EditPane.vue | 42 +++--- .../vuejs/Address/components/ShowPane.vue | 101 ++++---------- .../vuejs/Address/components/SuggestPane.vue | 60 +++++++++ 6 files changed, 338 insertions(+), 139 deletions(-) create mode 100644 src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue create mode 100644 src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/DatePane.vue create mode 100644 src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/SuggestPane.vue diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue new file mode 100644 index 000000000..94d6ab105 --- /dev/null +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue @@ -0,0 +1,30 @@ + + + diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue index 69f764284..1948535dc 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue @@ -1,18 +1,21 @@ + + diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditPane.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditPane.vue index 8cacf9981..0009df622 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditPane.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/EditPane.vue @@ -2,7 +2,7 @@
    - @@ -82,7 +80,8 @@ import CountrySelection from './AddAddress/CountrySelection'; import CitySelection from './AddAddress/CitySelection'; import AddressSelection from './AddAddress/AddressSelection'; import AddressMap from './AddAddress/AddressMap'; -import AddressMore from './AddAddress/AddressMore' +import AddressMore from './AddAddress/AddressMore'; +import ActionButtons from './ActionButtons.vue'; export default { name: "EditPane", @@ -91,7 +90,8 @@ export default { CitySelection, AddressSelection, AddressMap, - AddressMore + AddressMore, + ActionButtons }, props: [ 'context', diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue index eace3f6d2..f57340bf0 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue @@ -1,68 +1,27 @@ + + From 331dd286e79e7c8c395234070261b7b553227da0 Mon Sep 17 00:00:00 2001 From: Mathieu Jaumotte Date: Fri, 17 Sep 2021 10:59:06 +0200 Subject: [PATCH 6/7] AddAddress: adding a new stickyActions option --- .../public/vuejs/Address/components/ActionButtons.vue | 1 + .../Resources/public/vuejs/Address/index.js | 4 +++- .../views/Address/_insert_vue_address.html.twig | 9 +++++++-- .../Resources/views/Address/new.html.twig | 1 + 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue index 94d6ab105..a0bb66f33 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue @@ -24,6 +24,7 @@ export default { props: [ 'options', 'default' ], computed: { isStickyForm() { + return (typeof this.options.stickyActions !== 'undefined') ? this.options.stickyActions : this.default.stickyActions; } } } diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js index 4e49b2207..7ecf4847a 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js @@ -38,9 +38,11 @@ containers.forEach((container) => { create: container.dataset.modalTitle || null, edit: container.dataset.modalTitle || null }, - // Use Date fields /// Display panes in Modal for step123 openPanesInModal: container.dataset.openPanesInModal !== 'false', //boolean, default: true + /// Display actions buttons of panes in a sticky-form-button navbar + stickyActions: container.dataset.stickyActions === 'true', //boolean, default: false + /// Use Date fields useDate: { validFrom: container.dataset.useValidFrom === 'true', //boolean, default: false validTo: container.dataset.useValidTo === 'true' //boolean, default: false diff --git a/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig index 052cdbec9..bf996f593 100644 --- a/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig +++ b/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig @@ -13,9 +13,11 @@ * modalTitle twig translated chain * buttonText twig translated chain * buttonSize bootstrap class like 'btn-sm' - * buttonDisplayText bool - + * buttonDisplayText bool (default: true) * openPanesInModal bool (default: true) + * stickyActions bool (default: false) + * useValidFrom bool (default: false) + * useValidTo bool (default: false) #}
    Date: Fri, 17 Sep 2021 13:09:18 +0200 Subject: [PATCH 7/7] AddAddress: adjust Open and Close methods for each step --- .../Resources/public/vuejs/Address/App.vue | 4 +- .../Address/components/ActionButtons.vue | 17 ++- .../vuejs/Address/components/AddAddress.vue | 110 +++++++++++++----- .../vuejs/Address/components/DatePane.vue | 5 +- .../vuejs/Address/components/EditPane.vue | 12 +- .../vuejs/Address/components/ShowPane.vue | 20 +++- .../vuejs/Address/components/SuggestPane.vue | 5 +- .../Resources/public/vuejs/Address/index.js | 2 +- .../Resources/views/Address/new.html.twig | 5 +- .../views/Household/address_edit.html.twig | 1 + 10 files changed, 132 insertions(+), 49 deletions(-) diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/App.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/App.vue index e4d332289..a1496e7d6 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/App.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/App.vue @@ -33,8 +33,8 @@ export default { }, mounted() { - console.log('AddAddress: data context', this.context); - console.log('AddAddress: data options', this.options); + //console.log('AddAddress: data context', this.context); + //console.log('AddAddress: data options', this.options); }, methods: { displayErrors() { diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue index a0bb66f33..afe059da6 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue @@ -2,19 +2,23 @@
      + +
    @@ -24,7 +28,16 @@ export default { props: [ 'options', 'default' ], computed: { isStickyForm() { - return (typeof this.options.stickyActions !== 'undefined') ? this.options.stickyActions : this.default.stickyActions; + return (typeof this.options.stickyActions !== 'undefined') ? + this.options.stickyActions : this.default.stickyActions; + }, + }, + methods: { + resetPane() { + this.flag.suggestPane = false; + this.flag.editPane = false; + this.flag.datePane = false; + this.flag.showPane = true; } } } diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue index 1948535dc..259266c92 100644 --- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue +++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue @@ -12,10 +12,10 @@ - + + @close="resetPane"> @@ -63,10 +65,10 @@
    - + + @close="resetPane">