From 7ddf84ea5a76c63afa50f323fe37d6b3ea1d3517 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Fri, 14 Mar 2025 15:07:23 +0100
Subject: [PATCH] Fix ts errors upon prod compilation

---
 assets/translator.ts                          |  2 +-
 package.json                                  |  1 +
 .../public/vuejs/DocumentSignature/App.vue    | 29 ++++++++++---------
 .../HistoryButton/HistoryButtonModal.vue      |  7 +++--
 .../public/vuejs/WorkflowAttachment/App.vue   |  5 +++-
 .../Component/PickGenericDoc.vue              |  8 +++--
 6 files changed, 32 insertions(+), 20 deletions(-)

diff --git a/assets/translator.ts b/assets/translator.ts
index 4834e30a6..ad2de8c0b 100644
--- a/assets/translator.ts
+++ b/assets/translator.ts
@@ -1,5 +1,5 @@
 // @ts-ignore Cannot find module (when used within an app)
-import { trans, getLocale, setLocale, setLocaleFallbacks } from "@symfony/ux-translator";
+import { trans, setLocale, setLocaleFallbacks } from "@symfony/ux-translator";
 
 setLocaleFallbacks({"en": "fr", "nl": "fr", "fr": "en"});
 setLocale('fr');
diff --git a/package.json b/package.json
index a24c4ee8f..e2b8d8ba3 100644
--- a/package.json
+++ b/package.json
@@ -11,6 +11,7 @@
     "@hotwired/stimulus": "^3.0.0",
     "@luminateone/eslint-baseline": "^1.0.9",
     "@symfony/stimulus-bridge": "^3.2.0",
+    "@symfony/ux-translator": "file:vendor/symfony/ux-translator/assets",
     "@symfony/webpack-encore": "^4.1.0",
     "@tsconfig/node20": "^20.1.4",
     "@types/dompurify": "^3.0.5",
diff --git a/src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/DocumentSignature/App.vue b/src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/DocumentSignature/App.vue
index b47a6bce0..283156696 100644
--- a/src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/DocumentSignature/App.vue
+++ b/src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/DocumentSignature/App.vue
@@ -92,8 +92,7 @@
             >
                 <button
                     :disabled="
-                        userSignatureZone === null ||
-                        userSignatureZone?.index < 1
+                        isFirstSignatureZone
                     "
                     class="btn btn-light btn-sm"
                     @click="turnSignature(-1)"
@@ -103,7 +102,7 @@
                 <span>|</span>
                 <button
                     :disabled="
-                        userSignatureZone?.index >= signature.zones.length - 1
+                        isLastSignatureZone
                     "
                     class="btn btn-light btn-sm"
                     @click="turnSignature(1)"
@@ -200,10 +199,7 @@
                 class="col-4 d-xl-none text-center turnSignature p-0"
             >
                 <button
-                    :disabled="
-                        userSignatureZone === null ||
-                        userSignatureZone?.index < 1
-                    "
+                    :disabled="!hasSignatureZoneSelected"
                     class="btn btn-light btn-sm"
                     @click="turnSignature(-1)"
                 >
@@ -212,7 +208,7 @@
                 <span>|</span>
                 <button
                     :disabled="
-                        userSignatureZone?.index >= signature.zones.length - 1
+                        isLastSignatureZone
                     "
                     class="btn btn-light btn-sm"
                     @click="turnSignature(1)"
@@ -226,8 +222,7 @@
             >
                 <button
                     :disabled="
-                        userSignatureZone === null ||
-                        userSignatureZone?.index < 1
+                        isFirstSignatureZone
                     "
                     class="btn btn-light btn-sm"
                     @click="turnSignature(-1)"
@@ -236,9 +231,7 @@
                 </button>
                 <span>|</span>
                 <button
-                    :disabled="
-                        userSignatureZone?.index >= signature.zones.length - 1
-                    "
+                    :disabled="isLastSignatureZone"
                     class="btn btn-light btn-sm"
                     @click="turnSignature(1)"
                 >
@@ -333,7 +326,7 @@
 </template>
 
 <script setup lang="ts">
-import { ref, Ref, reactive } from "vue";
+import {ref, Ref, reactive, computed} from "vue";
 import { useToast } from "vue-toast-notification";
 import "vue-toast-notification/dist/theme-sugar.css";
 import {
@@ -433,6 +426,14 @@ const $toast = useToast();
 
 const signature = window.signature;
 
+const isFirstSignatureZone = () => userSignatureZone.value?.index ? userSignatureZone.value.index < 1 : false
+const isLastSignatureZone = () => userSignatureZone.value?.index ? userSignatureZone.value.index >= signature.zones.length - 1 : false
+
+/**
+ * Return true if the user has selected a user zone (existing on the doc or created by the user)
+ */
+const hasSignatureZoneSelected = computed<boolean>(() => userSignatureZone.value !== null);
+
 const setZoomLevel = async (zoomLevel: string) => {
     zoom.value = Number.parseFloat(zoomLevel);
     await resetPages();
diff --git a/src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/StoredObjectButton/HistoryButton/HistoryButtonModal.vue b/src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/StoredObjectButton/HistoryButton/HistoryButtonModal.vue
index 52684e068..a789e2db7 100644
--- a/src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/StoredObjectButton/HistoryButton/HistoryButtonModal.vue
+++ b/src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/StoredObjectButton/HistoryButton/HistoryButtonModal.vue
@@ -3,8 +3,9 @@ import Modal from "ChillMainAssets/vuejs/_components/Modal.vue";
 import { reactive } from "vue";
 import HistoryButtonList from "ChillDocStoreAssets/vuejs/StoredObjectButton/HistoryButton/HistoryButtonList.vue";
 import {
-    StoredObject,
+    StoredObject, StoredObjectVersion,
     StoredObjectVersionWithPointInTime,
+    StoredObjectPointInTime
 } from "./../../../types";
 
 interface HistoryButtonListConfig {
@@ -28,6 +29,8 @@ const open = () => {
     state.opened = true;
 };
 
+const onRestoreVersion = (payload : { newVersion: StoredObjectVersionWithPointInTime }) => emit('restoreVersion', payload)
+
 defineExpose({ open });
 </script>
 <template>
@@ -43,7 +46,7 @@ defineExpose({ open });
                     :can-edit="canEdit"
                     :stored-object="storedObject"
                     @restore-version="
-                        (payload) => emit('restoreVersion', payload)
+                        onRestoreVersion
                     "
                 ></history-button-list>
             </template>
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/WorkflowAttachment/App.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/WorkflowAttachment/App.vue
index eeea00d29..4f18c1bd1 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/WorkflowAttachment/App.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/WorkflowAttachment/App.vue
@@ -45,6 +45,9 @@ const onPickGenericDoc = ({
 }) => {
     emit("pickGenericDoc", { genericDoc });
 };
+
+const onRemoveAttachment = (payload: { attachment: WorkflowAttachment }) => { emit('removeAttachment', payload) };
+
 </script>
 
 <template>
@@ -56,7 +59,7 @@ const onPickGenericDoc = ({
     ></pick-generic-doc-modal>
     <attachment-list
         :attachments="props.attachments"
-        @removeAttachment="(payload) => emit('removeAttachment', payload)"
+        @removeAttachment="onRemoveAttachment"
     ></attachment-list>
     <ul class="record_actions">
         <li>
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/WorkflowAttachment/Component/PickGenericDoc.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/WorkflowAttachment/Component/PickGenericDoc.vue
index bf687eca8..09d305e46 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/WorkflowAttachment/Component/PickGenericDoc.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/WorkflowAttachment/Component/PickGenericDoc.vue
@@ -72,6 +72,10 @@ const placeTrans = (str: string): string => {
     }
 };
 
+const onPickDocument = (payload: { genericDoc: GenericDocForAccompanyingPeriod }) => emit('pickGenericDoc', payload);
+
+const onRemoveGenericDoc = (payload: {genericDoc: GenericDocForAccompanyingPeriod}) => emit('removeGenericDoc', payload);
+
 const filteredDocuments = computed<GenericDocForAccompanyingPeriod[]>(() => {
     if (false === loaded.value) {
         return [];
@@ -245,9 +249,9 @@ const filteredDocuments = computed<GenericDocForAccompanyingPeriod[]>(() => {
                 :accompanying-period-id="accompanyingPeriodId"
                 :genericDoc="g"
                 :is-picked="isPicked(g)"
-                @pickGenericDoc="(payload) => emit('pickGenericDoc', payload)"
+                @pickGenericDoc="onPickDocument"
                 @removeGenericDoc="
-                    (payload) => emit('removeGenericDoc', payload)
+                    onRemoveGenericDoc
                 "
             ></pick-generic-doc-item>
         </div>