From 7915aae86fcd8eb68a5468229cc2dbc519acbaaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Thu, 19 Jan 2023 13:27:08 +0100
Subject: [PATCH] Feature: [workflow] do not send a notification for each step
 to creator's workflow

Now, by default:

- the creator will receive a notification for the last step only;
- the participant / assignee for each step won't receive a notification (unless they explicitly choose to receive one)
---
 src/Bundle/ChillMainBundle/Controller/WorkflowController.php  | 1 -
 .../ChillMainBundle/Entity/Workflow/EntityWorkflowStep.php    | 4 ----
 2 files changed, 5 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Controller/WorkflowController.php b/src/Bundle/ChillMainBundle/Controller/WorkflowController.php
index 9be2f04fd..17b5db75e 100644
--- a/src/Bundle/ChillMainBundle/Controller/WorkflowController.php
+++ b/src/Bundle/ChillMainBundle/Controller/WorkflowController.php
@@ -85,7 +85,6 @@ class WorkflowController extends AbstractController
             ->setRelatedEntityClass($request->query->get('entityClass'))
             ->setRelatedEntityId($request->query->getInt('entityId'))
             ->setWorkflowName($request->query->get('workflow'))
-            ->addSubscriberToStep($this->getUser())
             ->addSubscriberToFinal($this->getUser());
 
         $errors = $this->validator->validate($entityWorkflow, null, ['creation']);
diff --git a/src/Bundle/ChillMainBundle/Entity/Workflow/EntityWorkflowStep.php b/src/Bundle/ChillMainBundle/Entity/Workflow/EntityWorkflowStep.php
index d86770560..4bff7a3f5 100644
--- a/src/Bundle/ChillMainBundle/Entity/Workflow/EntityWorkflowStep.php
+++ b/src/Bundle/ChillMainBundle/Entity/Workflow/EntityWorkflowStep.php
@@ -132,8 +132,6 @@ class EntityWorkflowStep
     {
         if (!$this->destUser->contains($user)) {
             $this->destUser[] = $user;
-            $this->getEntityWorkflow()
-                ->addSubscriberToFinal($user);
         }
 
         return $this;
@@ -143,8 +141,6 @@ class EntityWorkflowStep
     {
         if (!$this->destUserByAccessKey->contains($user) && !$this->destUser->contains($user)) {
             $this->destUserByAccessKey[] = $user;
-            $this->getEntityWorkflow()
-                ->addSubscriberToFinal($user);
         }
 
         return $this;