From 60eab628ee6a11763bd5b33fc53dc4fde9337199 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Tue, 7 Oct 2025 11:24:17 +0200
Subject: [PATCH] Clarify documentation in `PersonIdentifierManagerInterface`
 and fix formatting in SQL query

- Updated PHPDoc in `getWorkers` method to explicitly state that only active definitions are returned.
- Standardized number formatting in SQL query for better readability and consistency.
---
 .../PersonIdentifier/PersonIdentifierManagerInterface.php       | 2 ++
 .../ChillPersonBundle/Repository/PersonACLAwareRepository.php   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/Bundle/ChillPersonBundle/PersonIdentifier/PersonIdentifierManagerInterface.php b/src/Bundle/ChillPersonBundle/PersonIdentifier/PersonIdentifierManagerInterface.php
index eddcb6095..b28fba7b6 100644
--- a/src/Bundle/ChillPersonBundle/PersonIdentifier/PersonIdentifierManagerInterface.php
+++ b/src/Bundle/ChillPersonBundle/PersonIdentifier/PersonIdentifierManagerInterface.php
@@ -18,6 +18,8 @@ interface PersonIdentifierManagerInterface
     /**
      * Build PersonIdentifierWorker's for all active definition.
      *
+     * Only active definition are returned.
+     *
      * @return list<PersonIdentifierWorker>
      */
     public function getWorkers(): array;
diff --git a/src/Bundle/ChillPersonBundle/Repository/PersonACLAwareRepository.php b/src/Bundle/ChillPersonBundle/Repository/PersonACLAwareRepository.php
index 2947038a8..f704d28bf 100644
--- a/src/Bundle/ChillPersonBundle/Repository/PersonACLAwareRepository.php
+++ b/src/Bundle/ChillPersonBundle/Repository/PersonACLAwareRepository.php
@@ -153,7 +153,7 @@ final readonly class PersonACLAwareRepository implements PersonACLAwareRepositor
                         WHERE identifier.canonical LIKE LOWER(UNACCENT(?)) || '%' AND identifier.definition_id IN ({$idDefinitionWorkerQuestionMarks})
                         AND person.id = identifier.person_id
                     )";
-                    $pertinence[] = "({$mq})::int * 1_000_000";
+                    $pertinence[] = "({$mq})::int * 1000000";
                     $qArguments = [...$qArguments, $str, ...$idDefinitionWorkers];
                     $pertinenceArgs = [...$pertinenceArgs, $str, ...$idDefinitionWorkers];
                 }