From c791c482484f54069ac116769c4d5eedabe5070c Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Tue, 28 Sep 2021 14:06:52 +0200
Subject: [PATCH 01/45] tp: adapt to new ACL interface (wip)

---
 .../Controller/ThirdPartyController.php       | 32 +++++++++----------
 .../ThirdPartyACLAwareRepository.php          | 23 +++++++++++++
 .../ThirdPartyACLAwareRepositoryInterface.php | 16 ++++++++++
 .../Security/Voter/ThirdPartyVoter.php        |  2 ++
 4 files changed, 57 insertions(+), 16 deletions(-)
 create mode 100644 src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepository.php
 create mode 100644 src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepositoryInterface.php

diff --git a/src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php b/src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php
index d16934b18..dff892b99 100644
--- a/src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php
+++ b/src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php
@@ -66,8 +66,8 @@ class ThirdPartyController extends Controller
                 $this->getUser(), 
                 new Role(ThirdPartyVoter::SHOW)
                 );
-        
-        $nbThirdParties = $repository->countByMemberOfCenters($centers);
+
+        $nbThirdParties = $repository->countByMemberOfCenters($centers); //
         $pagination = $this->paginatorFactory->create($nbThirdParties);
         
         $thirdParties = $repository->findByMemberOfCenters(
@@ -88,18 +88,18 @@ class ThirdPartyController extends Controller
     public function newAction(Request $request)
     {
         $this->denyAccessUnlessGranted(ThirdPartyVoter::CREATE);
-        
-        $centers = $this->authorizationHelper
+
+        /* $centers = $this->authorizationHelper
             ->getReachableCenters(
-                $this->getUser(), 
+                $this->getUser(),
                 new Role(ThirdPartyVoter::CREATE)
                 );
-        
-        if (count($centers) === 0) {
+
+        if ($centers === []) { //
             throw new \LogicException("There should be at least one center reachable "
                 . "if role ".ThirdPartyVoter::CREATE." is granted");
-        }
-        
+        } */
+
         $thirdParty = new ThirdParty();
         $thirdParty->setCenters(new ArrayCollection($centers));
         
@@ -141,18 +141,18 @@ class ThirdPartyController extends Controller
     public function updateAction(ThirdParty $thirdParty, Request $request)
     {
        $this->denyAccessUnlessGranted(ThirdPartyVoter::CREATE);
-        
-        $centers = $this->authorizationHelper
+
+        /* $centers = $this->authorizationHelper
             ->getReachableCenters(
-                $this->getUser(), 
+                $this->getUser(),
                 new Role(ThirdPartyVoter::CREATE)
                 );
-        
-        if (count($centers) === 0) {
+
+        if ($centers === []) {
             throw new \LogicException("There should be at least one center reachable "
                 . "if role ".ThirdPartyVoter::CREATE." is granted");
-        }
-        
+        } */
+
         // we want to keep centers the users has no access to. So we will add them
         // later if they are removed. (this is a ugly hack but it will works
         $centersAssociatedNotForUsers = \array_diff(
diff --git a/src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepository.php b/src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepository.php
new file mode 100644
index 000000000..ff21d18c7
--- /dev/null
+++ b/src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepository.php
@@ -0,0 +1,23 @@
+<?php
+
+namespace Chill\ThirdPartyBundle\Repository;
+
+use Chill\ThirdPartyBundle\Entity\ThirdParty;
+
+/**
+ * @Author Mathieu Jaumotte mathieu.jaumotte@champs-libres.coop
+ */
+class ThirdPartyACLAwareRepository implements ThirdPartyACLAwareRepositoryInterface
+{
+
+    public function findByThirdparty(
+        ThirdParty $thirdparty,
+        string $role,
+        ?array $orderBy = [],
+        int $limit = null,
+        int $offset = null
+    ): array {
+
+        // TODO: Implement findByThirdparty() method.
+    }
+}
diff --git a/src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepositoryInterface.php b/src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepositoryInterface.php
new file mode 100644
index 000000000..263a1312c
--- /dev/null
+++ b/src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepositoryInterface.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace Chill\ThirdPartyBundle\Repository;
+
+use Chill\ThirdPartyBundle\Entity\ThirdParty;
+
+interface ThirdPartyACLAwareRepositoryInterface
+{
+    public function findByThirdparty(
+        ThirdParty $thirdparty,
+        string $role,
+        ?array $orderBy = [],
+        int $limit = null,
+        int $offset = null
+    ): array;
+}
diff --git a/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php b/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
index a1ce94e25..7b3e4e5b1 100644
--- a/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
+++ b/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
@@ -56,6 +56,8 @@ class ThirdPartyVoter extends AbstractChillVoter implements ProvideRoleHierarchy
      */
     protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
     {
+        return true;
+
         $user = $token->getUser();
         
         if (!$user instanceof User) {

From e72ba4c940da286bbc63f5d942ccb7f4b395f58a Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Tue, 28 Sep 2021 15:34:15 +0200
Subject: [PATCH 02/45] bypass ACL restriction

---
 .../ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php    | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php b/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
index a1ce94e25..7b3e4e5b1 100644
--- a/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
+++ b/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
@@ -56,6 +56,8 @@ class ThirdPartyVoter extends AbstractChillVoter implements ProvideRoleHierarchy
      */
     protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
     {
+        return true;
+
         $user = $token->getUser();
         
         if (!$user instanceof User) {

From 644d0420ceaa5bc485ce9dd0099ff39cc5d0a574 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Tue, 28 Sep 2021 16:23:24 +0200
Subject: [PATCH 03/45] creation of endpoints POST, PUT, PATCH, but still
 errors

---
 .../ChillThirdPartyExtension.php              | 18 +++-
 .../Entity/ThirdParty.php                     | 10 +-
 .../Security/Voter/ThirdPartyVoter.php        |  2 +
 .../chill.api.specs.yaml                      | 97 ++++++++++++++++++-
 4 files changed, 116 insertions(+), 11 deletions(-)

diff --git a/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php b/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
index 9b23222c6..2fd0f723d 100644
--- a/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
+++ b/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
@@ -59,7 +59,7 @@ class ChillThirdPartyExtension extends Extension implements PrependExtensionInte
                     'class' => \Chill\ThirdPartyBundle\Entity\ThirdParty::class,
                     'name' => 'thirdparty',
                     'base_path' => '/api/1.0/thirdparty/thirdparty',
-                    'base_role' => \Chill\ThirdPartyBundle\Security\Authorization\ThirdPartyVoter::class,
+                    //'base_role' => \Chill\ThirdPartyBundle\Security\Authorization\ThirdPartyVoter::SHOW,
                     //'controller' => \Chill\ThirdPartyBundle\Controller\ThirdPartyApiController::class,
                     'actions' => [
                         '_index' => [
@@ -67,19 +67,31 @@ class ChillThirdPartyExtension extends Extension implements PrependExtensionInte
                                 Request::METHOD_GET => true,
                                 Request::METHOD_HEAD => true,
                                 Request::METHOD_POST => true,
+                                Request::METHOD_PATCH => true,
+                                Request::METHOD_PUT => true
+                            ],
+                            'roles' => [
+                                Request::METHOD_GET => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::SHOW,
+                                Request::METHOD_HEAD => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::SHOW,
+                                Request::METHOD_POST => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE,
+                                Request::METHOD_PUT => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE,
+                                Request::METHOD_PATCH => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE
                             ],
                         ],
                         '_entity' => [
                             'methods' => [
                                 Request::METHOD_GET => true,
                                 Request::METHOD_HEAD => true,
-                                Request::METHOD_POST=> true,
+                                Request::METHOD_POST => true,
+                                Request::METHOD_PUT => true,
+                                Request::METHOD_PATCH => true
                             ],
                             'roles' => [
                                 Request::METHOD_GET => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::SHOW,
                                 Request::METHOD_HEAD => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::SHOW,
                                 Request::METHOD_POST => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE,
-
+                                Request::METHOD_PUT => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE,
+                                Request::METHOD_PATCH => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE
                             ],
                         ]
                     ]
diff --git a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
index 0b0b3e56b..842e57b8b 100644
--- a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
+++ b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
@@ -60,7 +60,7 @@ class ThirdParty
      * @var string
      * @ORM\Column(name="name", type="string", length=255)
      * @Assert\Length(min="2")
-     * @Groups({"read"})
+     * @Groups({"read", "write"})
      */
     private $name;
 
@@ -69,6 +69,7 @@ class ThirdParty
      * @var string
      * @ORM\Column(name="name_company", type="string", length=255, nullable=true)
      * @Assert\Length(min="3")
+     * @Groups({"read", "write"})
     */
     private $nameCompany;
 
@@ -77,6 +78,7 @@ class ThirdParty
      * @var string
      * @ORM\Column(name="acronym", type="string", length=64, nullable=true)
      * @Assert\Length(min="2")
+     * @Groups({"read", "write"})
     */
     private $acronym;
 
@@ -130,7 +132,7 @@ class ThirdParty
      * @Assert\Regex("/^([\+{1}])([0-9\s*]{4,20})$/",
      *   message="Invalid phone number: it should begin with the international prefix starting with ""+"", hold only digits and be smaller than 20 characters. Ex: +33123456789"
      * )
-     * @Groups({"read"})
+     * @Groups({"read", "write"})
      */
     private $telephone;
 
@@ -138,7 +140,7 @@ class ThirdParty
      * @var string|null
      * @ORM\Column(name="email", type="string", length=255, nullable=true)
      * @Assert\Email(checkMX=false)
-     * @Groups({"read"})
+     * @Groups({"read", "write"})
      */
     private $email;
 
@@ -147,7 +149,7 @@ class ThirdParty
      * @ORM\ManyToOne(targetEntity="\Chill\MainBundle\Entity\Address",
      *   cascade={"persist", "remove"})
      * @ORM\JoinColumn(nullable=true, onDelete="SET NULL")
-     * @Groups({"read"})
+     * @Groups({"read", "write"})
      */
     private $address;
 
diff --git a/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php b/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
index a1ce94e25..986bfb2b9 100644
--- a/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
+++ b/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
@@ -61,6 +61,8 @@ class ThirdPartyVoter extends AbstractChillVoter implements ProvideRoleHierarchy
         if (!$user instanceof User) {
             return false;
         }
+
+        return true;
         
         $centers = $this->authorizationHelper
             ->getReachableCenters($user, new Role($attribute));
diff --git a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
index 957bf9324..c5d9346ba 100644
--- a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
+++ b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
@@ -8,17 +8,47 @@ servers:
   - url: "/api"
     description: "Your current dev server"
 
+components:
+  schemas:
+    Thirdparty:
+      type: object
+      properties:
+        id:
+          type: integer
+          readOnly: true
+        name:
+          type: string
+        nameCompany:
+          type: string
+        acronym:
+          type: string
+        email:
+          type: string
+
 paths:
   /1.0/thirdparty/thirdparty.json:
-    get:
+    post:
       tags:
         - thirdparty
-      summary: Return a list of all thirdparty items
+      summary: Create a single thirdparty
+      requestBody:
+        description: "A thirdparty"
+        required: true
+        content:
+          application/json:
+            schema:
+              $ref: "#/components/schemas/Thirdparty"
       responses:
         200:
-          description: "ok"
-        401:
+          description: "OK"
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/Thirdparty"
+        403:
           description: "Unauthorized"
+        422:
+          description: "Invalid data"
 
   /1.0/thirdparty/thirdparty/{id}.json:
     get:
@@ -41,3 +71,62 @@ paths:
           description: "not found"
         401:
           description: "Unauthorized"
+    patch:
+      tags:
+        - thirdparty
+      summary: "Alter a thirdparty"
+      parameters:
+        - name: id
+          in: path
+          required: true
+          description: The thirdparty's id
+          schema:
+            type: integer
+            format: integer
+            minimum: 1
+      requestBody:
+        description: "A thirdparty"
+        required: true
+        content:
+          application/json:
+            schema:
+              $ref: "#/components/schemas/Thirdparty"
+      responses:
+        401:
+          description: "Unauthorized"
+        404:
+          description: "Not found"
+        200:
+          description: "OK"
+        422:
+          description: "Object with validation errors"
+    put:
+      tags:
+        - thirdparty
+      summary: Edit an existing thirdparty
+      parameters:
+        - name: id
+          in: path
+          required: true
+          description: The thirdparty's id
+          schema:
+            type: integer
+            format: integer
+            minimum: 1
+      requestBody:
+        required: true
+        content:
+          application/json:
+            schema:
+              $ref: "#/components/schemas/Thirdparty"
+      responses:
+        401:
+          description: "Unauthorized"
+        404:
+          description: "Not found"
+        200:
+          description: "OK"
+        422:
+          description: "Unprocessable entity (validation errors)"
+        400:
+          description: "Bad Request"

From c5fa1b883cd355ebe7d1c6dd06fd76ae84b2b3f8 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Tue, 28 Sep 2021 16:25:38 +0200
Subject: [PATCH 04/45] onthefly: adding tp i18n file

---
 .../public/vuejs/AccompanyingCourse/js/i18n.js        |  5 +++--
 .../public/vuejs/_components/OnTheFly/ThirdParty.vue  |  9 ++-------
 .../Resources/public/vuejs/_js/i18n.js                | 11 +++++++++++
 3 files changed, 16 insertions(+), 9 deletions(-)
 create mode 100644 src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_js/i18n.js

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
index cf3a0fb7e..0ab012954 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
@@ -1,4 +1,5 @@
-import { personMessages } from 'ChillPersonAssets/vuejs/_js/i18n'
+import { personMessages } from 'ChillPersonAssets/vuejs/_js/i18n';
+import { thirdpartyMessages } from 'ChillThirdPartyAssets/vuejs/_js/i18n';
 import { addressMessages } from 'ChillMainAssets/vuejs/Address/i18n';
 
 const appMessages = {
@@ -137,7 +138,7 @@ const appMessages = {
    }
 };
 
-Object.assign(appMessages.fr, personMessages.fr, addressMessages.fr);
+Object.assign(appMessages.fr, personMessages.fr, thirdpartyMessages.fr, addressMessages.fr);
 
 export {
    appMessages
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 1b1207131..6d1497e2b 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -19,15 +19,10 @@
       </div>
    </div>
    <div v-else-if="action === 'edit' || action === 'create'">
-      
-      <div class="form-floating mb-3">
-         <input class="form-control form-control-lg" id="firstname" v-model="thirdparty.firstName" v-bind:placeholder="$t('thirdparty.firstname')" />
-         <label for="firstname">{{ $t('thirdparty.firstname') }}</label>
-      </div>
 
       <div class="form-floating mb-3">
-         <input class="form-control form-control-lg" id="lastname" v-model="thirdparty.lastName" v-bind:placeholder="$t('thirdparty.lastname')" />
-         <label for="lastname">{{ $t('thirdparty.lastname') }}</label>
+         <input class="form-control form-control-lg" id="name" v-model="thirdparty.name" v-bind:placeholder="$t('thirdparty.name')" />
+         <label for="name">{{ $t('thirdparty.name') }}</label>
       </div>
 
       <div class="input-group mb-3">
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_js/i18n.js b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_js/i18n.js
new file mode 100644
index 000000000..37d09320d
--- /dev/null
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_js/i18n.js
@@ -0,0 +1,11 @@
+const thirdpartyMessages = {
+    fr: {
+        thirdparty: {
+            name: "Dénomination",
+            email: "Courriel",
+            phonenumber: "Téléphone",
+        }
+    }
+};
+
+export { thirdpartyMessages };

From adc94aaeea34a9e46f7c4738cddcdee307ee3322 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Tue, 28 Sep 2021 16:26:32 +0200
Subject: [PATCH 05/45] javascript syntax correction

---
 .../vuejs/_components/Entity/PersonRenderBox.vue     |  6 +++---
 .../vuejs/_components/Entity/ThirdPartyRenderBox.vue | 12 ++++++------
 .../public/vuejs/_components/OnTheFly/ThirdParty.vue |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
index 0f397211e..2bc5f0b3b 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
@@ -27,7 +27,7 @@
 
                 </div>
 
-                <p v-if="options.addInfo == true" class="moreinfo">
+                <p v-if="options.addInfo === true" class="moreinfo">
                     <i :class="'fa fa-fw ' + getGenderIcon" title="{{ getGender }}"></i>
                     <time v-if="person.birthdate && !person.deathdate" datetime="{{ person.birthdate }}" title="{{ birthdate }}">
                         {{ $t(getGenderTranslation) + ' ' + $d(birthdate, 'text') }}
@@ -142,7 +142,7 @@ export default {
     props: ['person', 'options', 'render', 'returnPath'],
     computed: {
         getGenderTranslation: function() {
-            return this.person.gender == 'woman' ? 'renderbox.birthday.woman' : 'renderbox.birthday.man';
+            return this.person.gender === 'woman' ? 'renderbox.birthday.woman' : 'renderbox.birthday.man';
         },
         isMultiline: function() {
             if(this.options.isMultiline){
@@ -152,7 +152,7 @@ export default {
             }
         },
         getGenderIcon: function() {
-            return this.person.gender == 'woman' ? 'fa-venus' : this.person.gender == 'man' ? 'fa-mars' : 'fa-neuter';
+            return this.person.gender === 'woman' ? 'fa-venus' : this.person.gender === 'man' ? 'fa-mars' : 'fa-neuter';
         },
         birthdate: function(){
             if(this.person.birthdate !== null){
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
index 720d9903b..eddde6a67 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
@@ -8,17 +8,17 @@
 
                 <div :class="'denomination h' + options.hLevel">
 
-                    <a v-if="this.options.addLink ==  true" href="#">
+                    <a v-if="this.options.addLink ===  true" href="#">
                         <span class="name">{{ thirdparty.text }}</span>
                     </a>
                     <span class="name">{{ thirdparty.text }}</span>
 
                     <span v-if="options.addId ==  true" class="id-number" :title="'n° ' + thirdparty.id">{{ thirdparty.id }}</span>
-                    <span v-if="options.addEntity ==  true && thirdparty.type == 'thirdparty'" class="badge rounded-pill bg-secondary">{{ $t('renderbox.type.thirdparty') }}</span>
+                    <span v-if="options.addEntity ==  true && thirdparty.type === 'thirdparty'" class="badge rounded-pill bg-secondary">{{ $t('renderbox.type.thirdparty') }}</span>
 
                 </div>
 
-                <p v-if="this.options.addInfo == true" class="moreinfo">
+                <p v-if="this.options.addInfo === true" class="moreinfo">
                     <i v-if="thirdparty.birthdate" :class="'fa fa-fw ' + getGenderIcon" title="{{ getGender }}"></i>
                     <time v-if="thirdparty.birthdate" datetime="{{ thirdparty.birthdate.datetime }}" title="{{ birthdate }}">
                         {{ $t(getGender) + ' ' + $d(birthdate, 'short') }}
@@ -26,7 +26,7 @@
                     <time v-else-if="thirdparty.deathdate" datetime="{{ thirdparty.deathdate.datetime }}" title="{{ thirdparty.deathdate }}">
                         {{ birthdate }} - {{ deathdate }}
                     </time>
-                    <span v-if="options.addAge == true" class="age">{{ thirdparty.age }}</span>
+                    <span v-if="options.addAge === true" class="age">{{ thirdparty.age }}</span>
                 </p>
             </div>
         </div>
@@ -80,10 +80,10 @@ export default {
             }
         },
         getGender: function() {
-            return this.thirdparty.gender == 'woman' ? 'renderbox.birthday.woman' : 'renderbox.birthday.man';
+            return this.thirdparty.gender === 'woman' ? 'renderbox.birthday.woman' : 'renderbox.birthday.man';
         },
         getGenderIcon: function() {
-            return this.thirdparty.gender == 'woman' ? 'fa-venus' : this.thirdparty.gender == 'man' ? 'fa-mars' : 'fa-neuter';
+            return this.thirdparty.gender === 'woman' ? 'fa-venus' : this.thirdparty.gender === 'man' ? 'fa-mars' : 'fa-neuter';
         },
         birthdate: function(){
             var date = new Date(this.thirdparty.birthdate.datetime);
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 6d1497e2b..016db598c 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -1,5 +1,5 @@
 <template>
-  <div v-if="action === 'show'">
+   <div v-if="action === 'show'">
       <div class="flex-table">
          <third-party-render-box
             :thirdparty="thirdparty"

From 3040ed9483c3937051d6de85077c5c02aee87bbb Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Tue, 28 Sep 2021 16:26:59 +0200
Subject: [PATCH 06/45] tp onthefly: add add-address (wip)

---
 .../vuejs/_components/OnTheFly/ThirdParty.vue | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 016db598c..1f1df7e5f 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -43,11 +43,19 @@
             aria-describedby="phonenumber" />
       </div>
 
+      <add-address
+         :options="this.addAddress.options"
+         :address-changed-callback="submitAddress"
+         :context="this.addAddress.context"
+         >
+      </add-address>
+
    </div>
 </template>
 
 <script>
 import ThirdPartyRenderBox from '../Entity/ThirdPartyRenderBox.vue';
+import AddAddress from 'ChillMainAssets/vuejs/Address/components/AddAddress';
 import { getThirdparty, postThirdparty } from '../../_api/OnTheFly';
 
 export default {
@@ -55,11 +63,31 @@ export default {
    props: ['id', 'type', 'action'],
    components: {
       ThirdPartyRenderBox,
+      AddAddress
    },
    data: function() {
       return {
          thirdparty: {
             type: 'thirdparty'
+         },
+         addAddress: {
+            context: {
+               
+            },
+            options: {
+               //button: {
+               //   text:  {
+               //      create: 'courselocation.add_temporary_address',
+               //      edit: 'courselocation.edit_temporary_address'
+               //   }
+               //},
+               //title: {
+               //   create: 'courselocation.add_temporary_address',
+               //   edit: 'courselocation.edit_temporary_address'
+               //},
+               openPanesInModal: true,
+               hideAddress: true
+            }
          }
       }
    },
@@ -70,6 +98,9 @@ export default {
             resolve();
          }));
       },
+      submitAddress(payload) {
+         console.log(payload);
+      },
       postData() {
          postThirdparty(this.thirdparty).then(thirdparty => new Promise((resolve, reject) => {
             this.thirdparty = thirdparty;

From a26d27851008e2b5d859076945398b422e0ceaf8 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 11:16:18 +0200
Subject: [PATCH 07/45] comment console.log

---
 .../ChillMainBundle/Resources/public/lib/api/scope.js       | 4 ++--
 .../vuejs/AccompanyingCourse/components/CourseLocation.vue  | 6 +++---
 .../public/vuejs/AccompanyingCourse/store/index.js          | 2 +-
 .../Resources/public/vuejs/_components/AddPersons.vue       | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/lib/api/scope.js b/src/Bundle/ChillMainBundle/Resources/public/lib/api/scope.js
index a8df4ed88..9073822bb 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/lib/api/scope.js
+++ b/src/Bundle/ChillMainBundle/Resources/public/lib/api/scope.js
@@ -4,9 +4,9 @@ const fetchScopes = () => {
       return response.json();
     }
   }).then(data => {
-    console.log(data);
+    //console.log(data);
     return new Promise((resolve, reject) => {
-      console.log(data);
+      //console.log(data);
       resolve(data.results);
     });
   });
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
index afe13845c..b983c89b6 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
@@ -153,9 +153,9 @@ export default {
    created() {
       this.initAddressContext();
 
-      console.log('ac.locationStatus', this.accompanyingCourse.locationStatus);
-      console.log('ac.location (temporary location)', this.accompanyingCourse.location);
-      console.log('ac.personLocation', this.accompanyingCourse.personLocation);
+      //console.log('ac.locationStatus', this.accompanyingCourse.locationStatus);
+      //console.log('ac.location (temporary location)', this.accompanyingCourse.location);
+      //console.log('ac.personLocation', this.accompanyingCourse.personLocation);
    }
 }
 </script>
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
index 5784e8d4c..b66f4d957 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
@@ -48,7 +48,7 @@ let initPromise = Promise.all([scopesPromise, accompanyingCoursePromise])
                return state.accompanyingCourse.location !== null;
             },
             isScopeValid(state) {
-               console.log('is scope valid', state.accompanyingCourse.scopes.length > 0);
+               //console.log('is scope valid', state.accompanyingCourse.scopes.length > 0);
                return state.accompanyingCourse.scopes.length > 0;
             },
             validationKeys(state, getters) {
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
index 160d5d00b..a0e8fbebf 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
@@ -229,7 +229,7 @@ export default {
          return item.result.type + item.result.id;
       },
       addPriorSuggestion() {
-         console.log('echo', this.hasPriorSuggestion);
+         //console.log('addPriorSuggestion', this.hasPriorSuggestion);
          if (this.hasPriorSuggestion) {
             console.log('addPriorSuggestion',);
             this.suggested.unshift(this.priorSuggestion);

From 0fe248320dbeb86da63736e817b942a0604b2bf4 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 11:21:45 +0200
Subject: [PATCH 08/45] OnTheFly (otf): fix clickable radio tab on create modal

---
 .../Resources/public/vuejs/_components/OnTheFly/Create.vue    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
index 3ffb3f7df..7644043fd 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
@@ -3,7 +3,7 @@
       <li class="nav-item">
          <a class="nav-link" :class="{ active: isActive('person') }">
             <label for="person">
-               <input type="radio" name="person" v-model="radioType" value="person">
+               <input type="radio" name="person" id="person" v-model="radioType" value="person">
                {{ $t('onthefly.create.person') }}
             </label>
          </a>
@@ -11,7 +11,7 @@
       <li class="nav-item">
          <a class="nav-link" :class="{ active: isActive('thirdparty') }">
             <label for="thirdparty">
-               <input type="radio" name="thirdparty" v-model="radioType" value="thirdparty">
+               <input type="radio" name="thirdparty" id="thirdparty" v-model="radioType" value="thirdparty">
                {{ $t('onthefly.create.thirdparty') }}
             </label>
          </a>

From 3824a380ff389484689d629ae6635a67331fb052 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 11:37:53 +0200
Subject: [PATCH 09/45] otf: prepare with debug (wip)

---
 .../public/vuejs/_components/OnTheFly.vue     | 12 +++++++-----
 .../vuejs/_components/OnTheFly/Create.vue     |  1 +
 .../vuejs/_components/OnTheFly/Person.vue     | 12 ++++++++++--
 .../vuejs/_components/OnTheFly/ThirdParty.vue | 19 ++++++++++---------
 4 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
index 9e5efd86c..43cd0c686 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
@@ -134,6 +134,8 @@ export default {
    },
    methods: {
       openModal() {
+         console.log('## OPEN ON THE FLY MODAL');
+         console.log('## type:', this.type, ', action:', this.action);
          this.modal.showModal = true;
          this.$nextTick(function() {
             //this.$refs.search.focus();
@@ -173,11 +175,11 @@ export default {
 
          this.modal.showModal = false;
       },
-      goToLocation(id, type){
-         if(type == 'person'){
-            window.location = `../../person/${id}/general`
-         } else if(type == 'thirdparty') {
-            window.location = `../../thirdparty/thirdparty/${id}/show`
+      goToLocation(id, type) {
+         if (type == 'person') {
+            window.location = `../../person/${id}/general`;
+         } else if (type == 'thirdparty') {
+            window.location = `../../thirdparty/thirdparty/${id}/show`;
          }
       }
    }
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
index 7644043fd..c5d949c4e 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
@@ -56,6 +56,7 @@ export default {
       radioType: {
          set(type) {
             this.type = type;
+            console.log('## type:', type, ', action:', this.action);
          },
          get() {
             return this.type;
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
index 5261b2c81..bf559fd41 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
@@ -40,7 +40,7 @@
          <option value="man">{{ $t('person.gender.man') }}</option>
          <option value="neuter">{{ $t('person.gender.neuter') }}</option>
       </select>
-      <label for="gender">{{ $t('person.gender.title') }}</label>
+      <label>{{ $t('person.gender.title') }}</label>
    </div>
 
    <div class="input-group mb-3">
@@ -159,9 +159,17 @@ export default {
          getPerson(this.id)
             .then(person => new Promise((resolve, reject) => {
                this.person = person;
-               //console.log('get person', this.person);
+               console.log('get person', this.person);
                resolve();
          }));
+      },
+      postData() {
+         postPerson(this.person)
+            .then(person => new Promise((resolve, reject) => {
+               this.person = person;
+               console.log('post person', this.person);
+               resolve();
+         }))
       }
    }
 }
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 1f1df7e5f..7fc8fd827 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -45,9 +45,8 @@
 
       <add-address
          :options="this.addAddress.options"
-         :address-changed-callback="submitAddress"
          :context="this.addAddress.context"
-         >
+         :address-changed-callback="submitAddress">
       </add-address>
 
    </div>
@@ -72,7 +71,7 @@ export default {
          },
          addAddress: {
             context: {
-               
+
             },
             options: {
                //button: {
@@ -92,25 +91,27 @@ export default {
       }
    },
    methods: {
-      loadThirdparty(){
+      loadData(){
          getThirdparty(this.id).then(thirdparty => new Promise((resolve, reject) => {
             this.thirdparty = thirdparty;
+            console.log('get thirdparty', thirdparty);
             resolve();
          }));
       },
-      submitAddress(payload) {
-         console.log(payload);
-      },
       postData() {
          postThirdparty(this.thirdparty).then(thirdparty => new Promise((resolve, reject) => {
             this.thirdparty = thirdparty;
+            console.log('post thirdparty', thirdparty);
             resolve();
          }))
+      },
+      submitAddress(payload) {
+         console.log('submitAddress', payload);
       }
    },
    mounted() {
-      if (this.action !== 'create'){
-         this.loadThirdparty();
+      if (this.action !== 'create') {
+         this.loadData();
       }
    },
 }

From fc1dd499c48b3acc160f292e3b756ad4f6601c11 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 29 Sep 2021 11:41:08 +0200
Subject: [PATCH 10/45] POST, PUT, PATCH working for thirdparty and added to
 swagger. Assert for 'centers'(temporarily) removed from thirdparty entity

---
 .../ChillThirdPartyExtension.php              | 16 ------------
 .../Entity/ThirdParty.php                     |  7 +++--
 .../chill.api.specs.yaml                      | 26 ++++++++++++++++---
 3 files changed, 25 insertions(+), 24 deletions(-)

diff --git a/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php b/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
index 2fd0f723d..5ebac821b 100644
--- a/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
+++ b/src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php
@@ -62,22 +62,6 @@ class ChillThirdPartyExtension extends Extension implements PrependExtensionInte
                     //'base_role' => \Chill\ThirdPartyBundle\Security\Authorization\ThirdPartyVoter::SHOW,
                     //'controller' => \Chill\ThirdPartyBundle\Controller\ThirdPartyApiController::class,
                     'actions' => [
-                        '_index' => [
-                            'methods' => [
-                                Request::METHOD_GET => true,
-                                Request::METHOD_HEAD => true,
-                                Request::METHOD_POST => true,
-                                Request::METHOD_PATCH => true,
-                                Request::METHOD_PUT => true
-                            ],
-                            'roles' => [
-                                Request::METHOD_GET => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::SHOW,
-                                Request::METHOD_HEAD => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::SHOW,
-                                Request::METHOD_POST => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE,
-                                Request::METHOD_PUT => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE,
-                                Request::METHOD_PATCH => \Chill\ThirdPartyBundle\Security\Voter\ThirdPartyVoter::CREATE
-                            ],
-                        ],
                         '_entity' => [
                             'methods' => [
                                 Request::METHOD_GET => true,
diff --git a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
index 842e57b8b..30f28791b 100644
--- a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
+++ b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
@@ -96,7 +96,7 @@ class ThirdParty
      * @ORM\Column(name="types", type="json", nullable=true)
      * @Assert\Count(min=1)
      */
-    private $type;
+    private $types;
 
     /**
      * Contact Persons: One Institutional ThirdParty has Many Contact Persons
@@ -170,7 +170,6 @@ class ThirdParty
      * @var Collection
      * @ORM\ManyToMany(targetEntity="\Chill\MainBundle\Entity\Center")
      * @ORM\JoinTable(name="chill_3party.party_center")
-     * @Assert\Count(min=1)
      */
     private $centers;
 
@@ -327,7 +326,7 @@ class ThirdParty
      * @param array|null $type
      * @return ThirdParty
      */
-    public function setType(array $type = null)
+    public function setTypes(array $type = null)
     {
         // remove all keys from the input data
         $this->type = \array_values($type);
@@ -340,7 +339,7 @@ class ThirdParty
      *
      * @return array|null
      */
-    public function getType()
+    public function getTypes()
     {
         return $this->type;
     }
diff --git a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
index c5d9346ba..50f0af70f 100644
--- a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
+++ b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
@@ -16,14 +16,32 @@ components:
         id:
           type: integer
           readOnly: true
+        type:
+          type: string
+          enum:
+            - "thirdparty"
         name:
           type: string
-        nameCompany:
-          type: string
-        acronym:
-          type: string
         email:
           type: string
+        telephone:
+          type: string
+        comment:
+          type: string
+    #     centers:
+    #       type: array
+    #       items:
+    #         type: object
+    #         $ref: "#/components/schemas/CenterById"
+    # CenterById:
+    #   type: object
+    #   properties:
+    #     type:
+    #       type: string
+    #       enum:
+    #         - "Center"
+    #     id:
+    #       type: integer
 
 paths:
   /1.0/thirdparty/thirdparty.json:

From 302f60e722f73ecf91b7fb37f7d52fff4555df95 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 12:14:58 +0200
Subject: [PATCH 11/45] addAddress: remove commented old method

---
 .../public/vuejs/Address/components/AddAddress.vue  | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
index 38afeae80..8f60ef1c1 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
@@ -705,20 +705,7 @@ export default {
                this.errorMsg.push(error);
                this.flag.loading = false;
             });
-      },
-
-      /*
-      *  Method just add closing pane to the callback method
-      *  (get out step1 show pane, submit button)
-      closePaneAndCallbackSubmit(payload)
-      {
-         //this.initForm();
-         //this.resetPane(); // because parent callback will cast afterLastPaneAction()
-         console.log('will call parent callback method', payload);
-         // callback props method from parent
-         this.addressChangedCallback(payload);
       }
-      */
    }
 }
 </script>

From 86c5376cc27d366243a79cc7456839137f9b820a Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 13:35:33 +0200
Subject: [PATCH 12/45] bypass ACL restriction

fix response 500 when otf create new person
---
 .../ChillPersonBundle/Controller/PersonApiController.php      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php b/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
index b3f4087eb..17635a8fa 100644
--- a/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
@@ -45,9 +45,9 @@ class PersonApiController extends ApiController
         $person = parent::createEntity($action, $request);
 
         // TODO temporary hack to allow creation of person with fake center
-        $centers = $this->authorizationHelper->getReachableCenters($this->getUser(),
+        /* $centers = $this->authorizationHelper->getReachableCenters($this->getUser(),
             new Role(PersonVoter::CREATE));
-        $person->setCenter($centers[0]);
+        $person->setCenter($centers[0]); */
 
         return $person;
     }

From f2ebb1f33c695b223f05ee4eaea7d5a676be6a0b Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 29 Sep 2021 14:22:55 +0200
Subject: [PATCH 13/45] PATCH added for person endpoint

---
 .../ChillPersonExtension.php                  |  3 +-
 .../ChillPersonBundle/chill.api.specs.yaml    | 29 +++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/src/Bundle/ChillPersonBundle/DependencyInjection/ChillPersonExtension.php b/src/Bundle/ChillPersonBundle/DependencyInjection/ChillPersonExtension.php
index 485185ce7..d597e3572 100644
--- a/src/Bundle/ChillPersonBundle/DependencyInjection/ChillPersonExtension.php
+++ b/src/Bundle/ChillPersonBundle/DependencyInjection/ChillPersonExtension.php
@@ -640,12 +640,13 @@ class ChillPersonExtension extends Extension implements PrependExtensionInterfac
                                 Request::METHOD_GET => true,
                                 Request::METHOD_HEAD => true,
                                 Request::METHOD_POST=> true,
+                                Request::METHOD_PATCH => true
                             ],
                             'roles' => [
                                 Request::METHOD_GET => \Chill\PersonBundle\Security\Authorization\PersonVoter::SEE,
                                 Request::METHOD_HEAD => \Chill\PersonBundle\Security\Authorization\PersonVoter::SEE,
                                 Request::METHOD_POST => \Chill\PersonBundle\Security\Authorization\PersonVoter::CREATE,
-
+                                Request::METHOD_PATCH => \Chill\PersonBundle\Security\Authorization\PersonVoter::CREATE,
                             ],
                         ],
                         'address' => [
diff --git a/src/Bundle/ChillPersonBundle/chill.api.specs.yaml b/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
index 020fa409f..2ebb35d00 100644
--- a/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
+++ b/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
@@ -298,6 +298,35 @@ paths:
                 $ref: "#/components/schemas/Person"
         403:
           description: "Unauthorized"
+    patch:
+      tags:
+        - person
+      summary: "Alter a person"
+      parameters:
+        - name: id
+          in: path
+          required: true
+          description: The person's id
+          schema:
+            type: integer
+            format: integer
+            minimum: 1
+      requestBody:
+        description: "A person"
+        required: true
+        content:
+          application/json:
+            schema:
+              $ref: "#/components/schemas/Person"
+      responses:
+      401:
+        description: "Unauthorized"
+      404:
+        description: "Not found"
+      200:
+        description: "OK"
+      422:
+        description: "Object with validation errors"
 
   /1.0/person/person.json:
     post:

From bfd95bff39b2935b560aa7d09050d4b8d2bac011 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 14:56:25 +0200
Subject: [PATCH 14/45] otf: add patch api endpoint for person and thirdparty

---
 .../Resources/public/vuejs/_api/OnTheFly.js   | 27 +++++++++++++---
 .../vuejs/_components/OnTheFly/Person.vue     |  7 +++--
 .../Resources/public/vuejs/_api/OnTheFly.js   | 31 +++++++++++++++----
 .../vuejs/_components/OnTheFly/ThirdParty.vue |  8 ++---
 4 files changed, 56 insertions(+), 17 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js
index 6adbc7028..c8031da58 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js
@@ -27,8 +27,27 @@ const postPerson = (body) => {
          throw Error('Error with request resource response');
       });
 };
-   
-export { 
-   getPerson, 
-   postPerson 
+
+/*
+* PATCH an existing person
+*/
+const patchPerson = (id, body) => {
+    const url = `/api/1.0/person/person/${id}.json`;
+    return fetch(url, {
+        method: 'PATCH',
+        headers: {
+            'Content-Type': 'application/json;charset=utf-8'
+        },
+        body: JSON.stringify(body)
+    })
+        .then(response => {
+            if (response.ok) { return response.json(); }
+            throw Error('Error with request resource response');
+        });
+};
+
+export {
+   getPerson,
+   postPerson,
+   patchPerson
 };
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
index bf559fd41..1956034cb 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
@@ -163,11 +163,12 @@ export default {
                resolve();
          }));
       },
-      postData() {
-         postPerson(this.person)
+      patchData() {
+         console.log('id', this.id, 'and body', this.person);
+         patchPerson(this.id, this.person)
             .then(person => new Promise((resolve, reject) => {
                this.person = person;
-               console.log('post person', this.person);
+               console.log('patch person', this.person);
                resolve();
          }))
       }
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_api/OnTheFly.js b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_api/OnTheFly.js
index ed91ef415..91ea41b7d 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_api/OnTheFly.js
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_api/OnTheFly.js
@@ -13,7 +13,7 @@ const getThirdparty = (id) => {
 };
 
 /*
-* POST a new person
+* POST a new thirdparty
 */
 const postThirdparty = (body) => {
    const url = `/api/1.0/thirdparty/thirdparty.json`;
@@ -29,8 +29,27 @@ const postThirdparty = (body) => {
          throw Error('Error with request resource response');
       });
 };
-   
-export { 
-   getThirdparty, 
-   postThirdparty 
-};
\ No newline at end of file
+
+/*
+* PATCH an existing thirdparty
+*/
+const patchThirdparty = (id, body) => {
+    const url = `/api/1.0/thirdparty/thirdparty/${id}.json`;
+    return fetch(url, {
+        method: 'PATCH',
+        headers: {
+            'Content-Type': 'application/json;charset=utf-8'
+        },
+        body: JSON.stringify(body)
+    })
+        .then(response => {
+            if (response.ok) { return response.json(); }
+            throw Error('Error with request resource response');
+        });
+};
+
+export {
+   getThirdparty,
+   postThirdparty,
+   patchThirdparty
+};
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 7fc8fd827..d89012afc 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -55,7 +55,7 @@
 <script>
 import ThirdPartyRenderBox from '../Entity/ThirdPartyRenderBox.vue';
 import AddAddress from 'ChillMainAssets/vuejs/Address/components/AddAddress';
-import { getThirdparty, postThirdparty } from '../../_api/OnTheFly';
+import { getThirdparty, patchThirdparty } from '../../_api/OnTheFly';
 
 export default {
    name: "OnTheFlyThirdParty",
@@ -98,10 +98,10 @@ export default {
             resolve();
          }));
       },
-      postData() {
-         postThirdparty(this.thirdparty).then(thirdparty => new Promise((resolve, reject) => {
+      patchData() {
+         patchThirdparty(this.thirdparty).then(thirdparty => new Promise((resolve, reject) => {
             this.thirdparty = thirdparty;
-            console.log('post thirdparty', thirdparty);
+            console.log('patch thirdparty', thirdparty);
             resolve();
          }))
       },

From ba982833486b71cc04f1dabedb4eab2a2fb99382 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 29 Sep 2021 15:02:54 +0200
Subject: [PATCH 15/45] fix specs.yaml indentation

---
 .../ChillPersonBundle/chill.api.specs.yaml       | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/chill.api.specs.yaml b/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
index 2ebb35d00..646d1fb19 100644
--- a/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
+++ b/src/Bundle/ChillPersonBundle/chill.api.specs.yaml
@@ -319,14 +319,14 @@ paths:
             schema:
               $ref: "#/components/schemas/Person"
       responses:
-      401:
-        description: "Unauthorized"
-      404:
-        description: "Not found"
-      200:
-        description: "OK"
-      422:
-        description: "Object with validation errors"
+        401:
+          description: "Unauthorized"
+        404:
+          description: "Not found"
+        200:
+          description: "OK"
+        422:
+          description: "Object with validation errors"
 
   /1.0/person/person.json:
     post:

From 008a10dab80a34b8d16f86c085948c30be57b29d Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 17:35:37 +0200
Subject: [PATCH 16/45] otf: patch person and thirdparty from the store, emit
 parent method saveFormOnTheFly()

---
 .../PersonsAssociated/ParticipationItem.vue   | 23 +++----
 .../components/Requestor.vue                  | 13 ++--
 .../components/Resources/ResourceItem.vue     | 11 +++-
 .../vuejs/AccompanyingCourse/store/index.js   | 64 +++++++++++++++++++
 .../public/vuejs/_components/AddPersons.vue   | 19 +++---
 .../vuejs/_components/OnTheFly/Person.vue     | 11 +---
 .../vuejs/_components/OnTheFly/ThirdParty.vue |  9 +--
 7 files changed, 103 insertions(+), 47 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
index 7f01c87e9..6566b00e4 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
@@ -19,20 +19,8 @@
                v-if="hasCurrentHouseholdAddress"
                v-bind:person="participation.person">
             </button-location>
-            <li>
-               <on-the-fly
-                  v-bind:type="participation.person.type"
-                  v-bind:id="participation.person.id"
-                  action="show">
-               </on-the-fly>
-            </li>
-            <li>
-               <on-the-fly
-                  v-bind:type="participation.person.type"
-                  v-bind:id="participation.person.id"
-                  action="edit">
-               </on-the-fly>
-            </li>
+            <li><on-the-fly :type="participation.person.type" :id="participation.person.id" action="show"></on-the-fly></li>
+            <li><on-the-fly :type="participation.person.type" :id="participation.person.id" action="edit" @saveFormOnTheFly="saveFormOnTheFly"></on-the-fly></li>
             <!-- <li>
                <button class="btn btn-delete"
                   :title="$t('action.delete')"
@@ -112,6 +100,13 @@ export default {
       getAccompanyingCourseReturnPath() {
          return `fr/parcours/${this.$store.state.accompanyingCourse.id}/edit#section-10`;
       }
+   },
+   methods: {
+      saveFormOnTheFly(payload) {
+         console.log('saveFormOnTheFly: type', payload.type, ', data', payload.data);
+         payload.target = 'participation';
+         this.$store.dispatch('patchOnTheFly', payload);
+      }
    }
 }
 
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
index 7342eed66..4ea404729 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
@@ -10,7 +10,7 @@
          {{ $t('requestor.is_anonymous') }}
       </label>
 
-      <third-party-render-box v-if="accompanyingCourse.requestor.type == 'thirdparty'"
+      <third-party-render-box v-if="accompanyingCourse.requestor.type === 'thirdparty'"
          :thirdparty="accompanyingCourse.requestor"
          :options="{
             addLink: false,
@@ -25,12 +25,12 @@
          <ul class="record_actions">
             <button-location v-if="hasCurrentHouseholdAddress" :thirdparty="accompanyingCourse.requestor"></button-location>
             <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="show"></on-the-fly></li>
-            <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="edit"></on-the-fly></li>
+            <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="edit" @saveFormOnTheFly="saveFormOnTheFly"></on-the-fly></li>
          </ul>
       </template>
       </third-party-render-box>
 
-      <person-render-box render="bloc" v-else-if="accompanyingCourse.requestor.type == 'person'"
+      <person-render-box render="bloc" v-else-if="accompanyingCourse.requestor.type === 'person'"
          :person="accompanyingCourse.requestor"
          :options="{
             addLink: false,
@@ -46,7 +46,7 @@
          <ul class="record_actions">
             <button-location v-if="hasCurrentHouseholdAddress" :person="accompanyingCourse.requestor"></button-location>
             <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="show"></on-the-fly></li>
-            <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="edit"></on-the-fly></li>
+            <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="edit" @saveFormOnTheFly="saveFormOnTheFly"></on-the-fly></li>
          </ul>
       </template>
       </person-render-box>
@@ -129,6 +129,11 @@ export default {
          this.$store.dispatch('addRequestor', selected.shift());
          this.$refs.addPersons.resetSearch(); // to cast child method
          modal.showModal = false;
+      },
+      saveFormOnTheFly(payload) {
+         console.log('saveFormOnTheFly: type', payload.type, ', data', payload.data);
+         payload.target = 'requestor';
+         this.$store.dispatch('patchOnTheFly', payload);
       }
    }
 }
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
index fe66366f0..0a43a3589 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
@@ -8,7 +8,7 @@
          <ul class="record_actions">
             <button-location v-if="hasCurrentHouseholdAddress" :person="resource.resource"></button-location>
             <li><on-the-fly :type="resource.resource.type" :id="resource.resource.id" action="show"></on-the-fly></li>
-            <li><on-the-fly :type="resource.resource.type" :id="resource.resource.id" action="edit"></on-the-fly></li>
+            <li><on-the-fly :type="resource.resource.type" :id="resource.resource.id" action="edit" @saveFormOnTheFly="saveFormOnTheFly"></on-the-fly></li>
             <li><button class="btn btn-sm btn-remove" :title="$t('action.remove')" @click.prevent="$emit('remove', resource)"></button></li>
          </ul>
       </template>
@@ -22,7 +22,7 @@
       <template v-slot:record-actions>
          <ul class="record_actions">
             <li><on-the-fly :type="resource.resource.type" :id="resource.resource.id" action="show"></on-the-fly></li>
-            <li><on-the-fly :type="resource.resource.type" :id="resource.resource.id" action="edit"></on-the-fly></li>
+            <li><on-the-fly :type="resource.resource.type" :id="resource.resource.id" action="edit" @saveFormOnTheFly="saveFormOnTheFly"></on-the-fly></li>
             <li><button class="btn btn-sm btn-remove" :title="$t('action.remove')" @click.prevent="$emit('remove', resource)"></button></li>
          </ul>
       </template>
@@ -53,6 +53,13 @@ export default {
          }
          return false;
       }
+   },
+   methods: {
+      saveFormOnTheFly(payload) {
+         console.log('saveFormOnTheFly: type', payload.type, ', data', payload.data);
+         payload.target = 'resource';
+         this.$store.dispatch('patchOnTheFly', payload);
+      }
    }
 }
 </script>
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
index b66f4d957..382d2c0c3 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
@@ -11,6 +11,8 @@ import { getAccompanyingCourse,
    addScope,
    removeScope,
 } from '../api';
+import { patchPerson } from "ChillPersonAssets/vuejs/_api/OnTheFly";
+import { patchThirdparty } from "ChillThirdPartyAssets/vuejs/_api/OnTheFly";
 
 
 const debug = process.env.NODE_ENV !== 'production';
@@ -107,6 +109,36 @@ let initPromise = Promise.all([scopesPromise, accompanyingCoursePromise])
                //console.log('### mutation: addResource', resource);
                state.accompanyingCourse.resources.push(resource);
             },
+            updatePerson(state, payload) {
+               console.log('### mutation: updatePerson', payload);
+               let i = null;
+               switch (payload.target) {
+                  case 'participation':
+                     i = state.accompanyingCourse.participations.findIndex(e => e.person.id === payload.person.id );
+                     state.accompanyingCourse.participations[i].person = payload.person;
+                     break;
+                  case 'requestor':
+                     state.accompanyingCourse.requestor = payload.person;
+                     break;
+                  case 'resource':
+                     i = state.accompanyingCourse.resources.findIndex(e => e.resource.id === payload.person.id );
+                     state.accompanyingCourse.resources[i].resource = payload.person;
+                     break;
+               }
+            },
+            updateThirdparty(state, payload) {
+               console.log('### mutation: updateThirdparty', payload);
+               let i = null;
+               switch (payload.target) {
+                  case 'requestor':
+                     state.accompanyingCourse.requestor = payload.thirdparty;
+                     break;
+                  case 'resource':
+                     i = state.accompanyingCourse.resources.findIndex(e => e.resource.id === payload.thirdparty.id );
+                     state.accompanyingCourse.resources[i].resource = payload.thirdparty;
+                     break;
+               }
+            },
             toggleIntensity(state, value) {
                state.accompanyingCourse.intensity = value;
             },
@@ -239,6 +271,38 @@ let initPromise = Promise.all([scopesPromise, accompanyingCoursePromise])
                   resolve();
                })).catch((error) => { commit('catchError', error) });
             },
+            patchOnTheFly({ commit }, payload) {
+               console.log('## action: patch OnTheFly', payload);
+               let body = { type: payload.type };
+               if (payload.type === 'person') {
+                  body.firstName = payload.data.firstName;
+                  body.lastName = payload.data.lastName;
+                  if (payload.data.birthdate !== null) { body.birthdate = payload.data.birthdate; }
+                  body.phonenumber = payload.data.phonenumber;
+                  body.mobilenumber = payload.data.mobilenumber;
+                  body.gender = payload.data.gender;
+                  console.log('id', payload.data.id, 'and body', body);
+                  patchPerson(payload.data.id, body)
+                      .then(person => new Promise((resolve, reject) => {
+                         console.log('patch person', person);
+                         commit('updatePerson', { target: payload.target, person: person });
+                         resolve();
+                      }));
+               }
+               else if (payload.type === 'thirdparty') {
+                  body.name = payload.data.name;
+                  body.email = payload.data.email;
+                  body.phonenumber = payload.data.phonenumber;
+                  body.address = { address_id: payload.data.address.address_id };
+                  console.log('id', payload.data.id, 'and body', body);
+                  patchThirdparty(payload.data.id, body)
+                      .then(thirdparty => new Promise((resolve, reject) => {
+                          console.log('patch thirdparty', thirdparty);
+                          commit('updateThirdparty', { target: payload.target, thirdparty: thirdparty });
+                          resolve();
+                  }));
+               }
+            },
             toggleIntensity({ commit }, payload) {
                //console.log(payload);
                patchAccompanyingCourse(id, { type: "accompanying_period", intensity: payload })
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
index a0e8fbebf..82243c96f 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
@@ -92,6 +92,7 @@ import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
 import PersonSuggestion from './AddPersons/PersonSuggestion';
 import { searchPersons, searchPersons_2 } from 'ChillPersonAssets/vuejs/_api/AddPersons';
 import { postPerson } from "ChillPersonAssets/vuejs/_api/OnTheFly";
+import { postThirdparty } from "ChillThirdPartyAssets/vuejs/_api/OnTheFly";
 
 export default {
    name: 'AddPersons',
@@ -254,25 +255,25 @@ export default {
          }
       },
       saveFormOnTheFly({ type, data }) {
-         console.log('saveFormOnTheFly from addPersons', { type, data });
-
-         // create/edit person
+         console.log('saveFormOnTheFly from addPersons, type', type, ', data', data);
          if (type === 'person') {
-
             console.log('type person with', data);
             postPerson(data)
                .then(person => new Promise((resolve, reject) => {
-                  //this.person = person;
+                  console.log('onthefly create: post person', person);
                   this.newPriorSuggestion(person);
                   resolve();
                }));
          }
-
-         // create/edit thirdparty
          else if (type === 'thirdparty') {
-            console.log('not yet implemented: type thirdparty with', type, data);
+            console.log('type thirdparty with', data);
+            postThirdparty(data)
+               .then(thirdparty => new Promise((resolve, reject) => {
+                  console.log('onthefly create: post thirdparty', thirdparty);
+                  this.newPriorSuggestion(thirdparty);
+                  resolve();
+               }));
          }
-
       }
    },
 }
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
index 1956034cb..d0627753a 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue
@@ -75,7 +75,7 @@
 </template>
 
 <script>
-import { getPerson, postPerson } from '../../_api/OnTheFly';
+import { getPerson } from '../../_api/OnTheFly';
 import PersonRenderBox from '../Entity/PersonRenderBox.vue';
 
 export default {
@@ -162,15 +162,6 @@ export default {
                console.log('get person', this.person);
                resolve();
          }));
-      },
-      patchData() {
-         console.log('id', this.id, 'and body', this.person);
-         patchPerson(this.id, this.person)
-            .then(person => new Promise((resolve, reject) => {
-               this.person = person;
-               console.log('patch person', this.person);
-               resolve();
-         }))
       }
    }
 }
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index d89012afc..f68b00c4c 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -55,7 +55,7 @@
 <script>
 import ThirdPartyRenderBox from '../Entity/ThirdPartyRenderBox.vue';
 import AddAddress from 'ChillMainAssets/vuejs/Address/components/AddAddress';
-import { getThirdparty, patchThirdparty } from '../../_api/OnTheFly';
+import { getThirdparty } from '../../_api/OnTheFly';
 
 export default {
    name: "OnTheFlyThirdParty",
@@ -98,13 +98,6 @@ export default {
             resolve();
          }));
       },
-      patchData() {
-         patchThirdparty(this.thirdparty).then(thirdparty => new Promise((resolve, reject) => {
-            this.thirdparty = thirdparty;
-            console.log('patch thirdparty', thirdparty);
-            resolve();
-         }))
-      },
       submitAddress(payload) {
          console.log('submitAddress', payload);
       }

From bac8e8d0b8da36c89a63bd115e6c063ecf4f020c Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 19:27:22 +0200
Subject: [PATCH 17/45] cleaning

---
 .../public/vuejs/_components/OnTheFly.vue        |  1 -
 .../PersonsAssociated/ParticipationItem.vue      | 16 ----------------
 .../public/vuejs/_components/AddPersons.vue      |  2 +-
 3 files changed, 1 insertion(+), 18 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
index 43cd0c686..329672f4e 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
@@ -146,7 +146,6 @@ export default {
       },
       saveAction() {
          console.log('saveAction button: create/edit action with', this.type);
-
          let
             type = this.type,
             data = {} ;
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
index 6566b00e4..c349ce159 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
@@ -109,20 +109,4 @@ export default {
       }
    }
 }
-
-/*
- *  dates of participation
- *
- *
- *
- *   <tr>
- *      <td><span v-if="participation.startDate">
- *          {{ $d(participation.startDate.datetime, 'short') }}</span>
- *      </td>
- *      <td><span v-if="participation.endDate">
- *          {{ $d(participation.endDate.datetime, 'short') }}</span>
- *      </td>
- *   </tr>
- *
-*/
 </script>
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
index 82243c96f..a31089f76 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
@@ -249,7 +249,7 @@ export default {
                result: entity
             }
             this.search.priorSuggestion = suggestion;
-            console.log('ici', this.search.priorSuggestion);
+            console.log('search priorSuggestion', this.search.priorSuggestion);
          } else {
             this.search.priorSuggestion = {};
          }

From 74b649fb2c4f9fd96784bcf636ba08daf5e3b3fb Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 19:27:49 +0200
Subject: [PATCH 18/45] no location button for requestor

---
 .../public/vuejs/AccompanyingCourse/components/Requestor.vue    | 2 --
 .../AccompanyingCourse/components/Resources/ResourceItem.vue    | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
index 4ea404729..437cc23e1 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
@@ -23,7 +23,6 @@
       >
       <template v-slot:record-actions>
          <ul class="record_actions">
-            <button-location v-if="hasCurrentHouseholdAddress" :thirdparty="accompanyingCourse.requestor"></button-location>
             <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="show"></on-the-fly></li>
             <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="edit" @saveFormOnTheFly="saveFormOnTheFly"></on-the-fly></li>
          </ul>
@@ -44,7 +43,6 @@
       >
       <template v-slot:record-actions>
          <ul class="record_actions">
-            <button-location v-if="hasCurrentHouseholdAddress" :person="accompanyingCourse.requestor"></button-location>
             <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="show"></on-the-fly></li>
             <li><on-the-fly :type="accompanyingCourse.requestor.type" :id="accompanyingCourse.requestor.id" action="edit" @saveFormOnTheFly="saveFormOnTheFly"></on-the-fly></li>
          </ul>
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
index 0a43a3589..f8a61b930 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
@@ -6,7 +6,9 @@
       >
       <template v-slot:record-actions>
          <ul class="record_actions">
+            <!--
             <button-location v-if="hasCurrentHouseholdAddress" :person="resource.resource"></button-location>
+            -->
             <li><on-the-fly :type="resource.resource.type" :id="resource.resource.id" action="show"></on-the-fly></li>
             <li><on-the-fly :type="resource.resource.type" :id="resource.resource.id" action="edit" @saveFormOnTheFly="saveFormOnTheFly"></on-the-fly></li>
             <li><button class="btn btn-sm btn-remove" :title="$t('action.remove')" @click.prevent="$emit('remove', resource)"></button></li>

From d8c34c3089c11f84d349a08fe41f167e462493e2 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Wed, 29 Sep 2021 19:53:28 +0200
Subject: [PATCH 19/45] otf: thirdparty corrections

---
 .../vuejs/AccompanyingCourse/store/index.js   |  2 +-
 .../Entity/ThirdPartyRenderBox.vue            | 28 ++-----------------
 2 files changed, 4 insertions(+), 26 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
index 382d2c0c3..c0946f702 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
@@ -290,7 +290,7 @@ let initPromise = Promise.all([scopesPromise, accompanyingCoursePromise])
                       }));
                }
                else if (payload.type === 'thirdparty') {
-                  body.name = payload.data.name;
+                  body.name = payload.data.text;
                   body.email = payload.data.email;
                   body.phonenumber = payload.data.phonenumber;
                   body.address = { address_id: payload.data.address.address_id };
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
index eddde6a67..c2714126a 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/Entity/ThirdPartyRenderBox.vue
@@ -19,14 +19,6 @@
                 </div>
 
                 <p v-if="this.options.addInfo === true" class="moreinfo">
-                    <i v-if="thirdparty.birthdate" :class="'fa fa-fw ' + getGenderIcon" title="{{ getGender }}"></i>
-                    <time v-if="thirdparty.birthdate" datetime="{{ thirdparty.birthdate.datetime }}" title="{{ birthdate }}">
-                        {{ $t(getGender) + ' ' + $d(birthdate, 'short') }}
-                    </time>
-                    <time v-else-if="thirdparty.deathdate" datetime="{{ thirdparty.deathdate.datetime }}" title="{{ thirdparty.deathdate }}">
-                        {{ birthdate }} - {{ deathdate }}
-                    </time>
-                    <span v-if="options.addAge === true" class="age">{{ thirdparty.age }}</span>
                 </p>
             </div>
         </div>
@@ -42,9 +34,9 @@
                        <i class="fa fa-li fa-map-marker"></i>
                        <address-render-box :address="thirdparty.address" :isMultiline="isMultiline"></address-render-box>
                     </li>
-                    <li v-if="thirdparty.telephone">
+                    <li v-if="thirdparty.phonenumber">
                        <i class="fa fa-li fa-mobile"></i>
-                       <a :href="'tel: ' + thirdparty.telephone">{{ thirdparty.telephone }}</a>
+                       <a :href="'tel: ' + thirdparty.phonenumber">{{ thirdparty.phonenumber }}</a>
                     </li>
                     <li v-if="thirdparty.email">
                        <i class="fa fa-li fa-envelope-o"></i>
@@ -78,21 +70,7 @@ export default {
             } else {
                 return false
             }
-        },
-        getGender: function() {
-            return this.thirdparty.gender === 'woman' ? 'renderbox.birthday.woman' : 'renderbox.birthday.man';
-        },
-        getGenderIcon: function() {
-            return this.thirdparty.gender === 'woman' ? 'fa-venus' : this.thirdparty.gender === 'man' ? 'fa-mars' : 'fa-neuter';
-        },
-        birthdate: function(){
-            var date = new Date(this.thirdparty.birthdate.datetime);
-            return dateToISO(date);
-        },
-        deathdate: function(){
-            var date = new Date(this.thirdparty.deathdate.datetime);
-            return dateToISO(date);
-        },
+        }
     }
 }
 </script>

From 14a13c7bd529104ea98ce7b358cad407744db9ff Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 11:55:28 +0200
Subject: [PATCH 20/45] CourseLocation: improve warning alerts

manually cherrypick from 5b0b1441d3c7ef0717f21adac8566e1beb1af52c on local branch resume_accourse
---
 .../components/CourseLocation.vue             | 28 +++++++++----------
 .../vuejs/AccompanyingCourse/js/i18n.js       |  4 +--
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
index e47b5d74f..047446be5 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
@@ -14,18 +14,6 @@
          </label>
       </div>
 
-      <div v-if="hasNoPersonLocation" class="alert alert-danger no-person-location">
-         <i class="fa fa-warning fa-2x"></i>
-         <div>
-            <p>
-               {{ $t('courselocation.associate_at_least_one_person_with_one_household_with_address') }}
-               <a href="#section-10">
-                  <i class="fa fa-level-up fa-fw"></i>
-               </a>
-            </p>
-         </div>
-      </div>
-
       <div class="flex-table" v-if="accompanyingCourse.location">
          <div class="item-bloc">
             <address-render-box
@@ -47,6 +35,18 @@
          </div>
       </div>
 
+      <div v-if="hasNoPersonLocation" class="alert alert-danger no-person-location">
+         <i class="fa fa-warning fa-2x"></i>
+         <div>
+            <p>
+               {{ $t('courselocation.associate_at_least_one_person_with_one_household_with_address') }}
+               <a href="#section-10">
+                  <i class="fa fa-level-up fa-fw"></i>
+               </a>
+            </p>
+         </div>
+      </div>
+
       <div>
          <ul class="record_actions">
             <li>
@@ -213,10 +213,10 @@ export default {
 div#accompanying-course {
    div.vue-component {
       & > div.alert.no-person-location {
-         margin: 0 0 -1em;
+         margin: 1px 0 0;
       }
       div.no-person-location {
-         padding-bottom: 1.5em;
+         padding-top: 1.5em;
          display: flex;
          flex-direction: row;
          & > i {
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
index 35f05b60e..5d1451ff3 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
@@ -49,7 +49,7 @@ const appMessages = {
          ok: "Oui, l'usager quitte le parcours",
          show_household_number: "Voir le ménage (n° {id})",
          show_household: "Voir le ménage",
-         person_without_household_warning: "Certaines personnes n'appartiennent à aucun ménage actuellement. Renseignez leur appartenance à un ménage dès que possible.",
+         person_without_household_warning: "Certaines usagers n'appartiennent actuellement à aucun ménage. Renseignez leur appartenance dès que possible.",
          update_household: "Modifier l'appartenance",
          participation_not_valid: "Sélectionnez ou créez au minimum 1 usager",
       },
@@ -83,7 +83,7 @@ const appMessages = {
          assign_course_address: "Désigner comme l'adresse du parcours",
          remove_button: "Enlever l'adresse",
          temporary_address_must_be_changed: "Cette adresse est temporaire. Le parcours devrait être localisé auprès d'un usager concerné.",
-         associate_at_least_one_person_with_one_household_with_address: "Associez au moins un membre du parcours à un ménage, et indiquez une adresse à ce ménage.",
+         associate_at_least_one_person_with_one_household_with_address: "Commencez d'abord par associer un membre du parcours à un ménage, et indiquez une adresse à ce ménage.",
          sure: "Êtes-vous sûr ?",
          sure_description: "Voulez-vous faire de cette adresse l'adresse du parcours ?",
          ok: "Désigner comme adresse du parcours",

From e2feea15f99c2eddad4502c9a9ad480b66314295 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 11:57:20 +0200
Subject: [PATCH 21/45] stash commit

---
 .../vuejs/AccompanyingCourse/store/index.js   |  2 +-
 .../vuejs/_components/OnTheFly/ThirdParty.vue | 49 ++++++++++++-------
 2 files changed, 32 insertions(+), 19 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
index c0946f702..22c91b0ef 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
@@ -292,7 +292,7 @@ let initPromise = Promise.all([scopesPromise, accompanyingCoursePromise])
                else if (payload.type === 'thirdparty') {
                   body.name = payload.data.text;
                   body.email = payload.data.email;
-                  body.phonenumber = payload.data.phonenumber;
+                  body.telephone = payload.data.phonenumber;
                   body.address = { address_id: payload.data.address.address_id };
                   console.log('id', payload.data.id, 'and body', body);
                   patchThirdparty(payload.data.id, body)
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index f68b00c4c..701bf38e8 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -21,7 +21,7 @@
    <div v-else-if="action === 'edit' || action === 'create'">
 
       <div class="form-floating mb-3">
-         <input class="form-control form-control-lg" id="name" v-model="thirdparty.name" v-bind:placeholder="$t('thirdparty.name')" />
+         <input class="form-control form-control-lg" id="name" v-model="thirdparty.text" v-bind:placeholder="$t('thirdparty.name')" />
          <label for="name">{{ $t('thirdparty.name') }}</label>
       </div>
 
@@ -42,12 +42,13 @@
             v-bind:aria-label="$t('thirdparty.phonenumber')"
             aria-describedby="phonenumber" />
       </div>
-
+      <!--
       <add-address
+         :context="this.context"
          :options="this.addAddress.options"
-         :context="this.addAddress.context"
          :address-changed-callback="submitAddress">
       </add-address>
+      -->
 
    </div>
 </template>
@@ -64,32 +65,44 @@ export default {
       ThirdPartyRenderBox,
       AddAddress
    },
-   data: function() {
+   data() {
       return {
          thirdparty: {
             type: 'thirdparty'
          },
          addAddress: {
-            context: {
-
-            },
             options: {
-               //button: {
-               //   text:  {
-               //      create: 'courselocation.add_temporary_address',
-               //      edit: 'courselocation.edit_temporary_address'
-               //   }
-               //},
-               //title: {
-               //   create: 'courselocation.add_temporary_address',
-               //   edit: 'courselocation.edit_temporary_address'
-               //},
                openPanesInModal: true,
-               hideAddress: true
+               hideAddress: false,
+               /*
+               button: {
+                  text:  {
+                     create: 'courselocation.add_temporary_address',
+                     edit: 'courselocation.edit_temporary_address'
+                  }
+               },
+               title: {
+                  create: 'courselocation.add_temporary_address',
+                  edit: 'courselocation.edit_temporary_address'
+               } */
             }
          }
       }
    },
+   computed: {
+      context() {
+         let context = {
+            target: {
+               name: this.type,
+               id: this.id
+            },
+            edit: false,
+            addressId: null
+         };
+         console.log('context', context);
+         return context;
+      },
+   },
    methods: {
       loadData(){
          getThirdparty(this.id).then(thirdparty => new Promise((resolve, reject) => {

From e9b1f442bc6d7925620ae14813ce055cd8b14839 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Thu, 30 Sep 2021 12:02:54 +0200
Subject: [PATCH 22/45] api docs adjusted to patch/post address on thirdparty

---
 .../chill.api.specs.yaml                      | 54 +++----------------
 1 file changed, 8 insertions(+), 46 deletions(-)

diff --git a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
index 50f0af70f..52db7589c 100644
--- a/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
+++ b/src/Bundle/ChillThirdPartyBundle/chill.api.specs.yaml
@@ -26,22 +26,14 @@ components:
           type: string
         telephone:
           type: string
-        comment:
-          type: string
-    #     centers:
-    #       type: array
-    #       items:
-    #         type: object
-    #         $ref: "#/components/schemas/CenterById"
-    # CenterById:
-    #   type: object
-    #   properties:
-    #     type:
-    #       type: string
-    #       enum:
-    #         - "Center"
-    #     id:
-    #       type: integer
+        address:
+          $ref: "#/components/schemas/Address"
+    Address:
+      type: object
+      properties:
+        id:
+          type: integer
+
 
 paths:
   /1.0/thirdparty/thirdparty.json:
@@ -118,33 +110,3 @@ paths:
           description: "OK"
         422:
           description: "Object with validation errors"
-    put:
-      tags:
-        - thirdparty
-      summary: Edit an existing thirdparty
-      parameters:
-        - name: id
-          in: path
-          required: true
-          description: The thirdparty's id
-          schema:
-            type: integer
-            format: integer
-            minimum: 1
-      requestBody:
-        required: true
-        content:
-          application/json:
-            schema:
-              $ref: "#/components/schemas/Thirdparty"
-      responses:
-        401:
-          description: "Unauthorized"
-        404:
-          description: "Not found"
-        200:
-          description: "OK"
-        422:
-          description: "Unprocessable entity (validation errors)"
-        400:
-          description: "Bad Request"

From 2f60ab4d17941040aa618d05d4ba4cfdba0e927a Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 12:35:36 +0200
Subject: [PATCH 23/45] fix chill_resolve_center in person banner when n
 centers > 1

---
 .../Resources/views/Person/banner_custom.html.twig   | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Person/banner_custom.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Person/banner_custom.html.twig
index 564f1803e..378eda5c5 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/Person/banner_custom.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/Person/banner_custom.html.twig
@@ -17,11 +17,19 @@
         {%- endif -%}
     </div>
     <div class="text-md-end">
-        {% if person|chill_resolve_center is not null%}
+        {% if person|chill_resolve_center is not null %}
             <span class="open_sansbold">
                 {{ 'Center'|trans|upper}} :
             </span>
-            {{  person|chill_resolve_center.name|upper }}
+
+            {% if person|chill_resolve_center is iterable %}
+                {% for c in person|chill_resolve_center %}
+                    {{  c.name|upper }}{% if not loop.last %}, {% endif %}
+                {% endfor %}
+            {% else %}
+                {{  person|chill_resolve_center.name|upper }}
+            {% endif %}
+
         {%- endif -%}
     </div>
 </div>

From 1eb8d04a329d05248b86b4c9bd35b36d605f68a1 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 13:23:11 +0200
Subject: [PATCH 24/45] fix property into json body with endpoint PATCH
 thirdparty

---
 .../Resources/public/vuejs/AccompanyingCourse/store/index.js    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
index 22c91b0ef..ca1a89aa9 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/store/index.js
@@ -293,7 +293,7 @@ let initPromise = Promise.all([scopesPromise, accompanyingCoursePromise])
                   body.name = payload.data.text;
                   body.email = payload.data.email;
                   body.telephone = payload.data.phonenumber;
-                  body.address = { address_id: payload.data.address.address_id };
+                  body.address = { id: payload.data.address.address_id };
                   console.log('id', payload.data.id, 'and body', body);
                   patchThirdparty(payload.data.id, body)
                       .then(thirdparty => new Promise((resolve, reject) => {

From decc3c7463db70002adfdc4cd0e7b5152a1e2ab3 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 13:44:04 +0200
Subject: [PATCH 25/45] otf: replace button by link in show modale

---
 .../public/vuejs/_components/OnTheFly.vue       | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
index 329672f4e..5f116e057 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
@@ -42,16 +42,16 @@
          </template>
 
          <template v-slot:footer>
-            <button v-if="action === 'show'"
-               @click="goToLocation(id, type)"
+            <a v-if="action === 'show'"
+               :href="buildLocation(id, type)"
                :title="$t(titleMessage)"
                class="btn btn-show">{{ $t(buttonMessage) }}
-            </button>
-            <button v-else
+            </a>
+            <a v-else
                class="btn btn-save"
                @click="saveAction">
                {{ $t('action.save')}}
-            </button>
+            </a>
          </template>
 
       </modal>
@@ -174,11 +174,12 @@ export default {
 
          this.modal.showModal = false;
       },
-      goToLocation(id, type) {
+      buildLocation(id, type) {
          if (type == 'person') {
-            window.location = `../../person/${id}/general`;
+            // TODO i18n
+            return `/fr/person/${id}/general`;
          } else if (type == 'thirdparty') {
-            window.location = `../../thirdparty/thirdparty/${id}/show`;
+            return `/fr/thirdparty/thirdparty/${id}/show`;
          }
       }
    }

From 577d665f0937afd22f383596ec1c0c933a4cbb77 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 14:36:01 +0200
Subject: [PATCH 26/45] batch replace hideAddress option by onlyButton

---
 .../public/vuejs/Address/components/AddAddress.vue        | 2 +-
 .../public/vuejs/Address/components/ShowPane.vue          | 8 ++++----
 .../Resources/public/vuejs/Address/index.js               | 2 +-
 .../Resources/views/Address/_insert_vue_address.html.twig | 4 ++--
 .../AccompanyingCourse/components/CourseLocation.vue      | 2 +-
 .../vuejs/HouseholdMembersEditor/components/Household.vue | 2 +-
 .../Resources/views/Household/summary.html.twig           | 2 +-
 .../public/vuejs/_components/OnTheFly/ThirdParty.vue      | 2 +-
 8 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
index 0a2904bff..0aa16d5e3 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
@@ -271,7 +271,7 @@ export default {
                validFrom: false,
                validTo: false
             },
-            hideAddress: false
+            onlyButton: false
          },
          entity: {
             address: {}, // <== loaded and returned
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue
index a4e5c571d..10161f761 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue
@@ -1,6 +1,6 @@
 <template>
 
-   <div v-if="!hideAddress">
+   <div v-if="!onlyButton">
       <div class="loading">
          <i v-if="flag.loading" class="fa fa-circle-o-notch fa-spin fa-2x fa-fw"></i>
          <span class="sr-only">{{ $t('loading') }}</span>
@@ -86,9 +86,9 @@ export default {
       getSuccessText() {
          return (this.context.edit) ? 'address_edit_success' : 'address_new_success';
       },
-      hideAddress() {
-         return (typeof this.options.hideAddress !== 'undefined') ?
-            this.options.hideAddress : this.defaultz.hideAddress;
+      onlyButton() {
+         return (typeof this.options.onlyButton !== 'undefined') ?
+            this.options.onlyButton : this.defaultz.onlyButton;
       },
       forceRedirect() {
          return (!(this.context.backUrl === null || typeof this.context.backUrl === 'undefined'));
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js
index f0a308b7b..9241aa29d 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/index.js
@@ -53,7 +53,7 @@ containers.forEach((container) => {
                         },
 
                         /// Don't display show renderbox Address: showPane display only a button
-                        hideAddress: container.dataset.hideAddress === 'true'       //boolean, default: false
+                        onlyButton: container.dataset.onlyButton === 'true'       //boolean, default: false
                     }
                 }
             }
diff --git a/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig b/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig
index f4f63c4eb..571f4257f 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/Address/_insert_vue_address.html.twig
@@ -18,7 +18,7 @@
     * stickyActions         bool (default: false)
     * useValidFrom          bool (default: false)
     * useValidTo            bool (default: false)
-    * hideAddress           bool (default: false)
+    * onlyButton           bool (default: false)
 #}
 <div class="address-container"
 
@@ -69,7 +69,7 @@
         data-use-valid-to="true"
     {% endif %}
 
-    {% if hideAddress is defined and hideAddress == 1 %}
+    {% if onlyButton is defined and onlyButton == 1 %}
         data-hide-address="true"
     {% endif %}
 ></div>
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
index 047446be5..79e983301 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/CourseLocation.vue
@@ -102,7 +102,7 @@ export default {
                   create: 'courselocation.add_temporary_address',
                   edit: 'courselocation.edit_temporary_address'
                },
-               hideAddress: true
+               onlyButton: true
             }
          }
       }
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/HouseholdMembersEditor/components/Household.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/HouseholdMembersEditor/components/Household.vue
index 98f5b0e45..5904737c8 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/HouseholdMembersEditor/components/Household.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/HouseholdMembersEditor/components/Household.vue
@@ -146,7 +146,7 @@ export default {
             validFrom: false,
             validTo: false,
           },
-          hideAddress: true,
+          onlyButton: true,
           button: {
             text:  {
               create: 'household_members_editor.household.set_address',
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig
index ceb835d2e..9946bc8bf 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig
@@ -32,7 +32,7 @@
                     {% include '@ChillMain/Address/_insert_vue_address.html.twig' with {
                         targetEntity: { name: 'household', id: household.id },
                         backUrl: path('chill_person_household_summary', { 'household_id': household.id }),
-                        hideAddress: true,
+                        onlyButton: true,
                         mode: 'new',
                         buttonSize: 'btn-sm',
                         buttonText: 'Move household',
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 701bf38e8..048b7b013 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -73,7 +73,7 @@ export default {
          addAddress: {
             options: {
                openPanesInModal: true,
-               hideAddress: false,
+               onlyButton: false,
                /*
                button: {
                   text:  {

From 59fed905e97ed9b3e6477cc57b351078e4ef2c30 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 14:37:05 +0200
Subject: [PATCH 27/45] AddAddress: in onlyButton case, button is not in
 ul.record_actions

---
 .../vuejs/Address/components/ActionButtons.vue       | 12 +++++-------
 .../public/vuejs/Address/components/ShowPane.vue     | 12 +++++-------
 2 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue
index 501d14e03..a90cb4bb9 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ActionButtons.vue
@@ -1,17 +1,18 @@
 <template>
-   <ul class="record_actions"
+   <ul class="record_actions" v-if="!options.onlyButton"
       :class="{ 'sticky-form-buttons': isStickyForm }">
 
       <li v-if="isStickyForm" class="cancel">
          <slot name="before"></slot>
       </li>
-
-      <slot name="action"></slot>
-
+      <li>
+        <slot name="action"></slot>
+      </li>
       <li v-if="isStickyForm">
          <slot name="after"></slot>
       </li>
    </ul>
+    <slot v-else name="action"></slot>
 </template>
 
 <script>
@@ -23,9 +24,6 @@ export default {
          return (typeof this.options.stickyActions !== 'undefined') ?
             this.options.stickyActions : this.defaultz.stickyActions;
       },
-   },
-   methods: {
-
    }
 }
 </script>
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue
index 10161f761..8f80b840e 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/ShowPane.vue
@@ -28,13 +28,11 @@
       :options="this.options"
       :defaultz="this.defaultz">
       <template v-slot:action>
-         <li>
-            <button @click.prevent="$emit('openEditPane')"
-               class="btn" :class="getClassButton"
-               type="button" name="button" :title="$t(getTextButton)">
-               <span v-if="displayTextButton">{{ $t(getTextButton) }}</span>
-            </button>
-         </li>
+         <button @click.prevent="$emit('openEditPane')"
+            class="btn" :class="getClassButton"
+            type="button" name="button" :title="$t(getTextButton)">
+            <span v-if="displayTextButton">{{ $t(getTextButton) }}</span>
+         </button>
       </template>
    </action-buttons>
 

From 92e6506ecbba4d2ff12acbcf142e720738ecdcce Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 14:46:21 +0200
Subject: [PATCH 28/45] tp: adapt controller/entity/formtype to works with new
 ACL (TO BE CHECKED)

* rename type by types -> getTypes() getter
* adapt controller to fix centers errors
* remove voteOnAttribute return always true in voter
---
 .../Controller/ThirdPartyController.php       | 53 +++++--------------
 .../Entity/ThirdParty.php                     |  2 +-
 .../Form/ThirdPartyType.php                   |  6 +--
 .../views/ThirdParty/index.html.twig          |  2 +-
 .../Resources/views/ThirdParty/new.html.twig  |  2 +-
 .../Resources/views/ThirdParty/show.html.twig |  2 +-
 .../views/ThirdParty/update.html.twig         |  2 +-
 .../Security/Voter/ThirdPartyVoter.php        |  2 -
 8 files changed, 22 insertions(+), 49 deletions(-)

diff --git a/src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php b/src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php
index d16934b18..23b8d3542 100644
--- a/src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php
+++ b/src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php
@@ -60,22 +60,12 @@ class ThirdPartyController extends Controller
         $this->denyAccessUnlessGranted(ThirdPartyVoter::SHOW);
         $repository = $this->getDoctrine()->getManager()
             ->getRepository(ThirdParty::class);
-        
-        $centers = $this->authorizationHelper
-            ->getReachableCenters(
-                $this->getUser(), 
-                new Role(ThirdPartyVoter::SHOW)
-                );
-        
-        $nbThirdParties = $repository->countByMemberOfCenters($centers);
+
+        $nbThirdParties = $repository->count([]); //$repository->countByMemberOfCenters($centers);
         $pagination = $this->paginatorFactory->create($nbThirdParties);
-        
-        $thirdParties = $repository->findByMemberOfCenters(
-            $centers,
-            $pagination->getCurrentPage()->getFirstItemNumber(),
-            $pagination->getItemsPerPage()
-        );
-        
+
+        $thirdParties = $repository->findAll();
+
         return $this->render('ChillThirdPartyBundle:ThirdParty:index.html.twig', array(
             'third_parties' => $thirdParties,
             'pagination' => $pagination
@@ -88,18 +78,9 @@ class ThirdPartyController extends Controller
     public function newAction(Request $request)
     {
         $this->denyAccessUnlessGranted(ThirdPartyVoter::CREATE);
-        
-        $centers = $this->authorizationHelper
-            ->getReachableCenters(
-                $this->getUser(), 
-                new Role(ThirdPartyVoter::CREATE)
-                );
-        
-        if (count($centers) === 0) {
-            throw new \LogicException("There should be at least one center reachable "
-                . "if role ".ThirdPartyVoter::CREATE." is granted");
-        }
-        
+
+        $centers = [];
+
         $thirdParty = new ThirdParty();
         $thirdParty->setCenters(new ArrayCollection($centers));
         
@@ -141,18 +122,12 @@ class ThirdPartyController extends Controller
     public function updateAction(ThirdParty $thirdParty, Request $request)
     {
        $this->denyAccessUnlessGranted(ThirdPartyVoter::CREATE);
-        
-        $centers = $this->authorizationHelper
-            ->getReachableCenters(
-                $this->getUser(), 
-                new Role(ThirdPartyVoter::CREATE)
-                );
-        
-        if (count($centers) === 0) {
-            throw new \LogicException("There should be at least one center reachable "
-                . "if role ".ThirdPartyVoter::CREATE." is granted");
-        }
-        
+
+        $repository = $this->getDoctrine()->getManager()
+            ->getRepository(ThirdParty::class);
+
+        $centers = $repository->findAll();
+
         // we want to keep centers the users has no access to. So we will add them
         // later if they are removed. (this is a ugly hack but it will works
         $centersAssociatedNotForUsers = \array_diff(
diff --git a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
index 30f28791b..21d74f17e 100644
--- a/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
+++ b/src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php
@@ -341,7 +341,7 @@ class ThirdParty
      */
     public function getTypes()
     {
-        return $this->type;
+        return $this->types;
     }
 
     /**
diff --git a/src/Bundle/ChillThirdPartyBundle/Form/ThirdPartyType.php b/src/Bundle/ChillThirdPartyBundle/Form/ThirdPartyType.php
index 2ec113eb9..8eae938f6 100644
--- a/src/Bundle/ChillThirdPartyBundle/Form/ThirdPartyType.php
+++ b/src/Bundle/ChillThirdPartyBundle/Form/ThirdPartyType.php
@@ -64,10 +64,10 @@ class ThirdPartyType extends AbstractType
         }
         if (count($types) === 1) {
             $builder
-                ->add('type', HiddenType::class, [
+                ->add('types', HiddenType::class, [
                     'data' => array_values($types)
                 ])
-                ->get('type')
+                ->get('types')
                     ->addModelTransformer(new CallbackTransformer(
                     function (?array $typeArray): ?string {
                         if (null === $typeArray) {
@@ -84,7 +84,7 @@ class ThirdPartyType extends AbstractType
                 ))
             ;
         } else {
-            $builder->add('type', ChoiceType::class, [
+            $builder->add('types', ChoiceType::class, [
                 'choices' => $types,
                 'expanded' => true,
                 'multiple' => true,
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/index.html.twig b/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/index.html.twig
index fa9ad8b8b..1cd1a6257 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/index.html.twig
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/index.html.twig
@@ -51,7 +51,7 @@
                             <th>{{ (tp.active ? '<i class="fa fa-check chill-green">' : '<i class="fa fa-times chill-red">')|raw }}</th>
                             <td>{{ tp.name }}</td>
                             {% set types = [] %}
-                            {% for t in tp.type %}
+                            {% for t in tp.types %}
                                 {% set types = types|merge( [ ('chill_3party.key_label.'~t)|trans ] ) %}
                             {% endfor %}
                             <td>{{ types|join(', ') }}</td>
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/new.html.twig b/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/new.html.twig
index 002cc87e8..319083649 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/new.html.twig
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/new.html.twig
@@ -26,7 +26,7 @@
                 {{ form_row(form.profession) }}
             {% endif %}
 
-            {{ form_row(form.type) }}
+            {{ form_row(form.types) }}
             {{ form_row(form.categories) }}
 
             {{ form_row(form.telephone) }}
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/show.html.twig b/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/show.html.twig
index d711bdefa..a8dc587d7 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/show.html.twig
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/show.html.twig
@@ -48,7 +48,7 @@
 
                 <dt>{{ 'Type'|trans }}</dt>
                 {% set types = [] %}
-                {% for t in thirdParty.type %}
+                {% for t in thirdParty.types %}
                     {% set types = types|merge( [ ('chill_3party.key_label.'~t)|trans ] ) %}
                 {% endfor %}
                 <dd>
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/update.html.twig b/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/update.html.twig
index 01837db05..4433d934b 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/update.html.twig
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/views/ThirdParty/update.html.twig
@@ -43,7 +43,7 @@
                 {{ form_row(form.profession) }}
             {% endif %}
 
-            {{ form_row(form.type) }}
+            {{ form_row(form.types) }}
             {{ form_row(form.categories) }}
 
             {{ form_row(form.telephone) }}
diff --git a/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php b/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
index ab78c7701..986bfb2b9 100644
--- a/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
+++ b/src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php
@@ -56,8 +56,6 @@ class ThirdPartyVoter extends AbstractChillVoter implements ProvideRoleHierarchy
      */
     protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
     {
-        return true;
-
         $user = $token->getUser();
         
         if (!$user instanceof User) {

From a316cb95685181f04b650befacc9c83d6c88e177 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 15:46:34 +0200
Subject: [PATCH 29/45] otf: manage address in edit/create form (wip)

---
 .../Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 048b7b013..850c77bb5 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -42,13 +42,12 @@
             v-bind:aria-label="$t('thirdparty.phonenumber')"
             aria-describedby="phonenumber" />
       </div>
-      <!--
+
       <add-address
          :context="this.context"
          :options="this.addAddress.options"
          :address-changed-callback="submitAddress">
       </add-address>
-      -->
 
    </div>
 </template>

From 4c9d352c467f05167fed17b1047edbd5423ccc8b Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 21:09:11 +0200
Subject: [PATCH 30/45] otf: post/patch thirdparty ok, with addAddress
 creation/edition

---
 .../vuejs/Address/components/AddAddress.vue   | 10 ++---
 .../public/vuejs/_components/OnTheFly.vue     |  3 +-
 .../vuejs/_components/OnTheFly/Create.vue     |  5 ++-
 .../vuejs/_components/OnTheFly/ThirdParty.vue | 43 +++++++++++++------
 4 files changed, 39 insertions(+), 22 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
index 0aa16d5e3..55d8a93d1 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress.vue
@@ -325,9 +325,9 @@ export default {
          return (this.validFrom || this.validTo) ? true : false;
       },
       hasSuggestions() {
-         console.log(this.context.suggestions);
          if (typeof(this.context.suggestions) !== 'undefined') {
-           return this.context.suggestions.length > 0;
+            console.log('hasSuggestions', this.context.suggestions);
+            return this.context.suggestions.length > 0;
          }
          return false;
       },
@@ -353,9 +353,9 @@ export default {
    },
    mounted() {
 
-      console.log('validFrom', this.validFrom);
-      console.log('validTo', this.validTo);
-      console.log('useDatePane', this.useDatePane);
+      //console.log('validFrom', this.validFrom);
+      //console.log('validTo', this.validTo);
+      //console.log('useDatePane', this.useDatePane);
 
       console.log('Mounted now !');
       if (this.context.edit) {
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
index 5f116e057..a87940ba3 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
@@ -160,10 +160,9 @@ export default {
                break;
 
             default:
-               if (typeof this.type === 'undefined') {
+               if (typeof this.type === 'undefined') { // action=create
                   type = this.$refs.castNew.radioType;
                   data = this.$refs.castNew.castDataByType();
-
                } else {
                   throw 'error with object type';
                }
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
index c5d949c4e..f8d221674 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
@@ -72,7 +72,10 @@ export default {
             case 'person':
                return this.$refs.castPerson.$data.person;
             case 'thirdparty':
-               return this.$refs.castThirdparty.$data.thirdparty;
+               let data = this.$refs.castThirdparty.$data.thirdparty;
+               data.name = data.text;
+               data.address = { id: data.address.address_id }
+               return data;
             default:
                throw Error('Invalid type of entity')
          }
diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 850c77bb5..6d28db7c9 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -25,6 +25,14 @@
          <label for="name">{{ $t('thirdparty.name') }}</label>
       </div>
 
+       <add-address
+           key="thirdparty"
+           :context="context"
+           :options="addAddress.options"
+           :address-changed-callback="submitAddress"
+           ref="addAddress">
+       </add-address>
+
       <div class="input-group mb-3">
          <span class="input-group-text" id="email"><i class="fa fa-fw fa-envelope"></i></span>
          <input class="form-control form-control-lg"
@@ -43,12 +51,6 @@
             aria-describedby="phonenumber" />
       </div>
 
-      <add-address
-         :context="this.context"
-         :options="this.addAddress.options"
-         :address-changed-callback="submitAddress">
-      </add-address>
-
    </div>
 </template>
 
@@ -66,6 +68,7 @@ export default {
    },
    data() {
       return {
+         //context: {},
          thirdparty: {
             type: 'thirdparty'
          },
@@ -73,17 +76,13 @@ export default {
             options: {
                openPanesInModal: true,
                onlyButton: false,
-               /*
                button: {
-                  text:  {
-                     create: 'courselocation.add_temporary_address',
-                     edit: 'courselocation.edit_temporary_address'
-                  }
+                  size: 'btn-sm'
                },
                title: {
-                  create: 'courselocation.add_temporary_address',
-                  edit: 'courselocation.edit_temporary_address'
-               } */
+                   create: 'add_an_address_title',
+                   edit: 'edit_address'
+               }
             }
          }
       }
@@ -98,7 +97,14 @@ export default {
             edit: false,
             addressId: null
          };
+         if ( typeof this.thirdparty.address !== 'undefined'
+             && this.thirdparty.address.address_id !== null
+         ) { // to complete
+             context.addressId = this.thirdparty.address.address_id;
+             context.edit = true;
+         }
          console.log('context', context);
+         //this.context = context;
          return context;
       },
    },
@@ -107,11 +113,20 @@ export default {
          getThirdparty(this.id).then(thirdparty => new Promise((resolve, reject) => {
             this.thirdparty = thirdparty;
             console.log('get thirdparty', thirdparty);
+            if (this.action !== 'show') {
+                this.$refs.addAddress.getInitialAddress(thirdparty.address.address_id);
+            }
             resolve();
          }));
       },
       submitAddress(payload) {
          console.log('submitAddress', payload);
+          if (typeof payload.addressId !== 'undefined') {
+              this.context.edit = true;
+              this.context.addressId = payload.addressId;
+              console.log('switch address to edit mode', this.context);
+              this.thirdparty.address = payload.address;
+          }
       }
    },
    mounted() {

From 4047399b76bf70aec680d23d9d4ba0775c361efd Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 30 Sep 2021 21:22:28 +0200
Subject: [PATCH 31/45] otf: comments to remember things to improve

---
 .../public/vuejs/_components/OnTheFly/ThirdParty.vue  | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
index 6d28db7c9..21b79a1c7 100644
--- a/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
+++ b/src/Bundle/ChillThirdPartyBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue
@@ -68,7 +68,7 @@ export default {
    },
    data() {
       return {
-         //context: {},
+         //context: {}, <--
          thirdparty: {
             type: 'thirdparty'
          },
@@ -104,7 +104,7 @@ export default {
              context.edit = true;
          }
          console.log('context', context);
-         //this.context = context;
+         //this.context = context; <--
          return context;
       },
    },
@@ -114,6 +114,7 @@ export default {
             this.thirdparty = thirdparty;
             console.log('get thirdparty', thirdparty);
             if (this.action !== 'show') {
+                // bof! we force getInitialAddress because addressId not available when mounted
                 this.$refs.addAddress.getInitialAddress(thirdparty.address.address_id);
             }
             resolve();
@@ -121,11 +122,11 @@ export default {
       },
       submitAddress(payload) {
          console.log('submitAddress', payload);
-          if (typeof payload.addressId !== 'undefined') {
+          if (typeof payload.addressId !== 'undefined') { // <--
               this.context.edit = true;
-              this.context.addressId = payload.addressId;
+              this.context.addressId = payload.addressId; // bof! use legacy and not legacy in payload
+              this.thirdparty.address = payload.address;  // <--
               console.log('switch address to edit mode', this.context);
-              this.thirdparty.address = payload.address;
           }
       }
    },

From a3e43fcaaaf3a888c8758a9a70a60015c0a97bbd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Thu, 30 Sep 2021 23:27:56 +0200
Subject: [PATCH 32/45] [person form] accept sms is not required

---
 CHANGELOG.md                                     | 4 ++++
 src/Bundle/ChillPersonBundle/Form/PersonType.php | 3 +--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cf27b41f2..34302129a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,10 @@ and this project adheres to
 
 * [Household editor][UI] Update how household suggestion and addresses are picked;
 * [AddAddress] Handle address suggestion;
+* [Person form] "accept sms" not required:
+
+    https://gitlab.com/champs-libres/departement-de-la-vendee/accent-suivi-developpement/-/issues/37
+    https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/221
 
 ## Test release yyyy-mm-dd
 
diff --git a/src/Bundle/ChillPersonBundle/Form/PersonType.php b/src/Bundle/ChillPersonBundle/Form/PersonType.php
index 376310965..8bc982713 100644
--- a/src/Bundle/ChillPersonBundle/Form/PersonType.php
+++ b/src/Bundle/ChillPersonBundle/Form/PersonType.php
@@ -129,8 +129,7 @@ class PersonType extends AbstractType
             $builder
                 ->add('mobilenumber', TelType::class, array('required' => false))
                 ->add('acceptSMS', CheckboxType::class, array(
-                    'value' => false,
-                    'required' => true
+                    'required' => false
                 ));
         }
 

From 8c0abbc5cd73c190b49e373903f3f37dd85ffeb4 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 11:37:06 +0200
Subject: [PATCH 33/45] updating changelog

---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cf27b41f2..36e2a9bdc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,4 +15,4 @@ and this project adheres to
 
 ## Test release yyyy-mm-dd
 
- 
+* On-The-Fly modale works for showing, editing and creating person and thirdparty

From ad72904aa9af471d6608e895367e9f87932c1722 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Mon, 27 Sep 2021 15:12:50 +0200
Subject: [PATCH 34/45] resume accourse: simplify alerts with simple link to
 edit page

---
 .../_join_household.html.twig                 | 49 ++++---------
 .../AccompanyingCourse/_still_draft.html.twig | 16 +++++
 .../_warning_address.html.twig                | 70 +++++--------------
 .../views/AccompanyingCourse/index.html.twig  | 38 ++++------
 .../translations/messages.fr.yml              |  2 +-
 5 files changed, 59 insertions(+), 116 deletions(-)
 create mode 100644 src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_still_draft.html.twig

diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_join_household.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_join_household.html.twig
index c57d12f1e..7ef2de466 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_join_household.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_join_household.html.twig
@@ -1,41 +1,16 @@
-<div class="border border-warning">
-    <div class="alert alert-warning alert-with-actions mb-0">
-        <div class="message">
-            {{ 'Some peoples does not belong to any household currently. Add them to an household soon'|trans }}
-        </div>
-        <ul class="record_actions">
-            <li>
-                <button class="btn btn-chill-beige" data-bs-toggle="collapse" href="#withoutHouseholdList">
-                    <i class="fa fa-fw fa-caret-down"></i><span class="">{{ 'Add to household now'|trans }}</span>
-                </button>
-            </li>
-        </ul>
-    </div>
-
-    <div id="withoutHouseholdList" class="collapse p-3">
-        <form method="GET"
-              action="{{ path('chill_person_household_members_editor') }}">
-
-            <h3>{{ 'household.Select people to move'|trans }}</h3>
-            <ul>
-                {% for p in withoutHousehold %}
-                    <li>
-                        <input type="checkbox" name="persons[]" value="{{ p.id }}" checked />
-                        {{ p|chill_entity_render_box }}
-                    </li>
-                {% endfor %}
-            </ul>
-
-            <input type="hidden" name="expand_suggestions" value="true" />
-            <input type="hidden" name="returnPath" value="{{ app.request.requestUri|escape('html_attr') }}" />
-            <input type="hidden" name="accompanying_period_id" value="{{ accompanyingCourse.id }}" />
-            <ul class="record_actions mb-0">
+<div class="alert alert-warning alert-with-actions">
+    <div class="float-button bottom"><div class="box">
+        <div class="action">
+            <ul class="record_actions">
                 <li>
-                    <button type="submit" class="btn btn-edit">
-                        {{ 'household.Household editor'|trans }}
-                    </button>
+                    <a class="btn btn-sm btn-update change-icon"
+                       href="{{ path('chill_person_accompanying_course_edit', { 'accompanying_period_id': accompanyingCourse.id, '_fragment': 'section-10' }) }}">
+                        <i class="fa fa-fw fa-crosshairs"></i>
+                        Corriger
+                    </a>
                 </li>
             </ul>
-        </form>
-    </div>
+        </div>
+        {{ 'Some peoples does not belong to any household currently. Add them to an household soon'|trans }}
+    </div></div>
 </div>
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_still_draft.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_still_draft.html.twig
new file mode 100644
index 000000000..8e843e284
--- /dev/null
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_still_draft.html.twig
@@ -0,0 +1,16 @@
+<div class="alert alert-warning">
+    <div class="float-button bottom"><div class="box">
+            <div class="action">
+                <ul class="record_actions">
+                    <li>
+                        <a class="btn btn-sm btn-update change-icon"
+                           href="{{ path('chill_person_accompanying_course_edit', { 'accompanying_period_id': accompanyingCourse.id, '_fragment': 'section-100' } ) }}">
+                            <i class="fa fa-fw fa-crosshairs"></i>
+                            {{ 'Edit & activate accompanying course'|trans }}
+                        </a>
+                    </li>
+                </ul>
+            </div>
+            <p>{{ 'This accompanying course is still a draft'|trans }}</p>
+        </div></div>
+</div>
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_warning_address.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_warning_address.html.twig
index 490a91b59..f04a8a376 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_warning_address.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_warning_address.html.twig
@@ -1,61 +1,23 @@
 {%- set countPersonLocation = accompanyingCourse.availablePersonLocation|length -%}
-{%- set hasPersonLocation = countPersonLocation|length > 0 -%}
-{% macro quickLocationForm(accompanyingCourse, person, whichButton) %}
-    <form method="PATCH" action="{{ path('chill_api_single_accompanying_course__entity', {'id': accompanyingCourse.id, '_format': 'json'}) }}" class="quickLocationForm">
-        <input type="hidden" name="personLocation" value="{{ person.id }}" />
-        <input type="hidden" name="periodId" value="{{ accompanyingCourse.id }}" />
-        {% if whichButton == 'string' %}
-        <button type="submit" class="btn btn-chill-pink">
-            <span class="text-light">{{ 'Locate by'|trans }} {{ person|chill_entity_render_string }}</span>
-        </button>
-        {% elseif whichButton == 'icon' %}
-            <button type="submit" class="btn btn-sm btn-secondary">
-                <i class="fa fa-map-marker"></i>
-            </button>
-        {% endif %}
-    </form>
-{% endmacro %}
-<div class="border border-danger">
-    <div class="alert alert-danger {% if hasPersonLocation %}alert-with-actions{% endif %} mb-0">
-        <div class="message">
-            {{ 'This course is located at a temporarily address. You should locate this course to an user'|trans }}
-            {% if not hasPersonLocation %}
-            {{ 'Associate at least one member with an household, and set an address to this household'|trans }}
-            {% endif %}
-        </div>
-
-        {% if 1 == countPersonLocation %}
+{%- set hasPersonLocation = countPersonLocation > 0 -%}
+<div class="alert alert-danger {% if hasPersonLocation %}alert-with-actions{% endif %}">
+    <div class="float-button bottom"><div class="box">
+        <div class="action">
             <ul class="record_actions">
                 <li>
-                    {{ _self.quickLocationForm(accompanyingCourse, accompanyingCourse.availablePersonLocation.first, 'string') }}
+                    <a class="btn btn-sm btn-update change-icon"
+                       href="{{ path('chill_person_accompanying_course_edit', { 'accompanying_period_id': accompanyingCourse.id, '_fragment': 'section-20' }) }}">
+                        <i class="fa fa-fw fa-crosshairs"></i>
+                        Corriger
+                    </a>
                 </li>
             </ul>
-        {% elseif 1 < countPersonLocation %}
-            <ul class="record_actions">
-                <li>
-                    <button class="btn btn-chill-pink" data-bs-toggle="collapse" href="#locateAtPerson">
-                        <i class="fa fa-fw fa-caret-down"></i><span class="text-light">{{ 'Choose a person to locate by'|trans }}</span>
-                    </button>
-                </li>
-            </ul>
-        {% endif %}
-    </div>
-
-    {% if 1 < countPersonLocation %}
-        <div id="locateAtPerson" class="collapse">
-               <p>{{ 'Locate by'|trans }}:</p>
-
-               <div class="flex-table mb-3">
-                   {% for p in accompanyingCourse.availablePersonLocation %}
-                       <div class="item-bloc">
-                         {{ p|chill_entity_render_box({
-                          'render': 'bloc', 'addLink': false, 'addInfo': true, 'addAltNames': false, 'customButtons': {
-                                 'replace': _self.quickLocationForm(accompanyingCourse, p, 'icon')
-                             }
-                         }) }}
-                       </div>
-                   {% endfor %}
-               </div>
         </div>
-    {% endif %}
+            <p>
+        {{ 'This course is located at a temporarily address. You should locate this course to an user'|trans }}</p>
+        {% if not hasPersonLocation %}
+            <p>
+            {{ 'Associate at least one member with an household, and set an address to this household'|trans }}</p>
+        {% endif %}
+    </div></div>
 </div>
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
index be66abe73..a063fbb34 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
@@ -23,20 +23,22 @@
 {% block content %}
 <div class="accompanyingcourse-resume">
 
-    {% if 'DRAFT' == accompanyingCourse.step %}
-        <div class="alert alert-danger flash_message mb-5">
-            <span>
-                {{ 'This accompanying course is still a draft'|trans }}
-                <a href="{{ path('chill_person_accompanying_course_edit', { 'accompanying_period_id': accompanyingCourse.id } ) }}">
-                    {{ 'Edit & activate accompanying course'|trans }}
-                </a>
-            </span>
-        </div>
-    {% endif %}
-
     <pre>WIP .. AccompanyingCourse Resume dashboard</pre>
 
-    {#
+    {% if 'DRAFT' == accompanyingCourse.step %}
+        {% include '@ChillPerson/AccompanyingCourse/_still_draft.html.twig' %}
+    {% endif %}
+    {% if 'DRAFT' != accompanyingCourse.step %}
+        {% if withoutHousehold|length > 0 %}
+            {% include '@ChillPerson/AccompanyingCourse/_join_household.html.twig' %}
+        {% endif %}
+    {% endif %}
+    {% if accompanyingCourse.locationStatus == 'address' or accompanyingCourse.locationStatus == 'none' %}
+        {% include '@ChillPerson/AccompanyingCourse/_warning_address.html.twig' %}
+    {% endif %}
+
+
+    {# DISABLED
     <h1>{{ 'Resume Accompanying Course'|trans }}</h1>
 
     <div class="associated-persons mb-5">
@@ -53,13 +55,6 @@
                 {% endif %}
             {% endfor %}
         </div>
-    #}
-        {% if 'DRAFT' != accompanyingCourse.step %}
-            {% if withoutHousehold|length > 0 %}
-                {% include '@ChillPerson/AccompanyingCourse/_join_household.html.twig' with {} %}
-            {% endif %}
-        {% endif %}
-    {#
     </div>
 
     <div class="location mb-5">
@@ -80,11 +75,6 @@
                 </div>
             </div>
         {% endif %}
-    #}
-        {% if accompanyingCourse.locationStatus == 'address' or accompanyingCourse.locationStatus == 'none' %}
-            {% include '@ChillPerson/AccompanyingCourse/_warning_address.html.twig' with {} %}
-        {% endif %}
-    {#
     </div>
 
     <div class="requestor mb-5">
diff --git a/src/Bundle/ChillPersonBundle/translations/messages.fr.yml b/src/Bundle/ChillPersonBundle/translations/messages.fr.yml
index 8b6b6db58..f8c1207ee 100644
--- a/src/Bundle/ChillPersonBundle/translations/messages.fr.yml
+++ b/src/Bundle/ChillPersonBundle/translations/messages.fr.yml
@@ -186,7 +186,7 @@ No accompanying user: Aucun accompagnant
 No data given: Pas d'information
 Participants: Personnes impliquées
 Create an accompanying course: Créer un parcours
-This accompanying course is still a draft: Ce parcours est à l'état brouillon
+This accompanying course is still a draft: Ce parcours est encore à l'état brouillon.
 Associated peoples: Usagers concernés
 Resources: Interlocuteurs privilégiés
 Requestor: Demandeur

From 2a7e3c0334193b326f6a04261907b47e2067b240 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 11:11:12 +0200
Subject: [PATCH 35/45] resume: display associated persons from accourse

---
 .../AccompanyingCourse/_concerned.html.twig   | 13 +++++++
 .../views/AccompanyingCourse/index.html.twig  | 37 +++++++++++++++----
 2 files changed, 43 insertions(+), 7 deletions(-)
 create mode 100644 src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig

diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig
new file mode 100644
index 000000000..2cfbff27a
--- /dev/null
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig
@@ -0,0 +1,13 @@
+
+
+{% for p in accompanyingCourse.participations %}
+    <span class="badge-person">
+        <a href="{{ path('chill_person_view', { 'person_id': p.person.id }) }}"
+           title="{{ p.person.firstName ~ ' ' ~ p.person.lastName }}">
+
+            {{ p.person|chill_entity_render_box }}
+        </a>
+    </span>
+{% endfor %}
+{{ dump() }}
+
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
index a063fbb34..0fb9115eb 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
@@ -21,21 +21,44 @@
 {% endblock %}
 
 {% block content %}
-<div class="accompanyingcourse-resume">
+<div class="accompanyingcourse-resume row">
 
-    <pre>WIP .. AccompanyingCourse Resume dashboard</pre>
+    <div class="concerned mb-5">
+        {% include '@ChillPerson/AccompanyingCourse/_concerned.html.twig' with {} %}
+    </div>
+
+    <div class="col-md-6 location mb-5">
+        {% if accompanyingCourse.locationStatus == 'person' %}
+            <h5>{{ 'This course is located by'|trans }}</h5>
+            <h4>{{ accompanyingCourse.personLocation|chill_entity_render_string }}</h4>
+        {%  elseif accompanyingCourse.locationStatus == 'address' %}
+            <h4>{{ 'This course has a temporarily location'|trans }}</h4>
+        {% endif %}
+
+        {% if accompanyingCourse.locationStatus != 'none' %}
+            {{ accompanyingCourse.location|chill_entity_render_box }}
+        {% endif %}
+    </div>
 
     {% if 'DRAFT' == accompanyingCourse.step %}
-        {% include '@ChillPerson/AccompanyingCourse/_still_draft.html.twig' %}
+        <div class="col-md-6 warnings mb-5">
+            {% include '@ChillPerson/AccompanyingCourse/_still_draft.html.twig' %}
+        </div>
     {% endif %}
+
+    {% if accompanyingCourse.locationStatus == 'address' or accompanyingCourse.locationStatus == 'none' %}
+        <div class="col-md-6 warnings mb-5">
+            {% include '@ChillPerson/AccompanyingCourse/_warning_address.html.twig' %}
+        </div>
+    {% endif %}
+
     {% if 'DRAFT' != accompanyingCourse.step %}
         {% if withoutHousehold|length > 0 %}
-            {% include '@ChillPerson/AccompanyingCourse/_join_household.html.twig' %}
+            <div class="col-md-6 warnings mb-5">
+                {% include '@ChillPerson/AccompanyingCourse/_join_household.html.twig' %}
+            </div>
         {% endif %}
     {% endif %}
-    {% if accompanyingCourse.locationStatus == 'address' or accompanyingCourse.locationStatus == 'none' %}
-        {% include '@ChillPerson/AccompanyingCourse/_warning_address.html.twig' %}
-    {% endif %}
 
 
     {# DISABLED

From db9a203df054b06a983b2048226719ae333f9f25 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 12:18:40 +0200
Subject: [PATCH 36/45] otf: prepare to create vue root component: moving files

---
 .../{_components/OnTheFly => OnTheFly/components}/Create.vue    | 0
 .../vuejs/{_components => OnTheFly/components}/OnTheFly.vue     | 2 +-
 .../components/PersonsAssociated/ParticipationItem.vue          | 2 +-
 .../public/vuejs/AccompanyingCourse/components/Requestor.vue    | 2 +-
 .../AccompanyingCourse/components/Resources/ResourceItem.vue    | 2 +-
 .../Resources/public/vuejs/_components/AddPersons.vue           | 2 +-
 .../public/vuejs/_components/AddPersons/TypePerson.vue          | 2 +-
 .../public/vuejs/_components/AddPersons/TypeThirdParty.vue      | 2 +-
 8 files changed, 7 insertions(+), 7 deletions(-)
 rename src/Bundle/ChillMainBundle/Resources/public/vuejs/{_components/OnTheFly => OnTheFly/components}/Create.vue (100%)
 rename src/Bundle/ChillMainBundle/Resources/public/vuejs/{_components => OnTheFly/components}/OnTheFly.vue (99%)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/Create.vue
similarity index 100%
rename from src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue
rename to src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/Create.vue
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
similarity index 99%
rename from src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
rename to src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
index a87940ba3..ee58aa202 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
@@ -61,7 +61,7 @@
 
 <script>
 import Modal from 'ChillMainAssets/vuejs/_components/Modal.vue';
-import OnTheFlyCreate from './OnTheFly/Create.vue';
+import OnTheFlyCreate from './Create.vue';
 import OnTheFlyPerson from 'ChillPersonAssets/vuejs/_components/OnTheFly/Person.vue';
 import OnTheFlyThirdparty from 'ChillThirdPartyAssets/vuejs/_components/OnTheFly/ThirdParty.vue';
 
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
index c349ce159..e19dfa05e 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/ParticipationItem.vue
@@ -57,7 +57,7 @@
 </template>
 
 <script>
-import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+import OnTheFly from 'ChillMainAssets/vuejs/OnTheFly/components/OnTheFly.vue';
 import ButtonLocation from '../ButtonLocation.vue';
 import PersonRenderBox from 'ChillPersonAssets/vuejs/_components/Entity/PersonRenderBox.vue';
 import Modal from 'ChillMainAssets/vuejs/_components/Modal';
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
index 437cc23e1..cb4b243bb 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue
@@ -79,7 +79,7 @@
 
 <script>
 import AddPersons from 'ChillPersonAssets/vuejs/_components/AddPersons.vue';
-import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+import OnTheFly from 'ChillMainAssets/vuejs/OnTheFly/components/OnTheFly.vue';
 import PersonRenderBox from '../../_components/Entity/PersonRenderBox.vue';
 import ThirdPartyRenderBox from 'ChillThirdPartyAssets/vuejs/_components/Entity/ThirdPartyRenderBox.vue';
 
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
index f8a61b930..bd70fa090 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue
@@ -33,7 +33,7 @@
 </template>
 
 <script>
-import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+import OnTheFly from 'ChillMainAssets/vuejs/OnTheFly/components/OnTheFly.vue';
 import ButtonLocation from '../ButtonLocation.vue';
 import PersonRenderBox from 'ChillPersonAssets/vuejs/_components/Entity/PersonRenderBox.vue';
 import ThirdPartyRenderBox from 'ChillThirdPartyAssets/vuejs/_components/Entity/ThirdPartyRenderBox.vue';
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
index a31089f76..e2415d1e4 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
@@ -88,7 +88,7 @@
 
 <script>
 import Modal from 'ChillMainAssets/vuejs/_components/Modal';
-import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+import OnTheFly from 'ChillMainAssets/vuejs/OnTheFly/components/OnTheFly.vue';
 import PersonSuggestion from './AddPersons/PersonSuggestion';
 import { searchPersons, searchPersons_2 } from 'ChillPersonAssets/vuejs/_api/AddPersons';
 import { postPerson } from "ChillPersonAssets/vuejs/_api/OnTheFly";
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypePerson.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypePerson.vue
index 1daa5d100..a6b4695f9 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypePerson.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypePerson.vue
@@ -28,7 +28,7 @@
 </template>
 
 <script>
-import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+import OnTheFly from 'ChillMainAssets/vuejs/OnTheFly/components/OnTheFly.vue';
 
 export default {
    name: 'SuggestionPerson',
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypeThirdParty.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypeThirdParty.vue
index f2f0e42c6..0d7a3a88b 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypeThirdParty.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypeThirdParty.vue
@@ -25,7 +25,7 @@
 </template>
 
 <script>
-import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+import OnTheFly from 'ChillMainAssets/vuejs/OnTheFly/components/OnTheFly.vue';
 
 export default {
    name: 'SuggestionThirdParty',

From 1dc01fa8e20e41e9e0430a486c171acca48e08cc Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 13:08:12 +0200
Subject: [PATCH 37/45] create OnTheFly rootComponent structure, and twig
 include template to insert it

---
 .../Resources/public/vuejs/OnTheFly/App.vue   | 49 +++++++++++++++++++
 .../Resources/public/vuejs/OnTheFly/i18n.js   | 24 +++++++++
 .../Resources/public/vuejs/OnTheFly/index.js  | 28 +++++++++++
 .../Resources/public/vuejs/_js/i18n.js        | 18 -------
 .../OnTheFly/_insert_vue_onthefly.html.twig   | 13 +++++
 .../ChillMainBundle/chill.webpack.config.js   |  1 +
 .../vuejs/AccompanyingCourse/js/i18n.js       |  3 +-
 7 files changed, 117 insertions(+), 19 deletions(-)
 create mode 100644 src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
 create mode 100644 src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/i18n.js
 create mode 100644 src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
 create mode 100644 src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
new file mode 100644
index 000000000..0f566f464
--- /dev/null
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
@@ -0,0 +1,49 @@
+<template>
+    <on-the-fly
+        action="action"
+        :type="type"
+        :id="id"
+        @saveFormOnTheFly="saveFormOnTheFly">
+    </on-the-fly>
+</template>
+
+<script>
+import OnTheFly from './components/OnTheFly.vue';
+
+export default {
+    name: "App",
+    components: [
+        'OnTheFly'
+    ],
+    props: ['onTheFly'],
+    computed: {
+        context() {
+            return this.onTheFly.context;
+        },
+        options() {
+            return this.onTheFly.options;
+        },
+        // temp
+        action() {
+            return 'show';  // 'edit', 'create'
+        },
+        type() {
+            return 'person'; // 'thirdparty'
+        },
+        id() {
+            return 1613
+        }
+    },
+    mounted() {
+        console.log('OnTheFly mounted');
+        console.log('OnTheFly: data context', this.context);
+        console.log('OnTheFly: data options', this.options);
+    },
+    methods: {
+        saveFormOnTheFly(payload) {
+            console.log('saveFormOnTheFly', payload);
+        }
+    }
+}
+</script>
+
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/i18n.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/i18n.js
new file mode 100644
index 000000000..3cba67149
--- /dev/null
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/i18n.js
@@ -0,0 +1,24 @@
+const ontheflyMessages = {
+    fr: {
+        onthefly: {
+            show: {
+                person: "Détails de l'usager",
+                thirdparty: "Détails du tiers",
+                file_person: "Ouvrir la fiche de l'usager",
+                file_thirdparty: "Voir le Tiers",
+            },
+            edit: {
+                person: "Modifier un usager",
+                thirdparty: "Modifier un tiers"
+            },
+            create: {
+                button: "Créer \"{q}\"",
+                title: "Création d'un nouvel usager ou d'un tiers professionnel",
+                person: "un nouvel usager",
+                thirdparty: "un nouveau tiers professionnel"
+            },
+        }
+    }
+}
+
+export { ontheflyMessages };
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
new file mode 100644
index 000000000..2b78a569a
--- /dev/null
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
@@ -0,0 +1,28 @@
+import { createApp } from "vue";
+import { _createI18n } from 'ChillMainAssets/vuejs/_js/i18n';
+import { ontheflyMessages } from './i18n.js';
+import App from "./App.vue";
+
+const i18n = _createI18n( ontheflyMessages );
+
+let containers = document.querySelectorAll('.onthefly-container');
+
+containers.forEach((container) => {
+
+    const app = createApp({
+        template: `<app :onTheFly="this.onTheFly" ></app>`,
+        data() {
+            return {
+                onTheFly: {
+                    context: {},
+                    options: {}
+                }
+            }
+        }
+    })
+    .use(i18n)
+    .component('app', App)
+    .mount(container);
+
+    console.log('container dataset', container.dataset);
+});
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
index 5e001a21b..c16b4c65d 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js
@@ -53,24 +53,6 @@ const messages = {
          top: "Haut",
          bottom: "Bas",
       },
-      onthefly: {
-         show: {
-            person: "Détails de l'usager",
-            thirdparty: "Détails du tiers",
-            file_person: "Ouvrir la fiche de l'usager",
-            file_thirdparty: "Voir le Tiers",
-         },
-         edit: {
-            person: "Modifier un usager",
-            thirdparty: "Modifier un tiers"
-         },
-         create: {
-            button: "Créer \"{q}\"",
-            title: "Création d'un nouvel usager ou d'un tiers professionnel",
-            person: "un nouvel usager",
-            thirdparty: "un nouveau tiers professionnel"
-         },
-      },
       renderbox: {
          person: "Usager",
          birthday: {
diff --git a/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig b/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig
new file mode 100644
index 000000000..f43101bbb
--- /dev/null
+++ b/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig
@@ -0,0 +1,13 @@
+{#
+    This Twig template include load vue_onthefly component.
+    It push all variables from context in OnTheFly/App.vue.
+
+    OPTIONS
+    *
+#}
+<div class="onthefly-container"
+
+></div>
+
+{{ encore_entry_script_tags('vue_onthefly') }}
+{{ encore_entry_link_tags('vue_onthefly') }}
diff --git a/src/Bundle/ChillMainBundle/chill.webpack.config.js b/src/Bundle/ChillMainBundle/chill.webpack.config.js
index 7ba42ed97..0204166d0 100644
--- a/src/Bundle/ChillMainBundle/chill.webpack.config.js
+++ b/src/Bundle/ChillMainBundle/chill.webpack.config.js
@@ -61,5 +61,6 @@ module.exports = function(encore, entries)
 
     // Vue entrypoints
     encore.addEntry('vue_address', __dirname + '/Resources/public/vuejs/Address/index.js');
+    encore.addEntry('vue_onthefly', __dirname + '/Resources/public/vuejs/OnTheFly/index.js');
 
 };
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
index 5d1451ff3..f742a6ea0 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js
@@ -1,6 +1,7 @@
 import { personMessages } from 'ChillPersonAssets/vuejs/_js/i18n';
 import { thirdpartyMessages } from 'ChillThirdPartyAssets/vuejs/_js/i18n';
 import { addressMessages } from 'ChillMainAssets/vuejs/Address/i18n';
+import { ontheflyMessages } from 'ChillMainAssets/vuejs/OnTheFly/i18n';
 
 const appMessages = {
    fr: {
@@ -142,7 +143,7 @@ const appMessages = {
    }
 };
 
-Object.assign(appMessages.fr, personMessages.fr, thirdpartyMessages.fr, addressMessages.fr);
+Object.assign(appMessages.fr, personMessages.fr, thirdpartyMessages.fr, addressMessages.fr, ontheflyMessages.fr);
 
 export {
    appMessages

From 65782d3a6bab379f66846cc739b653340e16f376 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 13:11:34 +0200
Subject: [PATCH 38/45] fix js syntax

---
 .../Resources/public/vuejs/OnTheFly/components/OnTheFly.vue   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
index ee58aa202..7cfb04651 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
@@ -174,10 +174,10 @@ export default {
          this.modal.showModal = false;
       },
       buildLocation(id, type) {
-         if (type == 'person') {
+         if (type === 'person') {
             // TODO i18n
             return `/fr/person/${id}/general`;
-         } else if (type == 'thirdparty') {
+         } else if (type === 'thirdparty') {
             return `/fr/thirdparty/thirdparty/${id}/show`;
          }
       }

From 75348f6ba7e09f3b1bf9a2af1837befe8d07b06b Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 14:03:58 +0200
Subject: [PATCH 39/45] otf: add data attributes and pass them in vue component

---
 .../Resources/public/vuejs/OnTheFly/App.vue     | 17 ++++-------------
 .../Resources/public/vuejs/OnTheFly/index.js    | 10 ++++++++--
 .../OnTheFly/_insert_vue_onthefly.html.twig     | 11 ++++++++++-
 3 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
index 0f566f464..ac7d30b36 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
@@ -1,8 +1,9 @@
 <template>
     <on-the-fly
-        action="action"
-        :type="type"
-        :id="id"
+        :type="context.type"
+        :id="context.id"
+        :action="context.action"
+        :buttonText="options.buttonText"
         @saveFormOnTheFly="saveFormOnTheFly">
     </on-the-fly>
 </template>
@@ -22,16 +23,6 @@ export default {
         },
         options() {
             return this.onTheFly.options;
-        },
-        // temp
-        action() {
-            return 'show';  // 'edit', 'create'
-        },
-        type() {
-            return 'person'; // 'thirdparty'
-        },
-        id() {
-            return 1613
         }
     },
     mounted() {
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
index 2b78a569a..46320b091 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
@@ -14,8 +14,14 @@ containers.forEach((container) => {
         data() {
             return {
                 onTheFly: {
-                    context: {},
-                    options: {}
+                    context: {
+                        action:  container.dataset.action,
+                        type:  container.dataset.targetName,
+                        id: parseInt(container.dataset.targetId),
+                    },
+                    options: {
+                        buttonText: container.dataset.buttonText || null
+                    }
                 }
             }
         }
diff --git a/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig b/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig
index f43101bbb..03b4094f7 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig
@@ -3,10 +3,19 @@
     It push all variables from context in OnTheFly/App.vue.
 
     OPTIONS
-    *
+    * targetEntity  {
+          name:     string  'person', 'thirdparty'
+          id:       integer
+      }
+    * action        'show', 'edit', 'create'
+
 #}
 <div class="onthefly-container"
 
+     data-target-name="{{ targetEntity.name|e('html_attr') }}"
+     data-target-id="{{ targetEntity.id|e('html_attr') }}"
+     data-action="{{ action|e('html_attr') }}"
+
 ></div>
 
 {{ encore_entry_script_tags('vue_onthefly') }}

From abd60f7ddfccd06052af1e34e0d8e0bb9b104873 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 14:06:15 +0200
Subject: [PATCH 40/45] resume: include _insert_vue_onthefly template

---
 .../views/AccompanyingCourse/_concerned.html.twig  | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig
index 2cfbff27a..5ff6d5583 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig
@@ -1,13 +1,17 @@
-
-
 {% for p in accompanyingCourse.participations %}
+
+    {#
     <span class="badge-person">
         <a href="{{ path('chill_person_view', { 'person_id': p.person.id }) }}"
            title="{{ p.person.firstName ~ ' ' ~ p.person.lastName }}">
-
             {{ p.person|chill_entity_render_box }}
         </a>
     </span>
-{% endfor %}
-{{ dump() }}
+    #}
+
+    A
+    {# include vue_onthefly component #}
+    {% include '@ChillMain/OnTheFly/_insert_vue_onthefly.html.twig' with { targetEntity: { name: 'person', id: p.person.id }, action: 'show' } %}
+
+{% endfor %}
 

From 9ee679a3b3139ccb42a20ebc472758ed63369770 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 14:11:03 +0200
Subject: [PATCH 41/45] fix vue syntax error

---
 .../ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
index ac7d30b36..63c1ad5bd 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
@@ -13,9 +13,9 @@ import OnTheFly from './components/OnTheFly.vue';
 
 export default {
     name: "App",
-    components: [
-        'OnTheFly'
-    ],
+    components: {
+        OnTheFly
+    },
     props: ['onTheFly'],
     computed: {
         context() {

From fbd17a1de62f60394ef4cddd138ac25f55d87573 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 17:38:19 +0200
Subject: [PATCH 42/45] OnTheFly: adding displayBadge option to replace button
 by badge

When using displayBadge=true, you need to pass buttonText=string with badge content.

Limitation: onTheFly cannot use directly PersonRenderBox to display badge,
because it don't have person object in props !
---
 .../Resources/public/vuejs/OnTheFly/App.vue   |  1 +
 .../vuejs/OnTheFly/components/OnTheFly.vue    | 18 ++++++++++---
 .../Resources/public/vuejs/OnTheFly/index.js  |  5 ++--
 .../OnTheFly/_insert_vue_onthefly.html.twig   | 27 ++++++++++++++-----
 .../AccompanyingCourse/_concerned.html.twig   | 17 ------------
 .../views/AccompanyingCourse/index.html.twig  | 12 ++++++++-
 6 files changed, 50 insertions(+), 30 deletions(-)
 delete mode 100644 src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig

diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
index 63c1ad5bd..c4c014e19 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/App.vue
@@ -4,6 +4,7 @@
         :id="context.id"
         :action="context.action"
         :buttonText="options.buttonText"
+        :displayBadge="options.displayBadge === 'true'"
         @saveFormOnTheFly="saveFormOnTheFly">
     </on-the-fly>
 </template>
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
index 7cfb04651..237166e62 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/components/OnTheFly.vue
@@ -1,6 +1,11 @@
 <template>
 
-   <a class="btn btn-sm" target="_blank"
+    <a v-if="isDisplayBadge" @click="openModal">
+        <span class="chill-entity" :class="badgeType">
+            {{ buttonText }}
+        </span>
+    </a>
+    <a v-else class="btn btn-sm" target="_blank"
       :class="classAction"
       :title="$t(titleAction)"
       @click="openModal">
@@ -73,7 +78,7 @@ export default {
       OnTheFlyThirdparty,
       OnTheFlyCreate
    },
-   props: ['type', 'id', 'action', 'buttonText'],
+   props: ['type', 'id', 'action', 'buttonText', 'displayBadge'],
    emits: ['saveFormOnTheFly'],
    data() {
       return {
@@ -123,13 +128,19 @@ export default {
                return 'action.redirect.' + this.type;
          }
       },
-      buttonMessage(){
+      buttonMessage() {
          switch (this.type){
             case 'person':
                return 'onthefly.show.file_' + this.type;
             case 'thirdparty':
                return 'onthefly.show.file_' + this.type;
          }
+      },
+      isDisplayBadge() {
+         return (this.displayBadge === true && this.buttonText !== null);
+      },
+      badgeType() {
+         return 'entity-' + this.type + ' badge-' + this.type;
       }
    },
    methods: {
@@ -189,5 +200,4 @@ export default {
 a {
    cursor: pointer;
 }
-
 </style>
diff --git a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
index 46320b091..88e6aad5e 100644
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/OnTheFly/index.js
@@ -20,7 +20,8 @@ containers.forEach((container) => {
                         id: parseInt(container.dataset.targetId),
                     },
                     options: {
-                        buttonText: container.dataset.buttonText || null
+                        buttonText: container.dataset.buttonText || null,
+                        displayBadge: container.dataset.displayBadge || false
                     }
                 }
             }
@@ -30,5 +31,5 @@ containers.forEach((container) => {
     .component('app', App)
     .mount(container);
 
-    console.log('container dataset', container.dataset);
+    //console.log('container dataset', container.dataset);
 });
diff --git a/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig b/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig
index 03b4094f7..e63fd9ee0 100644
--- a/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig
+++ b/src/Bundle/ChillMainBundle/Resources/views/OnTheFly/_insert_vue_onthefly.html.twig
@@ -7,16 +7,31 @@
           name:     string  'person', 'thirdparty'
           id:       integer
       }
-    * action        'show', 'edit', 'create'
+    * action        string  'show', 'edit', 'create'
+    * buttonText    string
+    * displayBadge  boolean (default: false)  replace button by badge, need to define buttonText for content
 
 #}
-<div class="onthefly-container"
+<span class="onthefly-container"
 
-     data-target-name="{{ targetEntity.name|e('html_attr') }}"
-     data-target-id="{{ targetEntity.id|e('html_attr') }}"
-     data-action="{{ action|e('html_attr') }}"
+    data-target-name="{{ targetEntity.name|e('html_attr') }}"
+    data-target-id="{{ targetEntity.id|e('html_attr') }}"
 
-></div>
+    {% if action is defined %}
+        data-action="{{ action|e('html_attr') }}"
+    {% else %}
+        data-action="show"
+    {% endif %}
+
+    {% if buttonText is defined %}
+        data-button-text="{{ buttonText|e('html_attr') }}"
+    {% endif %}
+
+    {% if displayBadge is defined and displayBadge == 1 %}
+        data-display-badge="true"
+    {% endif %}
+
+></span>
 
 {{ encore_entry_script_tags('vue_onthefly') }}
 {{ encore_entry_link_tags('vue_onthefly') }}
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig
deleted file mode 100644
index 5ff6d5583..000000000
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/_concerned.html.twig
+++ /dev/null
@@ -1,17 +0,0 @@
-{% for p in accompanyingCourse.participations %}
-
-    {#
-    <span class="badge-person">
-        <a href="{{ path('chill_person_view', { 'person_id': p.person.id }) }}"
-           title="{{ p.person.firstName ~ ' ' ~ p.person.lastName }}">
-            {{ p.person|chill_entity_render_box }}
-        </a>
-    </span>
-    #}
-
-    A
-    {# include vue_onthefly component #}
-    {% include '@ChillMain/OnTheFly/_insert_vue_onthefly.html.twig' with { targetEntity: { name: 'person', id: p.person.id }, action: 'show' } %}
-
-{% endfor %}
-
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
index 0fb9115eb..fa30389fc 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
@@ -24,7 +24,17 @@
 <div class="accompanyingcourse-resume row">
 
     <div class="concerned mb-5">
-        {% include '@ChillPerson/AccompanyingCourse/_concerned.html.twig' with {} %}
+        {% for p in accompanyingCourse.participations %}
+
+            {# include vue_onthefly component #}
+            {% include '@ChillMain/OnTheFly/_insert_vue_onthefly.html.twig' with {
+                targetEntity: { name: 'person', id: p.person.id },
+                action: 'show',
+                displayBadge: true,
+                buttonText: p.person|chill_entity_render_string
+            } %}
+
+        {% endfor %}
     </div>
 
     <div class="col-md-6 location mb-5">

From 3a3baa79c8155c5e9c33a869794fe187ebc9e201 Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 20:48:45 +0200
Subject: [PATCH 43/45] resume: list associated persons sorted by household.
 add method in entity

---
 .../AccompanyingCourseController.php          |  1 +
 .../Entity/AccompanyingPeriod.php             | 38 +++++++++++++++++++
 .../Resources/public/chill/chillperson.scss   | 21 ++++++++++
 .../views/AccompanyingCourse/index.html.twig  | 28 +++++++++-----
 4 files changed, 79 insertions(+), 9 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseController.php b/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseController.php
index 1bf40d146..5c11f4802 100644
--- a/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseController.php
@@ -118,6 +118,7 @@ class AccompanyingCourseController extends Controller
         return $this->render('@ChillPerson/AccompanyingCourse/index.html.twig', [
             'accompanyingCourse' => $accompanyingCourse,
             'withoutHousehold' => $withoutHousehold,
+            'participationsByHousehold' => $accompanyingCourse->actualParticipationsByHousehold(),
             'works' => $works,
             'activities' => $activities
         ]);
diff --git a/src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php b/src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php
index 14fb26f1a..8a834736b 100644
--- a/src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php
+++ b/src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php
@@ -513,6 +513,44 @@ class AccompanyingPeriod implements TrackCreationInterface, TrackUpdateInterface
             );
     }
 
+    /**
+     *  Return an array with open participations sorted by household
+     * [
+     *   [
+     *     "household" => Household x,
+     *     "members" => [
+     *        Participation y , Participation z, ...
+     *      ]
+     *   ],
+     * ]
+     *
+     */
+    public function actualParticipationsByHousehold(): array
+    {
+        $participations = $this->getOPenParticipations()->toArray();
+
+        $households = [];
+        foreach ($participations as $p) {
+            $households[] = $p->getPerson()->getCurrentHousehold();
+        }
+        $households = array_unique($households, SORT_REGULAR);
+
+        $array = [];
+        foreach ($households as $household) {
+            $members = [];
+            foreach ($participations as $p) {
+                if ($household === $p->getPerson()->getCurrentHousehold()) {
+                    $members[] = array_shift($participations);
+                } else {
+                    $participations[] = array_shift($participations);
+                }
+            }
+            $array[] = [ 'household' => $household, 'members' => $members ];
+        }
+
+        return $array;
+    }
+
     /**
      * Return true if the accompanying period contains a person.
      *
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/chill/chillperson.scss b/src/Bundle/ChillPersonBundle/Resources/public/chill/chillperson.scss
index 071d0f9a5..64ea09cdc 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/chill/chillperson.scss
+++ b/src/Bundle/ChillPersonBundle/Resources/public/chill/chillperson.scss
@@ -247,3 +247,24 @@ span.fa-holder {
         font-family: "Open Sans Extrabold";
     }
 }
+
+div.accompanyingcourse-resume {
+    div.associated-persons {
+        span.household {
+            border-radius: 8px;
+            border: 1px solid $white;
+            &:hover {
+                border: 1px solid $chill-beige;
+            }
+            i {
+                color: $chill-beige;
+            }
+            padding: 0.5em;
+            margin-right: 2px;
+            span.badge-person, span.badge-thirdparty {
+                margin-bottom: 1em;
+            }
+            &.no-household {}
+        }
+    }
+}
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
index fa30389fc..a879e1ccb 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
@@ -23,17 +23,27 @@
 {% block content %}
 <div class="accompanyingcourse-resume row">
 
-    <div class="concerned mb-5">
-        {% for p in accompanyingCourse.participations %}
+    <div class="associated-persons mb-5">
+        {% for h in participationsByHousehold %}
+            {% set householdClass = (h.household is not null) ? 'household-' ~ h.household.id : 'no-household' %}
+            <span class="household {{ householdClass }}">
+                {% if h.household is not null %}
+                    <a href="{{ path('chill_person_household_summary', { 'household_id': h.household.id }) }}"
+                       title="{{ 'household.Household number'|trans({'household_num': h.household.id }) }}"
+                    ><i class="fa fa-home fa-fw"></i></a>
+                {% endif %}
+                {% for p in h.members %}
 
-            {# include vue_onthefly component #}
-            {% include '@ChillMain/OnTheFly/_insert_vue_onthefly.html.twig' with {
-                targetEntity: { name: 'person', id: p.person.id },
-                action: 'show',
-                displayBadge: true,
-                buttonText: p.person|chill_entity_render_string
-            } %}
+                    {# include vue_onthefly component #}
+                    {% include '@ChillMain/OnTheFly/_insert_vue_onthefly.html.twig' with {
+                        targetEntity: { name: 'person', id: p.person.id },
+                        action: 'show',
+                        displayBadge: true,
+                        buttonText: p.person|chill_entity_render_string
+                    } %}
 
+                {% endfor %}
+            </span>
         {% endfor %}
     </div>
 

From a981661ea570b6f106f59521735bcce0e04643fe Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 21:14:27 +0200
Subject: [PATCH 44/45] resume, list associated_persons : improve design, hover
 effects

---
 .../Resources/public/chill/chillperson.scss        | 14 +++++++++-----
 .../views/AccompanyingCourse/index.html.twig       |  6 ++++--
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/chill/chillperson.scss b/src/Bundle/ChillPersonBundle/Resources/public/chill/chillperson.scss
index 64ea09cdc..094a2eb0a 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/chill/chillperson.scss
+++ b/src/Bundle/ChillPersonBundle/Resources/public/chill/chillperson.scss
@@ -251,20 +251,24 @@ span.fa-holder {
 div.accompanyingcourse-resume {
     div.associated-persons {
         span.household {
+            display: inline-block;
             border-radius: 8px;
             border: 1px solid $white;
             &:hover {
                 border: 1px solid $chill-beige;
+                i {
+                    display: inline-block;
+                }
+            }
+            &.no-household:hover {
+                border: 1px solid $white;
             }
             i {
                 color: $chill-beige;
+                display: none;
             }
-            padding: 0.5em;
+            padding: 0.3em;
             margin-right: 2px;
-            span.badge-person, span.badge-thirdparty {
-                margin-bottom: 1em;
-            }
-            &.no-household {}
         }
     }
 }
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
index a879e1ccb..690ef99e3 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig
@@ -25,8 +25,10 @@
 
     <div class="associated-persons mb-5">
         {% for h in participationsByHousehold %}
-            {% set householdClass = (h.household is not null) ? 'household-' ~ h.household.id : 'no-household' %}
-            <span class="household {{ householdClass }}">
+            {% set householdClass = (h.household is not null) ? 'household-' ~ h.household.id : 'no-household alert alert-warning' %}
+            {% set householdTitle = (h.household is not null) ?
+                'household.Household number'|trans({'household_num': h.household.id }) : 'household.Never in any household'|trans %}
+            <span class="household {{ householdClass }}" title="{{ householdTitle }}">
                 {% if h.household is not null %}
                     <a href="{{ path('chill_person_household_summary', { 'household_id': h.household.id }) }}"
                        title="{{ 'household.Household number'|trans({'household_num': h.household.id }) }}"

From faba2b67ebee578c65ee7285d6d62e42da8fc11c Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Fri, 1 Oct 2021 21:20:19 +0200
Subject: [PATCH 45/45] updating changelog

---
 CHANGELOG.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 36e2a9bdc..8d6286413 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,4 +15,5 @@ and this project adheres to
 
 ## Test release yyyy-mm-dd
 
-* On-The-Fly modale works for showing, editing and creating person and thirdparty
+* On-The-Fly modale works for showing, editing and creating person and thirdparty ;
+* AccompanyingCourse Resume page: list associated persons by household, see household when hover, and show on-the-fly modale when clicking on person ;