From 59da93fd7504d12cb50077e46dd7464e9261d5bc Mon Sep 17 00:00:00 2001
From: Mathieu Jaumotte <mathieu.jaumotte@champs-libres.coop>
Date: Thu, 13 Jul 2023 14:07:01 +0200
Subject: [PATCH] corrections

---
 ...CourseWorkEvaluationDocumentController.php | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseWorkEvaluationDocumentController.php b/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseWorkEvaluationDocumentController.php
index 9d5dd1fbc..88bc4e6b8 100644
--- a/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseWorkEvaluationDocumentController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseWorkEvaluationDocumentController.php
@@ -11,8 +11,6 @@ declare(strict_types=1);
 
 namespace Chill\PersonBundle\Controller;
 
-use Chill\PersonBundle\Entity\AccompanyingPeriod\AccompanyingPeriodWork;
-use Chill\PersonBundle\Entity\AccompanyingPeriod\AccompanyingPeriodWorkEvaluation;
 use Chill\PersonBundle\Entity\AccompanyingPeriod\AccompanyingPeriodWorkEvaluationDocument;
 use Chill\PersonBundle\Security\Authorization\AccompanyingPeriodWorkVoter;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
@@ -22,12 +20,7 @@ use Symfony\Component\Security\Core\Security;
 
 class AccompanyingCourseWorkEvaluationDocumentController extends AbstractController
 {
-    private Security $security;
-
-    public function __construct(Security $security) 
-    {
-        $this->security = $security;
-    }
+    public function __construct(Private Security $security) {}
 
     /**
      * @Route(
@@ -38,16 +31,10 @@ class AccompanyingCourseWorkEvaluationDocumentController extends AbstractControl
      */
     public function showAccompanyingCourseWork(AccompanyingPeriodWorkEvaluationDocument $document): Response
     {
-        $em = $this->getDoctrine()->getManager();
-
-        /** @var AccompanyingPeriodWorkEvaluation $evaluation */
-        $evaluation = $em->getRepository(AccompanyingPeriodWorkEvaluation::class)->find($document->getAccompanyingPeriodWorkEvaluation());
-
-        /** @var AccompanyingPeriodWork $work */
-        $work = $em->getRepository(AccompanyingPeriodWork::class)->find($evaluation->getAccompanyingPeriodWork());
+        $work = $document->getAccompanyingPeriodWorkEvaluation()->getAccompanyingPeriodWork();
 
         return $this->redirectToRoute(
-            $this->security->isGranted(AccompanyingPeriodWorkVoter::UPDATE)?
+            $this->security->isGranted(AccompanyingPeriodWorkVoter::UPDATE, $work) ?
                 'chill_person_accompanying_period_work_edit' : 'chill_person_accompanying_period_work_show', [
             'id' => $work->getId()
         ]);