From 55e94fbe2aa5ba15c0b2ac87ebe4165f47a4d213 Mon Sep 17 00:00:00 2001
From: nobohan <juminet@gmail.com>
Date: Wed, 1 Dec 2021 12:24:39 +0100
Subject: [PATCH] person: retrieve altname config with
 ConfigPersonAltNamesHelper

---
 .../Controller/PersonApiController.php            | 15 ++++++++-------
 .../config/services/controller.yaml               |  1 +
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php b/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
index 1d7726867..bc0aba473 100644
--- a/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/PersonApiController.php
@@ -14,6 +14,7 @@ namespace Chill\PersonBundle\Controller;
 use Chill\MainBundle\CRUD\Controller\ApiController;
 use Chill\MainBundle\Entity\Address;
 use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
+use Chill\PersonBundle\Config\ConfigPersonAltNamesHelper;
 use Chill\PersonBundle\Entity\Person;
 use Chill\PersonBundle\Security\Authorization\PersonVoter;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
@@ -27,10 +28,15 @@ use function array_values;
 class PersonApiController extends ApiController
 {
     private AuthorizationHelper $authorizationHelper;
+    private ConfigPersonAltNamesHelper $configPersonAltNameHelper;
 
-    public function __construct(AuthorizationHelper $authorizationHelper)
+    public function __construct(
+        AuthorizationHelper $authorizationHelper,
+        ConfigPersonAltNamesHelper $configPersonAltNameHelper
+    )
     {
         $this->authorizationHelper = $authorizationHelper;
+        $this->configPersonAltNameHelper = $configPersonAltNameHelper;
     }
 
     public function personAddressApi($id, Request $request, string $_format): Response
@@ -89,12 +95,7 @@ class PersonApiController extends ApiController
      */
     public function configAltNames(Request $request, string $_format): Response
     {
-
-        //TODO get alt_name config from chill person
-        $configAltNames = [
-            ["key" => "jeune_fille", "labels" => ["fr" => "Nom de naissance" ]],
-            ["key" => "surnom", "labels" => ["fr" => "Surnom" ]]
-        ]; //TODO fake data
+        $configAltNames = $this->configPersonAltNameHelper->getChoices();
 
         return $this->json($configAltNames, Response::HTTP_OK, [], ['groups' => ['read']]);
     }
diff --git a/src/Bundle/ChillPersonBundle/config/services/controller.yaml b/src/Bundle/ChillPersonBundle/config/services/controller.yaml
index fb31e8ee9..f5ead52f7 100644
--- a/src/Bundle/ChillPersonBundle/config/services/controller.yaml
+++ b/src/Bundle/ChillPersonBundle/config/services/controller.yaml
@@ -44,6 +44,7 @@ services:
     Chill\PersonBundle\Controller\PersonApiController:
         arguments:
             $authorizationHelper: '@Chill\MainBundle\Security\Authorization\AuthorizationHelper'
+            $configPersonAltNameHelper: '@Chill\PersonBundle\Config\ConfigPersonAltNamesHelper'
         tags: ['controller.service_arguments']
 
     Chill\PersonBundle\Controller\AccompanyingCourseWorkApiController: