From 42b9e25403cc85c48299fedb9e8d8eeaa386519a Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 18 Aug 2021 17:20:17 +0200
Subject: [PATCH] some todo's added in comment + most href's made dynamic

---
 .../vuejs/_components/Entity/PersonRenderBox.vue     | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
index 4e177da21..f30a9a43b 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/Entity/PersonRenderBox.vue
@@ -10,9 +10,11 @@
             <div class="entity-label">
 
                 <!-- NAME TAG -->
+                <!-- todo: make h class dynamic -->
                 <div class="denomination h3">
                 
                     <!-- NAME IF ADD LINK AND PERMISSION GRANTED -->
+                    <!-- todo: change href -->
                     <a v-if="this.options.addLink ==  true" href="#">
                         <span class="firstname">{{ person.firstName }}</span>
                         <span class="lastname">{{ person.lastName }}</span>
@@ -58,7 +60,7 @@
         </div>
         <!-- END LABEL -->
 
-        <!-- EXTRA INFO AND ACTIONS-->
+        <!-- CONTACT INFO AND ACTIONS-->
         <div class="item-col">
             <ul class="list-content fa-ul">
                 <!-- ADDRESS -->
@@ -67,14 +69,14 @@
                     <show-address :address="person.current_household_address" :multiline="false"></show-address>
                 </li>
                 <!-- PHONENUMBER -->
-                <!-- todo: change href for phonenumbers -->
+                <!-- todo: change href for phonenumbers and format phone number? -->
                 <li v-if="this.person.mobilenumber">
                     <i class="fa fa-li fa-mobile"></i>
-                    <a href="#">{{ person.mobilenumber }}</a>
+                    <a :href="'tel: ' + person.mobilenumber">{{ person.mobilenumber }}</a>
                 </li>
                 <li v-else-if="this.person.phonenumber">
                     <i class="fa fa-li fa-phone"></i>
-                    <a href="#">{{ person.phonenumber }}</a>
+                    <a :href="'tel: ' + person.phonenumber">{{ person.phonenumber }}</a>
                 </li>
                 <span v-else class="chill-no-data-statement">{{ $t('renderbox.no_information') }}</span>
                 
@@ -85,7 +87,7 @@
             <slot name="record-actions"></slot>
             <!-- END ACTIONS -->
         </div>
-        <!-- END EXTRA INFO AND ACTIONS -->
+        <!-- END CONTACT INFO AND ACTIONS -->
     </div>
     </section>
     </div>