From 3989c4faffa590d98b22b233895c4abb821dc92b Mon Sep 17 00:00:00 2001
From: Jean-Francois Monfort <jean-francois@monfort.me>
Date: Thu, 14 Jan 2021 10:42:45 +0100
Subject: [PATCH] Fix logger error

---
 Controller/PersonController.php | 23 +++++++++++++++--------
 config/services/controller.yaml |  1 +
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/Controller/PersonController.php b/Controller/PersonController.php
index 37c647fc4..e33179751 100644
--- a/Controller/PersonController.php
+++ b/Controller/PersonController.php
@@ -23,6 +23,7 @@
 namespace Chill\PersonBundle\Controller;
 
 use Chill\PersonBundle\Privacy\PrivacyEvent;
+use Psr\Log\LoggerInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Chill\PersonBundle\Entity\Person;
 use Chill\PersonBundle\Form\PersonType;
@@ -69,21 +70,27 @@ class PersonController extends Controller
      * @var ConfigPersonAltNamesHelper
      */
     protected $configPersonAltNameHelper;
-    
-    public function __construct(
+
+    /**
+     * @var \Psr\Log\LoggerInterface
+     */
+    private $logger;
+
+  public function __construct(
         SimilarPersonMatcher $similarPersonMatcher,
         TranslatorInterface $translator,
         EventDispatcherInterface $eventDispatcher,
         PersonRepository $personRepository,
-        ConfigPersonAltNamesHelper $configPersonAltNameHelper
-        
+        ConfigPersonAltNamesHelper $configPersonAltNameHelper,
+        LoggerInterface $logger
     ) {
         $this->similarPersonMatcher = $similarPersonMatcher;
         $this->translator = $translator;
         $this->eventDispatcher = $eventDispatcher;
         $this->configPersonAltNameHelper = $configPersonAltNameHelper;
         $this->personRepository = $personRepository;
-    }
+        $this->logger = $logger;
+  }
 
     public function getCFGroup()
     {
@@ -296,10 +303,10 @@ class PersonController extends Controller
         $person = $this->_bindCreationForm($form);
         
         $errors = $this->_validatePersonAndAccompanyingPeriod($person);
-        $this->get('logger')->info(sprintf('Person created with %d errors ', count($errors)));
+        $this->logger->info(sprintf('Person created with %d errors ', count($errors)));
 
         if ($errors->count() > 0) {
-            $this->get('logger')->info('The created person has errors');
+            $this->logger->info('The created person has errors');
             $flashBag = $this->get('session')->getFlashBag();
             $translator = $this->get('translator');
 
@@ -321,7 +328,7 @@ class PersonController extends Controller
 
             return $this->_renderNewForm($form);
         } else {
-            $this->get('logger')->info('Person created without errors');
+            $this->logger->info('Person created without errors');
         }
 
         $alternatePersons = $this->similarPersonMatcher
diff --git a/config/services/controller.yaml b/config/services/controller.yaml
index 59413327f..112d609b5 100644
--- a/config/services/controller.yaml
+++ b/config/services/controller.yaml
@@ -6,6 +6,7 @@ services:
             $eventDispatcher: '@Symfony\Component\EventDispatcher\EventDispatcherInterface'
             $personRepository: '@Chill\PersonBundle\Repository\PersonRepository'
             $configPersonAltNameHelper: '@Chill\PersonBundle\Config\ConfigPersonAltNamesHelper'
+            $logger: '@Psr\Log\LoggerInterface'
         tags: ['controller.service_arguments']
 
     Chill\PersonBundle\Controller\TimelinePersonController: