diff --git a/CHANGELOG.md b/CHANGELOG.md index ce9fe509f..b3b7f67c1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,8 +14,15 @@ and this project adheres to * [person] accompanying course work: fix on-the-fly update of thirdParty * [on-the-fly] close modal only after validation * [person] correct thirdparty PATCH url + add email and altnames in AddPerson and serializer (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/433) +* change order for accompanying course work list +* [person]: style fix in parcours listing per person. (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/432) +* ajoute un ordre dans les localisation (api) +## Test releases + +### test release 2021-02-01 +>>>>>>> master * renommer "dossier numéro" en "parcours numéro" dans les résultats de recherche * renomme date de début en date d'ouverture dans le formulaire parcours @@ -35,9 +42,6 @@ and this project adheres to * [fast_actions] improve fast-actions buttons override mechanism, fix https://gitlab.com/champs-libres/departement-de-la-vendee/accent-suivi-developpement/-/issues/413 * [homepage widget] add vue homepage_widget with asynchone loading, give a global view resume of the user concerned actions, notifications, etc. - -## Test releases - ### test release 2021-01-31 * [person] accompanying course: optimisation: do not fetch some resources for the banner (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/409) diff --git a/src/Bundle/ChillActivityBundle/Controller/ActivityController.php b/src/Bundle/ChillActivityBundle/Controller/ActivityController.php index d46136173..3858979ef 100644 --- a/src/Bundle/ChillActivityBundle/Controller/ActivityController.php +++ b/src/Bundle/ChillActivityBundle/Controller/ActivityController.php @@ -220,7 +220,7 @@ final class ActivityController extends AbstractController $this->entityManager->persist($entity); $this->entityManager->flush(); - if ($form->has('gendocTemplateId') && '' !== $form['gendocTemplateId']) { + if ($form->has('gendocTemplateId') && null !== $form['gendocTemplateId']->getData()) { return $this->redirectToRoute( 'chill_docgenerator_generate_from_template', [ @@ -437,7 +437,7 @@ final class ActivityController extends AbstractController $this->entityManager->persist($entity); $this->entityManager->flush(); - if ($form->has('gendocTemplateId') && '' !== $form['gendocTemplateId']) { + if ($form->has('gendocTemplateId') && null !== $form['gendocTemplateId']->getData()) { return $this->redirectToRoute( 'chill_docgenerator_generate_from_template', [ diff --git a/src/Bundle/ChillCalendarBundle/Form/CalendarType.php b/src/Bundle/ChillCalendarBundle/Form/CalendarType.php index 8966ecca8..05dc362b4 100644 --- a/src/Bundle/ChillCalendarBundle/Form/CalendarType.php +++ b/src/Bundle/ChillCalendarBundle/Form/CalendarType.php @@ -97,7 +97,6 @@ class CalendarType extends AbstractType return $res; }, static function (?string $dateAsString): DateTimeImmutable { - return new DateTimeImmutable($dateAsString); } )); diff --git a/src/Bundle/ChillDocStoreBundle/Resources/views/AccompanyingCourseDocument/_workflow.html.twig b/src/Bundle/ChillDocStoreBundle/Resources/views/AccompanyingCourseDocument/_workflow.html.twig index 0a1942f6d..6c664b314 100644 --- a/src/Bundle/ChillDocStoreBundle/Resources/views/AccompanyingCourseDocument/_workflow.html.twig +++ b/src/Bundle/ChillDocStoreBundle/Resources/views/AccompanyingCourseDocument/_workflow.html.twig @@ -8,14 +8,13 @@
{{ document.description }}{% endif %} - +
{{ $t('confirm.sure_description') }}
{{ $t('confirm.no_suggested_referrer') }}
{{ $t('confirm.one_suggested_referrer') }}:
{{ $t('confirm.choose_suggested_referrer') }}
@@ -150,7 +150,6 @@ export default { computed: { ...mapState({ accompanyingCourse: state => state.accompanyingCourse, - filteredReferrersSuggested: state => state.filteredReferrersSuggested }), ...mapGetters([ 'isParticipationValid', @@ -160,15 +159,16 @@ export default { 'isLocationValid', 'isJobValid', 'validationKeys', - 'isValidToBeConfirmed' + 'isValidToBeConfirmed', + 'usersSuggestedFilteredByJob', ]), deleteLink() { return `/fr/parcours/${this.accompanyingCourse.id}/delete`; //TODO locale }, disableConfirm() { - return this.clickedDoNotChooseReferrer - ? (this.accompanyingCourse.user === null && this.filteredReferrersSuggested.length === 0) - : (this.accompanyingCourse.user === null && this.filteredReferrersSuggested.length === 0) || (this.filteredReferrersSuggested.length === 1); + return (this.accompanyingCourse.user === null + && this.usersSuggestedFilteredByJob.length === 1 + && this.clickedDoNotChooseReferrer === false); } }, methods: { @@ -183,7 +183,7 @@ export default { }); }, chooseSuggestedReferrer() { - this.$store.dispatch('updateReferrer', this.filteredReferrersSuggested[0]) + this.$store.dispatch('updateReferrer', this.usersSuggestedFilteredByJob[0]) .catch(({name, violations}) => { if (name === 'ValidationException' || name === 'AccessException') { violations.forEach((violation) => this.$toast.open({message: violation})); diff --git a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Referrer.vue b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Referrer.vue index f8cf0ae0b..0d9465f3a 100644 --- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Referrer.vue +++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Referrer.vue @@ -1,164 +1,178 @@ -
{{ 'notification.comments_list'|trans }}
- + {% if notification.comments|length > 0 %}{{ 'Write a new comment'|trans }}
- + {{ form_start(appendCommentForm) }} {{ form_errors(appendCommentForm) }} {{ form_widget(appendCommentForm.content) }} + {{ form_errors(appendCommentForm.content) }}