From 2d4b6d1dd16c9cca5c615c59336b092073a518f9 Mon Sep 17 00:00:00 2001 From: nobohan Date: Fri, 8 Oct 2021 12:14:45 +0200 Subject: [PATCH] minor correction following MR review + Changelog --- CHANGELOG.md | 2 ++ .../ChillMainBundle/Command/LoadPostalCodesCommand.php | 2 +- src/Bundle/ChillMainBundle/Entity/PostalCode.php | 6 +++--- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9050e6e1c..5a490010a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ and this project adheres to ## Unreleased +* add 3 new fields to PostalCode and adapt postal code command and fixtures + * [Aside activity] Fixes for aside activity * categories with child diff --git a/src/Bundle/ChillMainBundle/Command/LoadPostalCodesCommand.php b/src/Bundle/ChillMainBundle/Command/LoadPostalCodesCommand.php index 7655c2ed8..21090a61f 100644 --- a/src/Bundle/ChillMainBundle/Command/LoadPostalCodesCommand.php +++ b/src/Bundle/ChillMainBundle/Command/LoadPostalCodesCommand.php @@ -142,7 +142,7 @@ class LoadPostalCodesCommand extends Command $output->writeln(''.$num.' were added !'); } - public function getCSVResource(InputInterface $input) + private function getCSVResource(InputInterface $input) { $fs = new Filesystem(); $filename = $input->getArgument('csv_file'); diff --git a/src/Bundle/ChillMainBundle/Entity/PostalCode.php b/src/Bundle/ChillMainBundle/Entity/PostalCode.php index 8855c40f1..91ce46e17 100644 --- a/src/Bundle/ChillMainBundle/Entity/PostalCode.php +++ b/src/Bundle/ChillMainBundle/Entity/PostalCode.php @@ -67,7 +67,7 @@ class PostalCode * @var string * * @ORM\Column(type="string", length=255, nullable=true) - * @groups({"write", "read"}) + * @groups({"read"}) */ private $refPostalCodeId; @@ -75,7 +75,7 @@ class PostalCode * @var string * * @ORM\Column(type="string", length=255, nullable=true) - * @groups({"write", "read"}) + * @groups({"read"}) */ private $postalCodeSource; @@ -83,7 +83,7 @@ class PostalCode * @var Point * * @ORM\Column(type="point", nullable=true) - * @groups({"write", "read"}) + * @groups({"read"}) */ private $center;