From 1fa01474d8b9e9da1b9e1c822f0e6c39c3bcab34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20Fastr=C3=A9?= Date: Tue, 28 Jul 2020 13:11:23 +0200 Subject: [PATCH] make timeline & paginator service private --- Controller/SingleTaskController.php | 16 +++++++++++++--- Resources/config/services/controller.yml | 1 + 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/Controller/SingleTaskController.php b/Controller/SingleTaskController.php index 556dc9ffe..573517cc8 100644 --- a/Controller/SingleTaskController.php +++ b/Controller/SingleTaskController.php @@ -27,6 +27,7 @@ use Symfony\Component\EventDispatcher\EventDispatcherInterface; use Symfony\Component\Translation\TranslatorInterface; use Chill\TaskBundle\Event\UI\UIEvent; use Chill\MainBundle\Repository\CenterRepository; +use Chill\MainBundle\Timeline\TimelineBuilder; class SingleTaskController extends Controller @@ -37,14 +38,23 @@ class SingleTaskController extends Controller */ protected $eventDispatcher; + /** + * + * @var TimelineBuilder + */ + protected $timelineBuilder; + /** * SingleTaskController constructor. * * @param EventDispatcherInterface $eventDispatcher */ - public function __construct(EventDispatcherInterface $eventDispatcher) - { + public function __construct( + EventDispatcherInterface $eventDispatcher, + TimelineBuilder $timelineBuilder + ) { $this->eventDispatcher = $eventDispatcher; + $this->timelineBuilder = $timelineBuilder; } @@ -151,7 +161,7 @@ class SingleTaskController extends Controller throw $this->createNotFoundException('Unable to find Task entity.'); } - $timeline = $this->get('chill.main.timeline_builder') + $timeline = $this->timelineBuilder ->getTimelineHTML('task', array('task' => $task)); $event = new PrivacyEvent($person, array( diff --git a/Resources/config/services/controller.yml b/Resources/config/services/controller.yml index bfeffa0d5..130db2175 100644 --- a/Resources/config/services/controller.yml +++ b/Resources/config/services/controller.yml @@ -6,4 +6,5 @@ services: Chill\TaskBundle\Controller\SingleTaskController: arguments: $eventDispatcher: '@Symfony\Component\EventDispatcher\EventDispatcherInterface' + $timelineBuilder: '@chill_main.timeline_builder' tags: ['controller.service_arguments']