From 0e9933ca413ab0bc8862d77f41167602dc96d8e4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Fastr=C3=A9?= <julien.fastre@champs-libres.coop>
Date: Fri, 18 Jun 2021 11:57:27 +0200
Subject: [PATCH] improve banner

---
 .../Entity/Household/Household.php            | 37 ++++++++++++++++++-
 .../Resources/public/index.js                 |  1 +
 .../public/sass/household_banner.scss         |  5 +++
 .../views/Household/banner.html.twig          | 24 ++++++++----
 4 files changed, 59 insertions(+), 8 deletions(-)
 create mode 100644 src/Bundle/ChillPersonBundle/Resources/public/sass/household_banner.scss

diff --git a/src/Bundle/ChillPersonBundle/Entity/Household/Household.php b/src/Bundle/ChillPersonBundle/Entity/Household/Household.php
index 8cdc47b4a..c8cbccd87 100644
--- a/src/Bundle/ChillPersonBundle/Entity/Household/Household.php
+++ b/src/Bundle/ChillPersonBundle/Entity/Household/Household.php
@@ -196,6 +196,11 @@ class Household
     }
 
     public function getCurrentMembers(?\DateTimeImmutable $now = null): Collection
+    {
+        return $this->getMembers()->matching($this->buildCriteriaCurrentMembers($now));
+    }
+
+    private function buildCriteriaCurrentMembers(?\DateTimeImmutable $now = null): Criteria
     {
         $criteria = new Criteria();
         $expr = Criteria::expr();
@@ -211,7 +216,37 @@ class Household
                 $expr->gte('endDate', $date)
             ));
 
-        return $this->getMembers()->matching($criteria);
+        return $criteria;
+    }
+
+    /**
+     * @return HouseholdMember[]
+     */
+    public function getCurrentMembersOrdered(?\DateTimeImmutable $now = null): Collection
+    {
+        $members = $this->getCurrentMembers($now);
+        
+        $members->getIterator()
+            ->uasort(
+                function (HouseholdMember $a, HouseholdMember $b) {
+                    if ($a->getPosition()->getOrdering() < $b->getPosition()->getOrdering()) {
+                        return -1;
+                    }
+                    if ($a->getPosition()->getOrdering() > $b->getPosition()->getOrdering()) {
+                        return 1;
+                    }
+                    if ($a->isHolder() && !$b->isHolder()) {
+                        return 1;
+                    }
+                    if (!$a->isHolder() && $b->isHolder()) {
+                        return -1;
+                    }
+
+                    return 0;
+                }
+        );
+
+        return $members;
     }
 
     /**
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/index.js b/src/Bundle/ChillPersonBundle/Resources/public/index.js
index e3563b4ff..acdc04579 100644
--- a/src/Bundle/ChillPersonBundle/Resources/public/index.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/index.js
@@ -1,2 +1,3 @@
 require('./sass/person.scss');
 require('./sass/person_with_period.scss');
+require('./sass/household_banner.scss');
diff --git a/src/Bundle/ChillPersonBundle/Resources/public/sass/household_banner.scss b/src/Bundle/ChillPersonBundle/Resources/public/sass/household_banner.scss
new file mode 100644
index 000000000..ea584409c
--- /dev/null
+++ b/src/Bundle/ChillPersonBundle/Resources/public/sass/household_banner.scss
@@ -0,0 +1,5 @@
+.banner-household {
+  .current-members-explain {
+    font-weight: 700;
+  }
+}
diff --git a/src/Bundle/ChillPersonBundle/Resources/views/Household/banner.html.twig b/src/Bundle/ChillPersonBundle/Resources/views/Household/banner.html.twig
index 795861529..d5131223c 100644
--- a/src/Bundle/ChillPersonBundle/Resources/views/Household/banner.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/Household/banner.html.twig
@@ -12,25 +12,35 @@
 
             <div class="grid-3" id="banner-flags"></div>
 
-            <div class="grid-3" id="banner-status"></div>
+            <div class="grid-3" id="banner-status">
+              {% set address = household.currentAddress %}
+              {% if address is empty %}
+              <p class="chill-no-data-statement">{{ 'household.Household does not have any address currently'|trans }}</p>
+              {% else %}
+              <div>
+                {{ address|chill_entity_render_box({'multiline': true, 'with_valid_from': false}) }}
+              </div>
+              {% endif %}
+            </div>
 
         </div>
     </div>
     <div class="grid-12 parent" id="header-accompanying_course-details" >
         <div class="grid-10 push-1 grid-mobile-12 grid-tablet-12 push-mobile-0 push-tablet-0 parent">
             <div id="banner-misc">
-              {%- set persons = household.getCurrentPersons() -%}
-              {%- if persons|length > 0 -%}
+              {%- set members = household.getCurrentMembersOrdered() -%}
+              {%- if members|length > 0 -%}
               <span class="current-members-explain">
               {{- 'household.Current household members'|trans }}:
               </span>
-              {%- for p in persons|slice(0, 5) -%}
-              {{- p|chill_entity_render_box({'addLink': false}) -}}
+              {%- for m in members|slice(0, 5) -%}
+              {{- m.person|chill_entity_render_box({'addLink': false}) -}}
+              {%- if m.holder %} <span class="badge badge-primary">{{ 'household.holder'|trans }}</span>{% endif -%}
               {%- if false == loop.last -%}, {% endif -%}
               {%- endfor -%}
-              {% if persons|length > 5 %}
+              {% if members|length > 5 %}
               <span class="current-members-more">
-              {{ 'household.and x other persons'|trans({'x': persons|length-5}) }}
+              {{ 'household.and x other persons'|trans({'x': members|length-5}) }}
               </span>
               {% endif %} 
               {%- endif -%}