From 00bbbd32d6b80fdac39df8244cb16f986334d4c7 Mon Sep 17 00:00:00 2001 From: nobohan Date: Fri, 13 Apr 2018 17:25:05 +0200 Subject: [PATCH] fix deprecations: use fqcn --- CustomFields/CustomFieldText.php | 3 ++- .../Extension/PostTextIntegerExtensionTest.php | 17 +++++++++-------- .../Extension/PostTextNumberExtensionTest.php | 17 +++++++++-------- 3 files changed, 20 insertions(+), 17 deletions(-) diff --git a/CustomFields/CustomFieldText.php b/CustomFields/CustomFieldText.php index 15105664b..c3ccd838c 100644 --- a/CustomFields/CustomFieldText.php +++ b/CustomFields/CustomFieldText.php @@ -30,6 +30,7 @@ use Symfony\Bundle\TwigBundle\TwigEngine; use Chill\MainBundle\Templating\TranslatableStringHelper; use Symfony\Component\Form\Extension\Core\Type\ChoiceType; use Symfony\Component\Form\Extension\Core\Type\TextareaType; +use Symfony\Component\Form\Extension\Core\Type\IntegerType; /** * @author Julien Fastré @@ -122,7 +123,7 @@ class CustomFieldText extends AbstractCustomField public function buildOptionsForm(FormBuilderInterface $builder) { return $builder - ->add(self::MAX_LENGTH, 'integer', array('empty_data' => 256)) + ->add(self::MAX_LENGTH, IntegerType::class, array('empty_data' => 256)) ->add(self::MULTIPLE_CF_INLINE, ChoiceType::class, array( 'choices' => array( 'Multiple boxes on the line' => '1', diff --git a/Tests/Form/Extension/PostTextIntegerExtensionTest.php b/Tests/Form/Extension/PostTextIntegerExtensionTest.php index 08664735a..5f395abe5 100644 --- a/Tests/Form/Extension/PostTextIntegerExtensionTest.php +++ b/Tests/Form/Extension/PostTextIntegerExtensionTest.php @@ -20,6 +20,7 @@ namespace Chill\CustomFields\Tests\Form\Extension; use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase; +use Symfony\Component\Form\Extension\Core\Type\IntegerType; /** * Test the post-text extension @@ -33,26 +34,26 @@ class PostTextIntegerExtensionTest extends KernelTestCase * @var \Symfony\Component\Form\FormBuilderInterface */ private $formBuilder; - + public function setUp() { self::bootKernel(); - + $container = self::$kernel->getContainer(); - + $this->formBuilder = $container->get('form.factory') ->createBuilder('form', null); } - + public function testCreateView() { - $form = $this->formBuilder->add('test', 'integer', array( + $form = $this->formBuilder->add('test', IntegerType::class, array( 'post_text' => 'my text' ))->getForm(); - + $view = $form->createView(); - + $this->assertEquals('my text', $view['test']->vars['post_text']); } - + } diff --git a/Tests/Form/Extension/PostTextNumberExtensionTest.php b/Tests/Form/Extension/PostTextNumberExtensionTest.php index 4348445d9..86098ac21 100644 --- a/Tests/Form/Extension/PostTextNumberExtensionTest.php +++ b/Tests/Form/Extension/PostTextNumberExtensionTest.php @@ -20,6 +20,7 @@ namespace Chill\CustomFields\Tests\Form\Extension; use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase; +use Symfony\Component\Form\Extension\Core\Type\NumberType; /** * Test the post-text extension @@ -33,26 +34,26 @@ class PostTextNumberExtensionTest extends KernelTestCase * @var \Symfony\Component\Form\FormBuilderInterface */ private $formBuilder; - + public function setUp() { self::bootKernel(); - + $container = self::$kernel->getContainer(); - + $this->formBuilder = $container->get('form.factory') ->createBuilder('form', null); } - + public function testCreateView() { - $form = $this->formBuilder->add('test', 'number', array( + $form = $this->formBuilder->add('test', NumberType::class, array( 'post_text' => 'my text' ))->getForm(); - + $view = $form->createView(); - + $this->assertEquals('my text', $view['test']->vars['post_text']); } - + }